TySS-Dev/capod
1
0
Fork 0
mirror of https://github.com/d4rken-org/capod.git synced 2026-09-15 10:46:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(popup): use fresh broadcast timing for connection popup

Browse Source
This commit is contained in:
darken
2026-04-14 11:28:41 +02:00
committed by Matthias Urhahn
parent a4e7820e6f
commit 46fcf5a4cb
2 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/test/java/eu/darken/capod/reaction/core/popup/PopUpReactionLogicTest.kt
+14 -6
View File
@@ -117,13 +117,13 @@ class PopUpReactionLogicTest : BaseTest() {
hasConnectedDevice: Boolean = true,
hasPodDevice: Boolean = true,
hasAlreadyShown: Boolean = false,
deviceAge: Duration = Duration.ofSeconds(5),
broadcastAge: Duration = Duration.ofSeconds(5),
connectionAge: Duration = Duration.ofSeconds(5),
) = popUpReaction.evaluateConnectionPopUp(
hasConnectedDevice = hasConnectedDevice,
hasPodDevice = hasPodDevice,
hasAlreadyShown = hasAlreadyShown,
deviceAge = deviceAge,
broadcastAge = broadcastAge,
connectionAge = connectionAge,
)
@@ -142,6 +142,14 @@ class PopUpReactionLogicTest : BaseTest() {
evaluate(hasPodDevice = false).shouldShow shouldBe false
}
@Test
fun `connected long ago - should NOT show`() {
evaluate(
broadcastAge = Duration.ofSeconds(5),
connectionAge = Duration.ofSeconds(60),
).shouldShow shouldBe false
}
@Test
fun `already shown for this connection - should NOT show`() {
evaluate(hasAlreadyShown = true).shouldShow shouldBe false
@@ -150,7 +158,7 @@ class PopUpReactionLogicTest : BaseTest() {
@Test
fun `broadcast device age much older than connection (false positive) - should NOT show`() {
evaluate(
deviceAge = Duration.ofSeconds(60),
broadcastAge = Duration.ofSeconds(60),
connectionAge = Duration.ofSeconds(5),
).shouldShow shouldBe false
}
@@ -158,7 +166,7 @@ class PopUpReactionLogicTest : BaseTest() {
@Test
fun `broadcast device age within threshold of connection - should show`() {
evaluate(
deviceAge = Duration.ofSeconds(20),
broadcastAge = Duration.ofSeconds(20),
connectionAge = Duration.ofSeconds(5),
).shouldShow shouldBe true
}
@@ -166,7 +174,7 @@ class PopUpReactionLogicTest : BaseTest() {
@Test
fun `broadcast device age exactly at threshold - should NOT show`() {
evaluate(
deviceAge = Duration.ofSeconds(36),
broadcastAge = Duration.ofSeconds(36),
connectionAge = Duration.ofSeconds(5),
).shouldShow shouldBe false
}
@@ -176,7 +184,7 @@ class PopUpReactionLogicTest : BaseTest() {
// Duration.between(now, pastTimestamp) produces negative durations.
// The false-positive filter must work regardless of sign.
evaluate(
deviceAge = Duration.ofSeconds(-60),
broadcastAge = Duration.ofSeconds(-60),
connectionAge = Duration.ofSeconds(-5),
).shouldShow shouldBe false
}