Remove "Show all devices" setting and always show all devices.

This commit removes the "Show all devices" toggle from General Settings. The app will now always display all nearby Bluetooth devices in the overview, simplifying the UI and device discovery.

The corresponding preference `core.showall.enabled` and its usage have been removed. The debug setting `showUnfiltered` no longer affects this behavior.

app-common/src/main/java/eu/darken/capod/main/core/GeneralSettings.kt

@@ -35,8 +35,6 @@ class GeneralSettings @Inject constructor(
 
     val scannerMode = preferences.createFlowPreference("core.scanner.mode", ScannerMode.BALANCED, moshi)
 
-    val showAll = preferences.createFlowPreference("core.showall.enabled", true)
-
     val minimumSignalQuality = preferences.createFlowPreference("core.signal.minimum", 0.20f)
 
     val mainDeviceAddress = preferences.createFlowPreference<BluetoothAddress?>("core.maindevice.address", null)
@@ -66,7 +64,6 @@ class GeneralSettings @Inject constructor(
         useExtraMonitorNotification,
         keepConnectedNotificationAfterDisconnect,
         scannerMode,
-        showAll,
         minimumSignalQuality,
         mainDeviceAddress,
         isOffloadedFilteringDisabled,

app-common/src/main/java/eu/darken/capod/pods/core/apple/AppleFactory.kt

@@ -83,7 +83,6 @@ class AppleFactory @Inject constructor(
 
         val factory = podFactories.firstOrNull { it.isResponsible(proximityMessage) }
 
-
         return@withLock (factory ?: unknownAppleFactory).create(
             scanResult = scanResult,
             payload = payload,

app/src/main/java/eu/darken/capod/main/ui/overview/OverviewFragmentVM.kt

@@ -104,15 +104,7 @@ class OverviewFragmentVM @Inject constructor(
                 return@flatMapLatest flowOf(emptyList())
             }
 
-            generalSettings.showAll.flow.flatMapLatest { showAll ->
+            podMonitor.devices
-                if (showAll) {
-                    podMonitor.devices
-                } else {
-                    podMonitor.mainDevice.map { mainDevice ->
-                        mainDevice?.let { listOf(it) } ?: emptyList()
-                    }
-                }
-            }
         }
         .catch { errorEvents.postValue(it) }
         .throttleLatest(1000)
@@ -122,10 +114,9 @@ class OverviewFragmentVM @Inject constructor(
         permissionTool.missingPermissions,
         pods,
         debugSettings.isDebugModeEnabled.flow,
-        generalSettings.showAll.flow,
         bluetoothManager.isBluetoothEnabled,
         podMonitor.mainDevice,
-    ) { _, permissions, pods, isDebugMode, showAll, isBluetoothEnabled, mainPod ->
+    ) { _, permissions, pods, isDebugMode, isBluetoothEnabled, mainPod ->
         val items = mutableListOf<OverviewAdapter.Item>()
 
         permissions

app/src/main/java/eu/darken/capod/main/ui/settings/general/debug/DebugSettingsFragmentVM.kt

@@ -4,12 +4,9 @@ import androidx.lifecycle.SavedStateHandle
 import dagger.hilt.android.lifecycle.HiltViewModel
 import eu.darken.capod.common.coroutine.DispatcherProvider
 import eu.darken.capod.common.debug.DebugSettings
-import eu.darken.capod.common.debug.logging.log
 import eu.darken.capod.common.debug.logging.logTag
 import eu.darken.capod.common.uix.ViewModel3
 import eu.darken.capod.main.core.GeneralSettings
-import kotlinx.coroutines.flow.distinctUntilChanged
-import kotlinx.coroutines.flow.onEach
 import javax.inject.Inject
 
 @HiltViewModel
@@ -20,19 +17,6 @@ class DebugSettingsFragmentVM @Inject constructor(
     private val debugSettings: DebugSettings,
 ) : ViewModel3(dispatcherProvider) {
 
-    init {
-        debugSettings.showUnfiltered.flow
-            .distinctUntilChanged()
-            .onEach { showUnfiltered ->
-                if (showUnfiltered) {
-                    log(TAG) { "Enabling 'show all' due to debug setting 'show unfiltered' enabled" }
-                    generalSettings.showAll.value = true
-                }
-            }
-            .launchInViewModel()
-    }
-
-
     companion object {
         private val TAG = logTag("Settings", "Debug", "VM")
     }

app/src/main/res/values/strings.xml

@@ -26,8 +26,6 @@
     <string name="settings_scanner_mode_description">Should the Bluetooth Low Energy data scanner prioritize performance or conserve energy?</string>
     <string name="settings_autopause_label">Auto pause</string>
     <string name="settings_autopause_description">Pause audio when removing the device from your ear.</string>
-    <string name="settings_showall_label">Show all devices</string>
-    <string name="settings_showall_description">Show other people\'s devices that are near you.</string>
     <string name="settings_autopplay_label">Auto play</string>
     <string name="settings_autoplay_description">Start audio playback when device is worn.</string>
     <string name="settings_fake_data_label">Fake data</string>

app/src/main/res/xml/preferences_general.xml

@@ -14,12 +14,6 @@
         android:summary="@string/settings_scanner_mode_description"
         android:title="@string/settings_scanner_mode_label" />
 
-    <eu.darken.capod.common.preferences.MaterialSwitchPreference
-        android:icon="@drawable/ic_baseline_devices_other_24"
-        android:key="core.showall.enabled"
-        android:summary="@string/settings_showall_description"
-        android:title="@string/settings_showall_label" />
-
     <PreferenceCategory android:title="@string/settings_category_yourdevice_label">
 
         <eu.darken.capod.common.preferences.PercentSliderPreference