From 15a81bb0bfa4efb3fc66d23a4659eb45f76aad4e Mon Sep 17 00:00:00 2001 From: edwinwu Date: Mon, 30 Aug 2021 19:41:52 -0700 Subject: [PATCH] Fixes memory leak in AnalyticsRecorder. PiperOrigin-RevId: 393905139 --- cpp/analytics/analytics_recorder.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpp/analytics/analytics_recorder.cc b/cpp/analytics/analytics_recorder.cc index 8542a00c..3f63873c 100644 --- a/cpp/analytics/analytics_recorder.cc +++ b/cpp/analytics/analytics_recorder.cc @@ -284,7 +284,7 @@ void AnalyticsRecorder::OnOutgoingConnectionAttempt( std::unique_ptr &connection_request = pair.mapped(); connection_request->set_local_response(NOT_SENT); connection_request->set_remote_response(NOT_SENT); - UpdateDiscovererConnectionRequestLocked(connection_request.release()); + UpdateDiscovererConnectionRequestLocked(connection_request.get()); } } } @@ -453,8 +453,7 @@ bool AnalyticsRecorder::UpdateAdvertiserConnectionRequestLocked( request->set_duration_millis( absl::ToUnixMillis(SystemClock::ElapsedRealtime()) - request->duration_millis()); - *current_advertising_phase_->add_received_connection_request() = - *std::move(request); + *current_advertising_phase_->add_received_connection_request() = *request; return true; } return false; @@ -472,8 +471,7 @@ bool AnalyticsRecorder::UpdateDiscovererConnectionRequestLocked( request->set_duration_millis( absl::ToUnixMillis(SystemClock::ElapsedRealtime()) - request->duration_millis()); - *current_discovery_phase_->add_sent_connection_request() = - *std::move(request); + *current_discovery_phase_->add_sent_connection_request() = *request; return true; } return false;