From 263b1b4e853d588dc468c605a56d36434a97ad44 Mon Sep 17 00:00:00 2001
From: Janusz Sobczak <jsobczak@google.com>
Date: Tue, 29 Aug 2023 11:54:53 -0700
Subject: [PATCH] Fix thread safety issue

The test could fail if threads needed a bit more time to spin up.
Test only change.

PiperOrigin-RevId: 561097187
---
 internal/platform/multi_thread_executor_test.cc | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/internal/platform/multi_thread_executor_test.cc b/internal/platform/multi_thread_executor_test.cc
index 0085e05a..7166aa6a 100644
--- a/internal/platform/multi_thread_executor_test.cc
+++ b/internal/platform/multi_thread_executor_test.cc
@@ -28,7 +28,7 @@ namespace {
 const int kMaxThreads = 5;
 }
 
-TEST(MultiThreadExecutorTest, ConsructorDestructorWorks) {
+TEST(MultiThreadExecutorTest, ConstructorDestructorWorks) {
   MultiThreadExecutor executor(kMaxThreads);
 }
 
@@ -58,7 +58,7 @@ TEST(MultiThreadExecutorTest, JobsExecuteInParallel) {
   int count = 0;
 
   for (int i = 0; i < kMaxThreads; ++i) {
-    executor.Execute([&count, &mutex, &test_cond, &thread_cond]() {
+    executor.Execute([&]() {
       absl::MutexLock lock(&mutex);
       count++;
       test_cond.Signal();
@@ -69,12 +69,9 @@ TEST(MultiThreadExecutorTest, JobsExecuteInParallel) {
   }
 
   {
-    absl::Duration duration = absl::Milliseconds(kMaxThreads * 100);
     absl::MutexLock lock(&mutex);
     while (count < kMaxThreads) {
-      absl::Time start = absl::Now();
-      if (test_cond.WaitWithTimeout(&mutex, duration)) break;
-      duration -= absl::Now() - start;
+      if (test_cond.WaitWithTimeout(&mutex, absl::Seconds(30))) break;
     }
   }
 
@@ -82,12 +79,9 @@ TEST(MultiThreadExecutorTest, JobsExecuteInParallel) {
   thread_cond.SignalAll();
 
   {
-    absl::Duration duration = absl::Milliseconds(kMaxThreads * 100);
     absl::MutexLock lock(&mutex);
     while (count > 0) {
-      absl::Time start = absl::Now();
-      if (test_cond.WaitWithTimeout(&mutex, duration)) break;
-      duration -= absl::Now() - start;
+      if (test_cond.WaitWithTimeout(&mutex, absl::Seconds(30))) break;
     }
   }
   EXPECT_EQ(count, 0);