TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-16 15:36:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'google3'

Browse Source 
Change-Id: I08c677177d69e257e6fbe6aa32a5854e0eae8c52
This commit is contained in:
Alexey Polyudov
2020-06-04 12:44:32 -07:00
parent fdd8038428 e2a07376f4
commit 264ff0256d
38 changed files with 1910 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpp/core/internal/payload_manager.cc
-21
View File
@@ -442,17 +442,6 @@ class HandleSuccessfulOutgoingChunkRunnable : public Runnable {
return;
}
// nearby:google3-begin
// TODO(reznor): The fact that we've sent total_size bytes (which we will
// always know 1 frame before we get the SUCCESS frame), also tells us this
// is the last chunk - should we add those smarts, or just be simple and
// always have the last IN_PROGRESS have the same numbers as the following
// SUCCESS? I prefer the simplicity, but it'll look stupid if we send all
// the bytes and then remain hanging because the remote device disconnected
// at just that point, so at least consider injecting the smarts.
// TODO(reznor): Should we check whether payload_header.total_size ==
// payload_chunk.offset?
// nearby:google3-end
bool is_last_chunk = (payload_chunk_flags_ &
PayloadTransferFrame::PayloadChunk::LAST_CHUNK) != 0;
PayloadTransferUpdate update(
@@ -516,16 +505,6 @@ class HandleSuccessfulIncomingChunkRunnable : public Runnable {
return;
}
// nearby:google3-begin
// TODO(reznor): The fact that we've received total_size bytes (which we
// will always know 1 frame before we get the SUCCESS frame), also tells us
// this is the last chunk - should we add those smarts, or just be simple
// and always have the last IN_PROGRESS have the same numbers as the
// following SUCCESS? I prefer the simplicity, but it'll look stupid if we
// get all the bytes and then remain hanging because the remote device
// disconnected at just that point, so at least consider injecting the
// smarts.
// nearby:google3-end
bool is_last_chunk = (payload_chunk_flags_ &
PayloadTransferFrame::PayloadChunk::LAST_CHUNK) != 0;
PayloadTransferUpdate update(