From 2d13fb2750700244a1d17062e75d02a581964dc9 Mon Sep 17 00:00:00 2001 From: hai007 Date: Mon, 16 Mar 2026 22:43:52 -0700 Subject: [PATCH] Replace libjingle_peerconnection_api with the proper dependencies. PiperOrigin-RevId: 884814527 --- connections/implementation/mediums/BUILD | 3 ++- .../implementation/mediums/webrtc/BUILD | 10 +++++--- internal/platform/BUILD | 3 ++- internal/platform/implementation/BUILD | 3 ++- internal/platform/implementation/apple/BUILD | 4 ++-- internal/platform/implementation/g3/BUILD | 6 ++--- .../platform/implementation/windows/BUILD | 24 ++++++++++--------- 7 files changed, 31 insertions(+), 22 deletions(-) diff --git a/connections/implementation/mediums/BUILD b/connections/implementation/mediums/BUILD index e12c6e42..beca2b4e 100644 --- a/connections/implementation/mediums/BUILD +++ b/connections/implementation/mediums/BUILD @@ -74,7 +74,8 @@ cc_library( "//internal/platform/implementation:platform", "//internal/platform/implementation:wifi_utils", "//proto/mediums:web_rtc_signaling_frames_cc_proto", - # TODO: Support WebRTC + # "//third_party/webrtc/files/stable/webrtc/api:create_peerconnection_factory", # buildcleaner: keep + # "//third_party/webrtc/files/stable/webrtc/api:jsep", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/container:btree", "@com_google_absl//absl/container:flat_hash_map", diff --git a/connections/implementation/mediums/webrtc/BUILD b/connections/implementation/mediums/webrtc/BUILD index 71662a36..a2b92747 100644 --- a/connections/implementation/mediums/webrtc/BUILD +++ b/connections/implementation/mediums/webrtc/BUILD @@ -45,7 +45,10 @@ cc_library( "//internal/platform:logging", "//internal/platform:types", "//proto/mediums:web_rtc_signaling_frames_cc_proto", - # TODO: Support WebRTC + # "//third_party/webrtc/files/stable/webrtc/api:create_peerconnection_factory", # buildcleaner: keep + # "//third_party/webrtc/files/stable/webrtc/api:data_channel_interface", + # "//third_party/webrtc/files/stable/webrtc/api:jsep", + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/functional:any_invocable", "@com_google_absl//absl/memory", @@ -97,8 +100,9 @@ cc_test( "//internal/platform:test_util", "//internal/platform:types", "//internal/platform/implementation/g3", # buildcleaner: keep - "//third_party/webrtc/files/stable/webrtc/api:libjingle_peerconnection_api", - "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", + # "//third_party/webrtc/files/stable/webrtc/api:data_channel_interface", + # "//third_party/webrtc/files/stable/webrtc/api:jsep", + # "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", "@com_github_protobuf_matchers//protobuf-matchers", "@com_google_absl//absl/strings:string_view", "@com_google_absl//absl/time", diff --git a/internal/platform/BUILD b/internal/platform/BUILD index f2a62bf3..fd82b22d 100644 --- a/internal/platform/BUILD +++ b/internal/platform/BUILD @@ -367,7 +367,8 @@ cc_library( "//internal/platform/implementation:comm", "//internal/platform/implementation:platform", "//internal/platform/implementation:wifi_utils", - # TODO: Support WebRTC + # "//third_party/webrtc/files/stable/webrtc/api:create_peerconnection_factory", # buildcleaner: keep + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/container:flat_hash_map", "@com_google_absl//absl/container:flat_hash_set", diff --git a/internal/platform/implementation/BUILD b/internal/platform/implementation/BUILD index 708acebc..d6092802 100644 --- a/internal/platform/implementation/BUILD +++ b/internal/platform/implementation/BUILD @@ -122,7 +122,8 @@ cc_library( "//internal/platform:uuid", "//internal/proto:credential_cc_proto", "//internal/proto:local_credential_cc_proto", - # TODO: Support WebRTC + # "//third_party/webrtc/files/stable/webrtc/api:create_peerconnection_factory", # buildcleaner: keep + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/container:flat_hash_map", "@com_google_absl//absl/functional:any_invocable", diff --git a/internal/platform/implementation/apple/BUILD b/internal/platform/implementation/apple/BUILD index 141c6ea0..496e5b7d 100644 --- a/internal/platform/implementation/apple/BUILD +++ b/internal/platform/implementation/apple/BUILD @@ -111,8 +111,8 @@ objc_library( "//internal/platform:types", "//internal/proto:tachyon_cc_proto", "//third_party/webrtc/files/stable/webrtc/api/task_queue:default_task_queue_factory", - "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", - "//third_party/webrtc/files/stable/webrtc/api:libjingle_peerconnection_api", + # "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", "//third_party/webrtc/files/stable/webrtc/rtc_base:checks", "//internal/platform:base", "//internal/platform/implementation:comm", diff --git a/internal/platform/implementation/g3/BUILD b/internal/platform/implementation/g3/BUILD index f2a980a2..4aa9171c 100644 --- a/internal/platform/implementation/g3/BUILD +++ b/internal/platform/implementation/g3/BUILD @@ -114,9 +114,9 @@ cc_library( "//internal/platform/implementation:comm", "//internal/platform/implementation:wifi_utils", "//internal/proto:credential_cc_proto", - "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", - "//third_party/webrtc/files/stable/webrtc/api:libjingle_peerconnection_api", - "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", + # "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", + # "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/container:flat_hash_map", "@com_google_absl//absl/container:flat_hash_set", diff --git a/internal/platform/implementation/windows/BUILD b/internal/platform/implementation/windows/BUILD index e8322555..d9b860c6 100644 --- a/internal/platform/implementation/windows/BUILD +++ b/internal/platform/implementation/windows/BUILD @@ -252,10 +252,10 @@ cc_library( "//internal/platform:logging", "//internal/platform:tachyon_express_signaling_messenger", "//internal/platform/implementation:comm", - "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", - "//third_party/webrtc/files/stable/webrtc/api:libjingle_peerconnection_api", - "//third_party/webrtc/files/stable/webrtc/api:rtc_error", - "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", + # "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", + # "//third_party/webrtc/files/stable/webrtc/api:rtc_error", + # "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", "//third_party/webrtc/files/stable/webrtc/rtc_base:threading", "@com_google_absl//absl/strings", ], @@ -374,10 +374,11 @@ cc_library( "//internal/platform/implementation/shared:count_down_latch", "//internal/platform/implementation/windows/generated:types", "//third_party/intel/pie", - "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", - "//third_party/webrtc/files/stable/webrtc/api:libjingle_peerconnection_api", - "//third_party/webrtc/files/stable/webrtc/api:rtc_error", - "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", + # "//third_party/webrtc/files/stable/webrtc/api:create_modular_peer_connection_factory", + # "//third_party/webrtc/files/stable/webrtc/api:data_channel_interface", + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", + # "//third_party/webrtc/files/stable/webrtc/api:rtc_error", + # "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", "//third_party/webrtc/files/stable/webrtc/rtc_base:threading", "@com_google_absl//absl/base:core_headers", "@com_google_absl//absl/base:nullability", @@ -460,9 +461,10 @@ cc_test( ":webrtc", "//internal/platform/implementation:comm", "//internal/platform/implementation:platform_impl", - "//third_party/webrtc/files/stable/webrtc/api:jsep", - "//third_party/webrtc/files/stable/webrtc/api:libjingle_peerconnection_api", - "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", + # "//third_party/webrtc/files/stable/webrtc/api:data_channel_interface", + # "//third_party/webrtc/files/stable/webrtc/api:jsep", + # "//third_party/webrtc/files/stable/webrtc/api:peer_connection_interface", + # "//third_party/webrtc/files/stable/webrtc/api:scoped_refptr", "@com_github_protobuf_matchers//protobuf-matchers", "@com_google_googletest//:gtest_main", ],