Use CredentialSelector for GenerateCredentials()

PiperOrigin-RevId: 501951868
This commit is contained in:
Anay Wadhera
2023-01-13 15:23:35 -08:00
committed by Copybara-Service
parent ac87d5cf50
commit 44fb63f498
4 changed files with 13 additions and 32 deletions
@@ -55,14 +55,14 @@ constexpr absl::Duration kTimeout = absl::Seconds(3);
} // namespace
void CredentialManagerImpl::GenerateCredentials(
const DeviceMetadata& device_metadata,
const std::vector<CredentialSelector>& credential_selectors,
const DeviceMetadata& device_metadata, absl::string_view manager_app_id,
const std::vector<IdentityType>& identity_types,
int credential_life_cycle_days, int contiguous_copy_of_credentials,
GenerateCredentialsResultCallback credentials_generated_cb) {
std::vector<PublicCredential> public_credentials;
std::vector<PrivateCredential> private_credentials;
for (const auto& credential_selector : credential_selectors) {
for (auto identity_type : identity_types) {
// TODO(b/241587906): Get linux time from the platform (like Android)
uint64_t start_time_millis = 0;
const uint64_t gap_millis = credential_life_cycle_days * 24 * 3600 * 1000;
@@ -70,8 +70,7 @@ void CredentialManagerImpl::GenerateCredentials(
for (int index = 0; index < contiguous_copy_of_credentials; index++) {
auto public_private_credentials = CreatePrivateCredential(
device_metadata, credential_selector.identity_type, start_time_millis,
end_time_millis);
device_metadata, identity_type, start_time_millis, end_time_millis);
if (public_private_credentials.second.identity_type() !=
IdentityType::IDENTITY_TYPE_UNSPECIFIED) {
private_credentials.push_back(public_private_credentials.first);
@@ -83,11 +82,8 @@ void CredentialManagerImpl::GenerateCredentials(
}
// Create credential_storage object and invoke SaveCredentials.
// Assume that all credential selectors are for the same manager app and
// account name
credential_storage_ptr_->SaveCredentials(
credential_selectors[0].manager_app_id,
credential_selectors[0].account_name, private_credentials,
manager_app_id, device_metadata.account_name(), private_credentials,
public_credentials, PublicCredentialType::kLocalPublicCredential,
SaveCredentialsResultCallback{
.credentials_saved_cb =