From 52f0e430555e055def345a28b69e2a97111e0710 Mon Sep 17 00:00:00 2001 From: hai007 Date: Fri, 14 May 2021 16:12:10 -0700 Subject: [PATCH] Internal change PiperOrigin-RevId: 373884970 --- .../internal/mediums/webrtc/connection_flow_test.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/cpp/core/internal/mediums/webrtc/connection_flow_test.cc b/cpp/core/internal/mediums/webrtc/connection_flow_test.cc index 04bf9f1f..d845b240 100644 --- a/cpp/core/internal/mediums/webrtc/connection_flow_test.cc +++ b/cpp/core/internal/mediums/webrtc/connection_flow_test.cc @@ -99,12 +99,14 @@ TEST_F(ConnectionFlowTest, SuccessfulOfferAnswerFlow) { // Create and send offer SessionDescriptionWrapper offer = offerer->CreateOffer(); + ASSERT_TRUE(offer.IsValid()); EXPECT_EQ(offer.GetType(), webrtc::SdpType::kOffer); EXPECT_TRUE(answerer->OnOfferReceived(offer)); EXPECT_TRUE(offerer->SetLocalSessionDescription(std::move(offer))); // Create and send answer SessionDescriptionWrapper answer = answerer->CreateAnswer(); + ASSERT_TRUE(answer.IsValid()); EXPECT_EQ(answer.GetType(), webrtc::SdpType::kAnswer); EXPECT_TRUE(offerer->OnAnswerReceived(answer)); EXPECT_TRUE(answerer->SetLocalSessionDescription(std::move(answer))); @@ -151,11 +153,13 @@ TEST_F(ConnectionFlowTest, SetAnswerBeforeOffer) { ASSERT_NE(answerer, nullptr); SessionDescriptionWrapper offer = offerer->CreateOffer(); + ASSERT_TRUE(offer.IsValid()); EXPECT_EQ(offer.GetType(), webrtc::SdpType::kOffer); // Did not set offer as local session description EXPECT_TRUE(answerer->OnOfferReceived(offer)); SessionDescriptionWrapper answer = answerer->CreateAnswer(); + ASSERT_TRUE(answer.IsValid()); EXPECT_EQ(answer.GetType(), webrtc::SdpType::kAnswer); EXPECT_FALSE(offerer->OnAnswerReceived(answer)); } @@ -180,6 +184,7 @@ TEST_F(ConnectionFlowTest, CannotSetSessionDescriptionAfterClose) { ASSERT_NE(offerer, nullptr); SessionDescriptionWrapper offer = offerer->CreateOffer(); + ASSERT_TRUE(offer.IsValid()); EXPECT_EQ(offer.GetType(), webrtc::SdpType::kOffer); EXPECT_TRUE(offerer->CloseIfNotConnected()); @@ -202,6 +207,7 @@ TEST_F(ConnectionFlowTest, CannotReceiveOfferAfterClose) { EXPECT_TRUE(answerer->CloseIfNotConnected()); SessionDescriptionWrapper offer = offerer->CreateOffer(); + ASSERT_TRUE(offer.IsValid()); EXPECT_EQ(offer.GetType(), webrtc::SdpType::kOffer); EXPECT_FALSE(answerer->OnOfferReceived(offer)); @@ -278,12 +284,14 @@ TEST_F(ConnectionFlowTest, TerminateAnswerer) { // Create and send offer SessionDescriptionWrapper offer = offerer->CreateOffer(); + ASSERT_TRUE(offer.IsValid()); EXPECT_EQ(offer.GetType(), webrtc::SdpType::kOffer); EXPECT_TRUE(answerer->OnOfferReceived(offer)); EXPECT_TRUE(offerer->SetLocalSessionDescription(std::move(offer))); // Create and send answer SessionDescriptionWrapper answer = answerer->CreateAnswer(); + ASSERT_TRUE(answer.IsValid()); EXPECT_EQ(answer.GetType(), webrtc::SdpType::kAnswer); EXPECT_TRUE(offerer->OnAnswerReceived(answer)); EXPECT_TRUE(answerer->SetLocalSessionDescription(std::move(answer))); @@ -357,12 +365,14 @@ TEST_F(ConnectionFlowTest, TerminateOfferer) { // Create and send offer SessionDescriptionWrapper offer = offerer->CreateOffer(); + ASSERT_TRUE(offer.IsValid()); EXPECT_EQ(offer.GetType(), webrtc::SdpType::kOffer); EXPECT_TRUE(answerer->OnOfferReceived(offer)); EXPECT_TRUE(offerer->SetLocalSessionDescription(std::move(offer))); // Create and send answer SessionDescriptionWrapper answer = answerer->CreateAnswer(); + ASSERT_TRUE(answer.IsValid()); EXPECT_EQ(answer.GetType(), webrtc::SdpType::kAnswer); EXPECT_TRUE(offerer->OnAnswerReceived(answer)); EXPECT_TRUE(answerer->SetLocalSessionDescription(std::move(answer)));