From 7406ad8bff8e37625577faf3d04daed4c2cec392 Mon Sep 17 00:00:00 2001 From: hai007 Date: Mon, 20 Dec 2021 00:50:48 -0800 Subject: [PATCH] RTCConfiguration's default value for sdp_semantics is about to change from kPlanB to kUnifiedPlan. Because of this, all uses of RTCConfiguration has to be updated to explicitly set the sdp_semantics field. The NO-OP version of this CL would be to set it to kPlanB and file a buganizer issue to track migration from kPlanB to kUnifiedPlan, but because nearby's use cases only uses data channels (i.e. it does not use WebRTC for audio and video) nearby should not care about which SDP semantics is used, and as such this CL goes ahead and updates it to kUnifiedPlan. For more info, see go/plan-b-removal-and-intro-to-unified-plan and b/208964426. PiperOrigin-RevId: 417348949 --- cpp/platform/impl/g3/webrtc.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/cpp/platform/impl/g3/webrtc.cc b/cpp/platform/impl/g3/webrtc.cc index 7394cd7e..0e21c38d 100644 --- a/cpp/platform/impl/g3/webrtc.cc +++ b/cpp/platform/impl/g3/webrtc.cc @@ -61,6 +61,7 @@ void WebRtcMedium::CreatePeerConnection( } webrtc::PeerConnectionInterface::RTCConfiguration rtc_config; + rtc_config.sdp_semantics = webrtc::SdpSemantics::kUnifiedPlan; webrtc::PeerConnectionDependencies dependencies(observer); std::unique_ptr signaling_thread = rtc::Thread::Create();