From 79b99ae0a90791f26504d52faf588579a31cf883 Mon Sep 17 00:00:00 2001 From: Francis Tsui Date: Thu, 30 Jan 2025 10:14:10 -0800 Subject: [PATCH] Fix build breakage from toolchain option changes. PiperOrigin-RevId: 721433123 --- .../implementation/windows/count_down_latch_test.cc | 2 -- .../platform/implementation/windows/file_path_test.cc | 11 ----------- .../implementation/windows/scheduled_executor_test.cc | 2 -- 3 files changed, 15 deletions(-) diff --git a/internal/platform/implementation/windows/count_down_latch_test.cc b/internal/platform/implementation/windows/count_down_latch_test.cc index abdf4b08..1b3e13bc 100644 --- a/internal/platform/implementation/windows/count_down_latch_test.cc +++ b/internal/platform/implementation/windows/count_down_latch_test.cc @@ -93,8 +93,6 @@ TEST_F(CountDownLatchTests, CountDownLatchAwaitSucceeds) { TEST_F(CountDownLatchTests, CountDownLatchAwaitTimeoutTimesOut) { // Arrange - LONG volatile count = 0; - std::unique_ptr countDownLatch = nearby::api::ImplementationPlatform::CreateCountDownLatch(3); diff --git a/internal/platform/implementation/windows/file_path_test.cc b/internal/platform/implementation/windows/file_path_test.cc index 6ae3790d..7473d661 100644 --- a/internal/platform/implementation/windows/file_path_test.cc +++ b/internal/platform/implementation/windows/file_path_test.cc @@ -44,14 +44,6 @@ const wchar_t* kOneIterationNoDotsFileName(L"/incrementfiletesttxt (1)"); const wchar_t* kMultipleDotsFileName(L"increment.file.test.txt"); const wchar_t* kOneIterationMultipleDotsFileName( L"/increment.file.test (1).txt"); -const wchar_t* kImmediateEscape(L"../"); -const wchar_t* kLongEscapeBackSlash(L"..\\test\\..\\..\\test"); -const wchar_t* kTwoLevelFolder(L"/test/test"); -const wchar_t* kLongEscapeSlash(L"../test/../../test"); -const wchar_t* kLongEscapeMixedSlash(L"../test\\..\\../test"); -const wchar_t* kLongEscapeEndingEscape(L"../test/../../test/.."); -const wchar_t* kLongEscapeEndingEscapeWithSlash( - L"../test/../../test/../../../"); const wchar_t* kFileNameWithThreeDots(L"..."); const wchar_t* kFileNameWithFrontTwoDots(L"..file.name.txt"); } // namespace @@ -143,9 +135,6 @@ NameArgumentsShouldReturnBaseDownloadPath) { auto actual(FilePath::GetDownloadPath(parent_folder, file_name)); - auto result_size = actual.size(); - auto default_size = default_download_path_.size(); - EXPECT_EQ(actual, default_download_path_); } diff --git a/internal/platform/implementation/windows/scheduled_executor_test.cc b/internal/platform/implementation/windows/scheduled_executor_test.cc index 118a9e86..e15d55ef 100644 --- a/internal/platform/implementation/windows/scheduled_executor_test.cc +++ b/internal/platform/implementation/windows/scheduled_executor_test.cc @@ -92,8 +92,6 @@ TEST_P(ScheduledExecutorTest, ScheduleSucceeds) { threadIds->push_back(GetCurrentThreadId()); - std::chrono::system_clock::time_point timeNow = - std::chrono::system_clock::now(); std::chrono::system_clock::time_point timeExecuted; // Act