From 8e2f2da45d41a4da4bc34c623cd4ca99844ead4f Mon Sep 17 00:00:00 2001 From: hai007 Date: Fri, 27 Aug 2021 16:49:19 -0700 Subject: [PATCH] Remove GetTid() since it is not used. PiperOrigin-RevId: 393453493 --- cpp/platform/api/executor.h | 2 -- cpp/platform/impl/g3/multi_thread_executor.h | 5 ----- cpp/platform/impl/g3/scheduled_executor.h | 2 -- cpp/platform/public/scheduled_executor.h | 6 ------ cpp/platform/public/single_thread_executor.h | 1 - cpp/platform/public/submittable_executor.h | 5 ----- 6 files changed, 21 deletions(-) diff --git a/cpp/platform/api/executor.h b/cpp/platform/api/executor.h index ee5f5dc6..af96ee60 100644 --- a/cpp/platform/api/executor.h +++ b/cpp/platform/api/executor.h @@ -35,8 +35,6 @@ class Executor { // https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ExecutorService.html#shutdown-- virtual void Shutdown() = 0; - - virtual int GetTid(int index) const = 0; }; } // namespace api diff --git a/cpp/platform/impl/g3/multi_thread_executor.h b/cpp/platform/impl/g3/multi_thread_executor.h index aaba13f7..131015b8 100644 --- a/cpp/platform/impl/g3/multi_thread_executor.h +++ b/cpp/platform/impl/g3/multi_thread_executor.h @@ -47,11 +47,6 @@ class MultiThreadExecutor : public api::SubmittableExecutor { void Shutdown() override { DoShutdown(); } ~MultiThreadExecutor() override { DoShutdown(); } - int GetTid(int index) const override { - const auto* thread = thread_pool_.thread(index); - return thread ? thread->tid() : 0; - } - void ScheduleAfter(absl::Duration delay, Runnable&& runnable) { if (shutdown_) return; thread_pool_.ScheduleAt(absl::Now() + delay, std::move(runnable)); diff --git a/cpp/platform/impl/g3/scheduled_executor.h b/cpp/platform/impl/g3/scheduled_executor.h index bf8b8ba8..7ffcf6c5 100644 --- a/cpp/platform/impl/g3/scheduled_executor.h +++ b/cpp/platform/impl/g3/scheduled_executor.h @@ -43,8 +43,6 @@ class ScheduledExecutor final : public api::ScheduledExecutor { absl::Duration delay) override; void Shutdown() override { executor_.Shutdown(); } - int GetTid(int index) const override { return executor_.GetTid(index); } - private: SingleThreadExecutor executor_; }; diff --git a/cpp/platform/public/scheduled_executor.h b/cpp/platform/public/scheduled_executor.h index dfc0cdd9..921da2a5 100644 --- a/cpp/platform/public/scheduled_executor.h +++ b/cpp/platform/public/scheduled_executor.h @@ -78,12 +78,6 @@ class ABSL_LOCKABLE ScheduledExecutor final : public Lockable { DoShutdown(); } - int GetTid(int index) const { - MutexLock lock(&mutex_); - return impl_->GetTid(index); - } - int Tid() const { return GetTid(0); } - Cancelable Schedule(Runnable&& runnable, absl::Duration duration) ABSL_LOCKS_EXCLUDED(mutex_) { MutexLock lock(&mutex_); diff --git a/cpp/platform/public/single_thread_executor.h b/cpp/platform/public/single_thread_executor.h index ed6b0424..9be5a34a 100644 --- a/cpp/platform/public/single_thread_executor.h +++ b/cpp/platform/public/single_thread_executor.h @@ -33,7 +33,6 @@ class ABSL_LOCKABLE SingleThreadExecutor final : public SubmittableExecutor { ~SingleThreadExecutor() override = default; SingleThreadExecutor(SingleThreadExecutor&&) = default; SingleThreadExecutor& operator=(SingleThreadExecutor&&) = default; - int Tid() const { return GetTid(0); } }; } // namespace nearby diff --git a/cpp/platform/public/submittable_executor.h b/cpp/platform/public/submittable_executor.h index 99485d1b..105f8931 100644 --- a/cpp/platform/public/submittable_executor.h +++ b/cpp/platform/public/submittable_executor.h @@ -73,11 +73,6 @@ class ABSL_LOCKABLE SubmittableExecutor : public api::SubmittableExecutor, MonitoredRunnable(ThreadCheckRunnable(this, std::move(runnable)))); } - int GetTid(int index) const ABSL_LOCKS_EXCLUDED(mutex_) override { - MutexLock lock(&mutex_); - return impl_ ? impl_->GetTid(index) : 0; - } - void Shutdown() ABSL_LOCKS_EXCLUDED(mutex_) override { MutexLock lock(&mutex_); DoShutdown();