diff --git a/presence/implementation/action_factory_test.cc b/presence/implementation/action_factory_test.cc index 02b46434..5eb57076 100644 --- a/presence/implementation/action_factory_test.cc +++ b/presence/implementation/action_factory_test.cc @@ -35,7 +35,7 @@ constexpr uint32_t kFastPairBitMask = 1 << 14; TEST(ActionFactory, CreateActiveUnlockAction) { std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); Action action = ActionFactory::CreateAction(data_elements); @@ -44,10 +44,10 @@ TEST(ActionFactory, CreateActiveUnlockAction) { TEST(ActionFactory, CreateActiveIgnoresUnsupportedActions) { std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); // The action is 32 bit, so the valid range is [0-31] - data_elements.emplace_back(DataElement(ActionBit(-1))); - data_elements.emplace_back(DataElement(ActionBit(32))); + data_elements.emplace_back(ActionBit(-1)); + data_elements.emplace_back(ActionBit(32)); Action action = ActionFactory::CreateAction(data_elements); EXPECT_EQ(action.action, kActiveUnlockBitMask); @@ -71,7 +71,7 @@ TEST(ActionFactory, CreateContextTimestampAndFastPair) { std::vector data_elements; data_elements.emplace_back(DataElement::kContextTimestampFieldType, kTimestamp); - data_elements.emplace_back(DataElement(ActionBit::kFastPairAction)); + data_elements.emplace_back(ActionBit::kFastPairAction); Action action = ActionFactory::CreateAction(data_elements); diff --git a/presence/implementation/advertisement_factory_test.cc b/presence/implementation/advertisement_factory_test.cc index 1847d8aa..f87aa433 100644 --- a/presence/implementation/advertisement_factory_test.cc +++ b/presence/implementation/advertisement_factory_test.cc @@ -61,7 +61,7 @@ TEST(AdvertisementFactory, CreateAdvertisementFromPrivateIdentity) { std::string salt = "AB"; constexpr IdentityType kIdentity = IdentityType::IDENTITY_TYPE_PRIVATE; std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); Action action = ActionFactory::CreateAction(data_elements); BaseBroadcastRequest request = BaseBroadcastRequest(BasePresenceRequestBuilder(kIdentity) @@ -85,8 +85,8 @@ TEST(AdvertisementFactory, CreateAdvertisementFromTrustedIdentity) { std::string salt = "AB"; constexpr IdentityType kIdentity = IdentityType::IDENTITY_TYPE_TRUSTED; std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); - data_elements.emplace_back(DataElement(ActionBit::kFitCastAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); + data_elements.emplace_back(ActionBit::kFitCastAction); Action action = ActionFactory::CreateAction(data_elements); BaseBroadcastRequest request = BaseBroadcastRequest(BasePresenceRequestBuilder(kIdentity) @@ -110,8 +110,8 @@ TEST(AdvertisementFactory, CreateAdvertisementFromProvisionedIdentity) { std::string salt = "AB"; constexpr IdentityType kIdentity = IdentityType::IDENTITY_TYPE_PROVISIONED; std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); - data_elements.emplace_back(DataElement(ActionBit::kFitCastAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); + data_elements.emplace_back(ActionBit::kFitCastAction); Action action = ActionFactory::CreateAction(data_elements); BaseBroadcastRequest request = BaseBroadcastRequest(BasePresenceRequestBuilder(kIdentity) @@ -135,7 +135,7 @@ TEST(AdvertisementFactory, CreateAdvertisementFromPublicIdentity) { std::string salt = "AB"; constexpr IdentityType kIdentity = IdentityType::IDENTITY_TYPE_PUBLIC; std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); Action action = ActionFactory::CreateAction(data_elements); BaseBroadcastRequest request = BaseBroadcastRequest(BasePresenceRequestBuilder(kIdentity) @@ -155,7 +155,7 @@ TEST(AdvertisementFactory, CreateAdvertisementFailsWhenSaltIsTooShort) { std::string salt = "AB"; constexpr IdentityType kIdentity = internal::IDENTITY_TYPE_PRIVATE; std::vector data_elements; - data_elements.emplace_back(DataElement(ActionBit::kActiveUnlockAction)); + data_elements.emplace_back(ActionBit::kActiveUnlockAction); Action action = ActionFactory::CreateAction(data_elements); BaseBroadcastRequest request = BaseBroadcastRequest(BasePresenceRequestBuilder(kIdentity)