TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 14:46:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed the crash in Timer::Stop

Browse Source 
PiperOrigin-RevId: 521822379
This commit is contained in:
Guogang Li
2023-04-04 11:41:44 -07:00
committed by Copybara-Service
parent d3bbab4c81
commit bda3a779bd
3 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/platform/implementation/windows/timer.cc
+8 -1
View File
@@ -16,6 +16,7 @@
#include <memory>
#include "absl/synchronization/mutex.h"
#include "internal/platform/logging.h"
namespace nearby {
@@ -25,6 +26,8 @@ Timer::~Timer() { Stop(); }
bool Timer::Create(int delay, int interval,
absl::AnyInvocable<void()> callback) {
absl::MutexLock lock(&mutex_);
if ((delay < 0) || (interval < 0)) {
NEARBY_LOGS(WARNING) << "Delay and interval shouldn\'t be negative value.";
return false;
@@ -58,6 +61,8 @@ bool Timer::Create(int delay, int interval,
}
bool Timer::Stop() {
absl::MutexLock lock(&mutex_);
if (timer_queue_handle_ == nullptr) {
return true;
}
@@ -81,6 +86,8 @@ bool Timer::Stop() {
}
bool Timer::FireNow() {
absl::MutexLock lock(&mutex_);
if (!timer_queue_handle_ || !callback_) {
return false;
}
@@ -92,7 +99,7 @@ bool Timer::FireNow() {
void CALLBACK Timer::TimerRoutine(PVOID lpParam, BOOLEAN TimerOrWaitFired) {
absl::AnyInvocable<void()>* callback =
reinterpret_cast<absl::AnyInvocable<void()>*>(lpParam);
if (*callback != NULL) {
if (*callback != nullptr) {
(*callback)();
}
}