From dceb1e216bdd22daf37f71026db3d93124841cd4 Mon Sep 17 00:00:00 2001
From: nohle <nohle@google.com>
Date: Tue, 5 Oct 2021 19:01:17 -0700
Subject: [PATCH] Fix analytics recorder's version string type

PiperOrigin-RevId: 401125543
---
 cpp/analytics/analytics_recorder.cc | 7 ++++---
 cpp/analytics/analytics_recorder.h  | 2 --
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/cpp/analytics/analytics_recorder.cc b/cpp/analytics/analytics_recorder.cc
index 699c7c8d..6e1bbc46 100644
--- a/cpp/analytics/analytics_recorder.cc
+++ b/cpp/analytics/analytics_recorder.cc
@@ -28,6 +28,10 @@ namespace location {
 namespace nearby {
 namespace analytics {
 
+namespace {
+const char kVersion[] = "v1.0.0";
+}  // namespace
+
 using ::location::nearby::analytics::proto::ConnectionsLog;
 using ::location::nearby::proto::connections::ACCEPTED;
 using ::location::nearby::proto::connections::ADVERTISER;
@@ -76,9 +80,6 @@ using ::location::nearby::proto::connections::UPGRADE_SUCCESS;
 using ::location::nearby::proto::connections::UPGRADE_UNFINISHED;
 using ::location::nearby::proto::connections::UPGRADED;
 
-// These definitions are necessary before C++17.
-constexpr absl::string_view AnalyticsRecorder::kVersion;
-
 AnalyticsRecorder::AnalyticsRecorder(EventLogger *event_logger)
     : event_logger_(event_logger) {
   started_client_session_time_ = SystemClock::ElapsedRealtime();
diff --git a/cpp/analytics/analytics_recorder.h b/cpp/analytics/analytics_recorder.h
index 8bd64045..55f09a47 100644
--- a/cpp/analytics/analytics_recorder.h
+++ b/cpp/analytics/analytics_recorder.h
@@ -34,8 +34,6 @@ namespace analytics {
 
 class AnalyticsRecorder {
  public:
-  static constexpr absl::string_view kVersion = "v1.0.0";
-
   explicit AnalyticsRecorder(EventLogger *event_logger);
   virtual ~AnalyticsRecorder();