From e9ce9dd1600068811ec7e5c92c8bb290a0ad51ba Mon Sep 17 00:00:00 2001 From: Francis Tsui Date: Mon, 11 Nov 2024 11:18:03 -0800 Subject: [PATCH] Fix passing client credentials into signin. PiperOrigin-RevId: 695417509 --- internal/platform/implementation/signin_attempt.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/internal/platform/implementation/signin_attempt.h b/internal/platform/implementation/signin_attempt.h index c771ede0..aa631a54 100644 --- a/internal/platform/implementation/signin_attempt.h +++ b/internal/platform/implementation/signin_attempt.h @@ -18,6 +18,7 @@ #include #include "absl/functional/any_invocable.h" +#include "absl/strings/string_view.h" #include "internal/platform/implementation/account_info.h" #include "internal/platform/implementation/auth_status.h" @@ -29,11 +30,13 @@ class SigninAttempt { virtual ~SigninAttempt() = default; // Starts a new sign-in attempt. - // `callback` is called with the status of the request and the user_id if the - // request is successful. - // Returns the auth url if the request is successful. + // `callback` is called with the status of the request, client_id, + // client_secret, and account_info if the request is successful. Returns the + // auth url if the request is successful. virtual std::string Start( - absl::AnyInvocable callback) = 0; + absl::AnyInvocable + callback) = 0; // Tears down the machinery set up to request auth tokens, including the HTTP // server.