From 81808a2aabb36381d79b8c2ba7748506ffd36b79 Mon Sep 17 00:00:00 2001
From: hai007 <hais@google.com>
Date: Fri, 19 Feb 2021 11:26:17 -0800
Subject: [PATCH] 358285146 2021-02-18 15:58 -08:00 [Nearby] Continue reading
 frames during bandwidth upgrade.

---
 cpp/core/internal/BUILD               |  1 +
 cpp/core/internal/bwu_manager.cc      | 20 +++++++++++++-------
 cpp/core/internal/bwu_manager.h       |  2 +-
 cpp/core/internal/bwu_manager_test.cc | 18 ++++++++++++++++++
 cpp/platform/base/feature_flags.h     |  1 +
 5 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/cpp/core/internal/BUILD b/cpp/core/internal/BUILD
index f6829072..e593c89f 100644
--- a/cpp/core/internal/BUILD
+++ b/cpp/core/internal/BUILD
@@ -171,6 +171,7 @@ cc_test(
         ":internal_test",
         "//core:core_types",
         "//core/internal/mediums",
+        "//core/internal/mediums:utils",
         "//proto/connections:offline_wire_formats_portable_proto",
         "//platform/base",
         "//platform/base:test_util",
diff --git a/cpp/core/internal/bwu_manager.cc b/cpp/core/internal/bwu_manager.cc
index 01e4c456..42271740 100644
--- a/cpp/core/internal/bwu_manager.cc
+++ b/cpp/core/internal/bwu_manager.cc
@@ -191,12 +191,18 @@ void BwuManager::OnIncomingFrame(OfflineFrame& frame,
   if (parser::GetFrameType(frame) != V1Frame::BANDWIDTH_UPGRADE_NEGOTIATION)
     return;
   auto bwu_frame = frame.v1().bandwidth_upgrade_negotiation();
-  CountDownLatch latch(1);
-  RunOnBwuManagerThread([this, client, endpoint_id, &bwu_frame, &latch]() {
-    OnBwuNegotiationFrame(client, bwu_frame, endpoint_id);
-    latch.CountDown();
-  });
-  latch.Await();
+  if (FeatureFlags::GetInstance().GetFlags().enable_async_bandwidth_upgrade) {
+    RunOnBwuManagerThread([this, client, endpoint_id, bwu_frame]() {
+      OnBwuNegotiationFrame(client, bwu_frame, endpoint_id);
+    });
+  } else {
+    CountDownLatch latch(1);
+    RunOnBwuManagerThread([this, client, endpoint_id, bwu_frame, &latch]() {
+      OnBwuNegotiationFrame(client, bwu_frame, endpoint_id);
+      latch.CountDown();
+    });
+    latch.Await();
+  }
 }
 
 void BwuManager::OnEndpointDisconnect(ClientProxy* client,
@@ -260,7 +266,7 @@ void BwuManager::Revert() {
 }
 
 void BwuManager::OnBwuNegotiationFrame(ClientProxy* client,
-                                       const BwuNegotiationFrame& frame,
+                                       const BwuNegotiationFrame frame,
                                        const string& endpoint_id) {
   NEARBY_LOG(INFO, "OnBwuNegotiationFrame for endpoint %s",
              endpoint_id.c_str());
diff --git a/cpp/core/internal/bwu_manager.h b/cpp/core/internal/bwu_manager.h
index a1f6c480..3895faf8 100644
--- a/cpp/core/internal/bwu_manager.h
+++ b/cpp/core/internal/bwu_manager.h
@@ -100,7 +100,7 @@ class BwuManager : public EndpointManager::FrameProcessor {
   // Processes the BwuNegotiationFrames that come over the
   // EndpointChannel on both initiator and responder side of the upgrade.
   void OnBwuNegotiationFrame(ClientProxy* client,
-                             const BwuNegotiationFrame& frame,
+                             const BwuNegotiationFrame frame,
                              const string& endpoint_id);
 
   // Called to revert any state changed by the Initiator or Responder in the
diff --git a/cpp/core/internal/bwu_manager_test.cc b/cpp/core/internal/bwu_manager_test.cc
index e3fb271a..231b0cfd 100644
--- a/cpp/core/internal/bwu_manager_test.cc
+++ b/cpp/core/internal/bwu_manager_test.cc
@@ -6,6 +6,7 @@
 #include "core/internal/endpoint_channel_manager.h"
 #include "core/internal/endpoint_manager.h"
 #include "core/internal/mediums/mediums.h"
+#include "core/internal/mediums/utils.h"
 #include "platform/public/system_clock.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
@@ -42,6 +43,23 @@ TEST(BwuManagerTest, CanInitiateBwu) {
   bwu_manager.Shutdown();
 }
 
+TEST(BwuManagerTest, CanProcessPathAvailableFrame) {
+  ClientProxy client;
+  std::string endpoint_id("EP_A");
+  Mediums mediums;
+  EndpointChannelManager ecm;
+  EndpointManager em{&ecm};
+  BwuManager bwu_manager{mediums, em, ecm, {}, {}};
+
+  LocationHint location_hint = Utils::BuildLocationHint("US");
+  ExceptionOr<OfflineFrame> wrapped_frame = parser::FromBytes(
+      parser::ForBwuWebrtcPathAvailable("my_id", location_hint));
+
+  bwu_manager.OnIncomingFrame(wrapped_frame.result(), endpoint_id, &client,
+                              Medium::WEB_RTC);
+  bwu_manager.Shutdown();
+}
+
 }  // namespace
 }  // namespace connections
 }  // namespace nearby
diff --git a/cpp/platform/base/feature_flags.h b/cpp/platform/base/feature_flags.h
index a6c90dc0..e5b58747 100644
--- a/cpp/platform/base/feature_flags.h
+++ b/cpp/platform/base/feature_flags.h
@@ -21,6 +21,7 @@ class FeatureFlags {
     // Ignore subsequent BWU Available events when we're still processing the
     // first one.
     bool disallow_out_of_order_bwu_avail_event = true;
+    bool enable_async_bandwidth_upgrade = true;
   };
 
   static const FeatureFlags& GetInstance() {