From fa2b5832452a69bb4cf7ceaa259bd557b1da2fcd Mon Sep 17 00:00:00 2001 From: edwinwu Date: Thu, 6 Jan 2022 18:40:18 -0800 Subject: [PATCH] Clean up test for apis added by Analytics. PiperOrigin-RevId: 420187861 --- cpp/core/internal/base_endpoint_channel.cc | 1 - cpp/core/internal/base_pcp_handler.cc | 1 - cpp/core/internal/encryption_runner_test.cc | 4 ---- cpp/core/internal/endpoint_manager_test.cc | 4 ---- 4 files changed, 10 deletions(-) diff --git a/cpp/core/internal/base_endpoint_channel.cc b/cpp/core/internal/base_endpoint_channel.cc index 7d31ef1b..39e0abdf 100644 --- a/cpp/core/internal/base_endpoint_channel.cc +++ b/cpp/core/internal/base_endpoint_channel.cc @@ -24,7 +24,6 @@ #include "platform/public/logging.h" #include "platform/public/mutex.h" #include "platform/public/mutex_lock.h" -#include "proto/connections_enums.pb.h" namespace location { namespace nearby { diff --git a/cpp/core/internal/base_pcp_handler.cc b/cpp/core/internal/base_pcp_handler.cc index f258cd33..db79f07c 100644 --- a/cpp/core/internal/base_pcp_handler.cc +++ b/cpp/core/internal/base_pcp_handler.cc @@ -33,7 +33,6 @@ #include "platform/base/bluetooth_utils.h" #include "platform/public/logging.h" #include "platform/public/system_clock.h" -#include "proto/connections_enums.pb.h" namespace location { namespace nearby { diff --git a/cpp/core/internal/encryption_runner_test.cc b/cpp/core/internal/encryption_runner_test.cc index 3b81e684..7a4f93f4 100644 --- a/cpp/core/internal/encryption_runner_test.cc +++ b/cpp/core/internal/encryption_runner_test.cc @@ -52,18 +52,14 @@ class FakeEndpointChannel : public EndpointChannel { void Close(proto::connections::DisconnectionReason reason) override { Close(); } - // TODO(jfcarroll): This needs to be fixed properly proto::connections::ConnectionTechnology GetTechnology() const override { return proto::connections::ConnectionTechnology:: CONNECTION_TECHNOLOGY_BLE_GATT; } - // TODO(jfcarroll): This needs to be fixed properly proto::connections::ConnectionBand GetBand() const override { return proto::connections::ConnectionBand::CONNECTION_BAND_CELLULAR_BAND_2G; } - // TODO(jfcarroll): This needs to be fixed properly int GetFrequency() const override { return 0; } - // TODO(jfcarroll): This needs to be fixed properly int GetTryCount() const override { return 0; } std::string GetType() const override { return "fake-channel-type"; } std::string GetName() const override { return "fake-channel"; } diff --git a/cpp/core/internal/endpoint_manager_test.cc b/cpp/core/internal/endpoint_manager_test.cc index 0cf79af1..e5b5c152 100644 --- a/cpp/core/internal/endpoint_manager_test.cc +++ b/cpp/core/internal/endpoint_manager_test.cc @@ -53,15 +53,11 @@ class MockEndpointChannel : public EndpointChannel { MOCK_METHOD(Exception, Write, (const ByteArray& data), (override)); MOCK_METHOD(void, Close, (), (override)); MOCK_METHOD(void, Close, (DisconnectionReason reason), (override)); - // TODO(jfcarroll): This needs to be fixed properly MOCK_METHOD(proto::connections::ConnectionTechnology, GetTechnology, (), (const override)); - // TODO(jfcarroll): This needs to be fixed properly MOCK_METHOD(proto::connections::ConnectionBand, GetBand, (), (const override)); - // TODO(jfcarroll): This needs to be fixed properly MOCK_METHOD(int, GetFrequency, (), (const override)); - // TODO(jfcarroll): This needs to be fixed properly MOCK_METHOD(int, GetTryCount, (), (const override)); MOCK_METHOD(std::string, GetType, (), (const override)); MOCK_METHOD(std::string, GetName, (), (const override));