With never versions of libc++, Chromium builds would fail with:
../../third_party/nearby/src/connections/payload.cc:105:50:
error: returning reference to local temporary object [-Werror,-Wreturn-stack-address]
return result ? std::move(*result) : std::move(ByteArray());
^~~~~~~~~~~
Before this libc++ version, the error was masked by the std::move.
If I understand correctly, the only user of this function was
BytesInternalPayload::DetachNextChunk() which was going to make a copy of the
ByteArray annyways, so it might as well use the AsBytes() overload that returns
a const ref.
See also https://crbug.com/1407615#c2
PiperOrigin-RevId: 502946204
*** Reason for rollback ***
Although this fixes Bluetooth Classic, it appears to break Ble, will resubmit once Ble is fixed.
*** Original change description ***
BEGIN_PUBLIC
Bug fixes for 233012255 and 232995024
Refactor bluetooth_adapter setname and getname to remove logic errors, array overruns, and leaking memory.
Refactor bluetooth discovery callbacks to prevent getting updates before we have cached the device found.
Refactor the dart code interfaces to more closely align between the dll and the dart UI, and move from using the device name (which can be easily duplicated) as the primary key to using endpoint_id as the primary key for all calls into...
***
PiperOrigin-RevId: 452177878
Refactor bluetooth_adapter setname and getname to remove logic errors, array overruns, and leaking memory.
Refactor bluetooth discovery callbacks to prevent getting updates before we have cached the device found.
Refactor the dart code interfaces to more closely align between the dll and the dart UI, and move from using the device name (which can be easily duplicated) as the primary key to using endpoint_id as the primary key for all calls into the dll.
PiperOrigin-RevId: 451248048
Francis Tsui