mirror of
https://github.com/kidfromjupiter/nearby.git
synced 2026-09-15 07:06:11 -04:00
Janusz Sobczak
a7a3eb8a92
Previously reading from an empty, closed Pipe returned: * IO exception if there were no writes to the pipe, * Empty byte array if there were writes to the pipe. With this change, we return an empty byte array on both paths. This also fixes a subtle race condition in the following flow: 1. Pipe is empty 2. Thread A is reading from the pipe (blocking call). 3. Thread B writes to the pipe and immediately closes it. 4. Thread A is unblocked and returns IO error. The data written by thread B is ignored! The new test in bluetooth_classic_test triggered that defect consistently. PiperOrigin-RevId: 518107700
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
// Copyright 2020 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "internal/platform/input_stream.h"
|
|
|
|
#include <algorithm>
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
|
|
#include "internal/platform/byte_array.h"
|
|
#include "internal/platform/exception.h"
|
|
|
|
namespace nearby {
|
|
namespace {
|
|
constexpr size_t kSkipBufferSize = 64 * 1024;
|
|
} // namespace
|
|
|
|
ExceptionOr<size_t> InputStream::Skip(size_t offset) {
|
|
size_t bytes_left = offset;
|
|
while (bytes_left > 0) {
|
|
size_t chunk_size = std::min(bytes_left, kSkipBufferSize);
|
|
ExceptionOr<ByteArray> result = Read(chunk_size);
|
|
if (!result.ok()) {
|
|
return result.GetException();
|
|
}
|
|
size_t bytes_read = result.GetResult().size();
|
|
if (bytes_read == 0) {
|
|
return ExceptionOr<size_t>(offset - bytes_left);
|
|
}
|
|
bytes_left -= bytes_read;
|
|
}
|
|
return ExceptionOr<size_t>(offset);
|
|
}
|
|
|
|
} // namespace nearby
|