mirror of
https://github.com/kidfromjupiter/nearby.git
synced 2026-09-14 22:56:12 -04:00
The `RandBytes` functions were being placed in the `crypto` namespace, which collides with Chromium's namespace of the same name. Within, `RandBytes` was defined with almost-the-same API. Then in Chromium builds, the Chromium header would be used instead (though somewhat inconsistently). This creates a lot of pain for Chromium development as there's a third-party repository directly depending on headers from Chromium's source tree, and is against the third-party policies for that reason. There are a number of other headers that mirror Chromium and are swapped out in the Chromium build that will cause similar pain, such as: ``` include "crypto/aead.h" include "crypto/ec_private_key.h" include "crypto/hkdf.h" ``` This CL provides a template for how to get rid of these header swaps and give a platform abstraction in nearby instead. We provide a platform abstraction in `platform/crypto.h` (really in `platform/implementation/crypto.h`) which is implemented in `platform/implementation/shared/crypto.cc`. However that implementation is removed by `#ifdef` when in the Chromium build. Then, in the Chromium repo, we will add (separately) an implementation of the same abstraction in `//third_party/nearby/platform_impl` with GN rules to include it in the build. It will replace the implementation from the nearby repo. Copybara import of the project: -- 6ca8099 by danakj <danakj@chromium.org>: Provide a platform abstraction for RandBytes instead of swapping headers The `RandBytes` functions were being placed in the `crypto` namespace, which collides with Chromium's namespace of the same name. Within, `RandBytes` was defined with almost-the-same API. Then in Chromium builds, the Chromium header would be used instead (though somewhat inconsistently). This creates a lot of pain for Chromium development as there's a third-party repository directly depending on headers from Chromium's source tree, and is against the third-party policies for that reason. There are a number of other headers that mirror Chromium and are swapped out in the Chromium build that will cause similar pain, such as: ``` include "crypto/aead.h" include "crypto/ec_private_key.h" include "crypto/hkdf.h" ``` This CL provides a template for how to get rid of these header swaps and give a platform abstraction in nearby instead. We provide a platform abstraction in `platform/crypto.h` (really in `platform/implementation/crypto.h`) which is implemented in `platform/implementation/shared/crypto.cc`. However that implementation is removed by `#ifdef` when in the Chromium build. Then, in the Chromium repo, we will add (separately) an implementation of the same abstraction in `//third_party/nearby/platform_impl` with GN rules to include it in the build. It will replace the implementation from the nearby repo. -- 9c2654b by danakj <danakj@chromium.org>: Remove CryptoSpan, use absl::Span The header swapping of Chromium crypto libraries is problematic, but absl::Span will convert to base::span so there's no need for the typedef even without removing the header swapping yet. -- df1135d by danakj <danakj@chromium.org>: Add missing files -- ab18a15 by danakj <danakj@chromium.org>: Remove the random_unittest.cc from Swift build The file moved, so the Swift package needs its path updated. -- 2038f78 by danakj <danakj@chromium.org>: Combine crypto unittests into crypto_test.cc -- f7ad176 by danakj <danakj@chromium.org>: Add stdint and stddef includes for uint8_t and size_t -- 9f04590 by danakj <danakj@chromium.org>: Mark the shared crypto implementation compatable_with non_prod -- 18eeafd by danakj <danakj@chromium.org>: Add IWYU pragma for crypto implementation PiperOrigin-RevId: 632150866
127 lines
4.3 KiB
C++
127 lines
4.3 KiB
C++
// Copyright 2022 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "sharing/certificates/common.h"
|
|
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
|
|
#include <limits>
|
|
#include <memory>
|
|
#include <ostream>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "absl/time/time.h"
|
|
#include "absl/types/span.h"
|
|
#include "internal/crypto_cros/encryptor.h"
|
|
#include "internal/crypto_cros/hkdf.h"
|
|
#include "internal/crypto_cros/symmetric_key.h"
|
|
#include "internal/platform/crypto.h"
|
|
#include "sharing/certificates/constants.h"
|
|
#include "sharing/internal/public/logging.h"
|
|
|
|
namespace nearby {
|
|
namespace sharing {
|
|
|
|
bool IsNearbyShareCertificateExpired(absl::Time current_time,
|
|
absl::Time not_after,
|
|
bool use_public_certificate_tolerance) {
|
|
absl::Duration tolerance =
|
|
use_public_certificate_tolerance
|
|
? kNearbySharePublicCertificateValidityBoundOffsetTolerance
|
|
: absl::ZeroDuration();
|
|
|
|
return current_time >= not_after + tolerance;
|
|
}
|
|
|
|
bool IsNearbyShareCertificateWithinValidityPeriod(
|
|
absl::Time current_time, absl::Time not_before, absl::Time not_after,
|
|
bool use_public_certificate_tolerance) {
|
|
absl::Duration tolerance =
|
|
use_public_certificate_tolerance
|
|
? kNearbySharePublicCertificateValidityBoundOffsetTolerance
|
|
: absl::ZeroDuration();
|
|
|
|
return current_time >= not_before - tolerance &&
|
|
!IsNearbyShareCertificateExpired(current_time, not_after,
|
|
use_public_certificate_tolerance);
|
|
}
|
|
|
|
std::vector<uint8_t> DeriveNearbyShareKey(absl::Span<const uint8_t> key,
|
|
size_t new_num_bytes) {
|
|
return crypto::HkdfSha256(key,
|
|
/*salt=*/absl::Span<const uint8_t>(),
|
|
/*info=*/absl::Span<const uint8_t>(),
|
|
new_num_bytes);
|
|
}
|
|
|
|
std::vector<uint8_t> ComputeAuthenticationTokenHash(
|
|
absl::Span<const uint8_t> authentication_token,
|
|
absl::Span<const uint8_t> secret_key) {
|
|
return crypto::HkdfSha256(authentication_token, secret_key,
|
|
/*info=*/absl::Span<const uint8_t>(),
|
|
kNearbyShareNumBytesAuthenticationTokenHash);
|
|
}
|
|
|
|
std::vector<uint8_t> GenerateRandomBytes(size_t num_bytes) {
|
|
std::vector<uint8_t> bytes(num_bytes);
|
|
RandBytes(absl::Span<uint8_t>(bytes));
|
|
return bytes;
|
|
}
|
|
|
|
std::unique_ptr<crypto::Encryptor> CreateNearbyShareCtrEncryptor(
|
|
const crypto::SymmetricKey* secret_key, absl::Span<const uint8_t> salt) {
|
|
NL_DCHECK(secret_key);
|
|
NL_DCHECK_EQ(kNearbyShareNumBytesSecretKey, secret_key->key().size());
|
|
NL_DCHECK_EQ(kNearbyShareNumBytesMetadataEncryptionKeySalt, salt.size());
|
|
|
|
auto encryptor = std::make_unique<crypto::Encryptor>();
|
|
|
|
// For CTR mode, the iv input to Init() must be empty. Instead, the iv is
|
|
// set via SetCounter().
|
|
if (!encryptor->Init(secret_key, crypto::Encryptor::Mode::CTR,
|
|
/*iv=*/absl::Span<const uint8_t>())) {
|
|
NL_LOG(ERROR) << "Encryptor could not be initialized.";
|
|
return nullptr;
|
|
}
|
|
|
|
std::vector<uint8_t> iv =
|
|
DeriveNearbyShareKey(salt, kNearbyShareNumBytesAesCtrIv);
|
|
if (!encryptor->SetCounter(iv)) {
|
|
NL_LOG(ERROR) << "Could not set encryptor counter.";
|
|
return nullptr;
|
|
}
|
|
|
|
return encryptor;
|
|
}
|
|
|
|
absl::Time FromJavaTime(int64_t ms_since_epoch) {
|
|
return absl::UnixEpoch() + absl::Milliseconds(ms_since_epoch);
|
|
}
|
|
|
|
int64_t ToJavaTime(absl::Time time) {
|
|
// Preserve 0 so the invalid result doesn't depend on the platform.
|
|
if (time == absl::InfiniteFuture()) {
|
|
return std::numeric_limits<int64_t>::max();
|
|
} else if (time == absl::InfinitePast()) {
|
|
return std::numeric_limits<int64_t>::min();
|
|
} else {
|
|
return (time - absl::UnixEpoch()) / absl::Milliseconds(1);
|
|
}
|
|
}
|
|
|
|
} // namespace sharing
|
|
} // namespace nearby
|