mirror of
https://github.com/kidfromjupiter/nearby.git
synced 2026-09-15 15:16:12 -04:00
nohle
f483110a8d
We refactor the `Core`/`ServiceControllerRouter`/`ServiceController` classes to better align with the GmsCore implementation. Notably, 1. `Core` instances share the same `ServiceControllerRouter`. 2. `ServiceControllerRouter` directly owns one `OfflineServiceController`--that is created lazily and destroyed when when the router is destroyed--instead of using a factory method to create `ServiceController`s. 3. Removes obsolete "strategy" logic from `ServiceControllerRouter`, which used to recreate service controllers if the "strategy" changed. 4. Removes `ServiceControllerRouter::ClientDisconnecting()`, which is identical to `StopAllEndpoints()`. 5. Makes various C++ style clean-ups like removing unnecessary static variables/functions. See analogous Chrome OS changes at http://crrev.com/c/3025604. PiperOrigin-RevId: 389188124
53 lines
1.5 KiB
C++
53 lines
1.5 KiB
C++
// Copyright 2020 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "core/core.h"
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
#include "absl/time/clock.h"
|
|
#include "core/internal/mock_service_controller_router.h"
|
|
#include "platform/public/logging.h"
|
|
|
|
namespace location {
|
|
namespace nearby {
|
|
namespace connections {
|
|
namespace {
|
|
|
|
TEST(CoreTest, ConstructorDestructorWorks) {
|
|
MockServiceControllerRouter mock;
|
|
// Called when Core is destroyed.
|
|
EXPECT_CALL(mock, StopAllEndpoints)
|
|
.WillOnce([&](ClientProxy* client, const ResultCallback& callback) {
|
|
callback.result_cb({Status::kSuccess});
|
|
});
|
|
Core core{&mock};
|
|
}
|
|
|
|
TEST(CoreTest, DestructorReportsFatalFailure) {
|
|
ASSERT_DEATH(
|
|
{
|
|
MockServiceControllerRouter mock;
|
|
// Never invoke the result callback so ~Core will time out.
|
|
EXPECT_CALL(mock, StopAllEndpoints);
|
|
Core core{&mock};
|
|
},
|
|
"Unable to shutdown");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace connections
|
|
} // namespace nearby
|
|
} // namespace location
|