Update README.md

Removed link to the deprecated owlink website as it's no longer associated with this project.
Update setup.py
2026-09-14 23:26:11 -04:00 · 2026-08-17 14:18:16 +02:00 · 2026-08-17 14:16:23 +02:00 · 2024-06-11 12:41:13 +02:00 · 2021-04-29 14:59:52 +02:00 · 2021-04-29 14:55:39 +02:00
20 changed files with 724 additions and 3101 deletions
@@ -1,11 +1,11 @@
 name: Create GitHub release
 on:
  push:
    # Sequence of patterns matched against refs/tags
    tags:
      - 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10
 name: Create Release
 jobs:
  build:
    name: Create Release
@@ -1,4 +1,4 @@
-name: Upload Python Package
+name: Publish at pypi.org
 on:
  release:
@@ -1,4 +1,4 @@
-name: Upload Python Test Package
+name: Publish at test.pypi.org
 on:
  release:
@@ -0,0 +1,44 @@
 name: Test package
 on: [push, pull_request]
 jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        python-version: [3.6, 3.7, 3.8, 3.9]
    steps:
    - uses: actions/checkout@v1
    - name: Set up Python ${{ matrix.python-version }}
      uses: actions/setup-python@v1
      with:
        python-version: ${{ matrix.python-version }}
    - name: Install dependencies
      run: |
        python -m pip install --upgrade pip
    - name: Install package
      run: |
        pip install -e .
    - name: Check format with isort
      run: |
        pip install isort
        isort -c opendrop/**.py
    - name: Check format with black
      run: |
        pip install black
        black . --check --diff
    - name: Lint with flake8
      run: |
        pip install flake8
        flake8 . --count --show-source --statistics
    - name: Lint with pylint
      run: |
        pip install pylint
        pylint --rcfile=setup.cfg opendrop
    - name: Test with pytest
      run: |
        pip install pytest
        pytest
@@ -0,0 +1,31 @@
 # This CITATION.cff file was generated with cffinit.
 # Visit https://bit.ly/cffinit to generate yours today!
 cff-version: 1.2.0
 title: 'OpenDrop: an Open Source AirDrop Implementation'
 message: 'If you use this software, please cite it as below.'
 type: software
 authors:
  - given-names: Alexander
    family-names: Heinrich
    affiliation: 'SEEMOO, TU Darmstadt'
    orcid: 'https://orcid.org/0000-0002-1150-1922'
  - given-names: Milan
    family-names: Stute
    affiliation: 'SEEMOO, TU Darmstadt'
    orcid: 'https://orcid.org/0000-0003-4921-8476'
  - given-names: Matthias
    family-names: Hollick
    affiliation: 'SEEMOO, TU Darmstadt'
    orcid: 'https://orcid.org/0000-0002-9163-5989'
 repository-code: 'https://github.com/seemoo-lab/opendrop'
 abstract: >-
  OpenDrop is a command-line tool that allows sharing files
  between devices directly over Wi-Fi. Its unique feature is
  that it is protocol-compatible with Apple AirDrop which
  allows to share files with Apple devices running iOS and
  macOS.
 license: GPL-3.0
 commit: cbc7ca46a75bb2da4af9d406732ddf2192578388
 version: '0.13'
 date-released: '2021-04-29'
@@ -619,464 +619,3 @@ Program, unless a warranty or assumption of liability accompanies a
 copy of the Program in return for a fee.
                     END OF TERMS AND CONDITIONS
                  GNU LESSER GENERAL PUBLIC LICENSE
                       Version 2.1, February 1999
 Copyright (C) 1991, 1999 Free Software Foundation, Inc.
 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 Everyone is permitted to copy and distribute verbatim copies
 of this license document, but changing it is not allowed.
 [This is the first released version of the Lesser GPL.  It also counts
 as the successor of the GNU Library Public License, version 2, hence
 the version number 2.1.]
                            Preamble
  The licenses for most software are designed to take away your
 freedom to share and change it.  By contrast, the GNU General Public
 Licenses are intended to guarantee your freedom to share and change
 free software--to make sure the software is free for all its users.
  This license, the Lesser General Public License, applies to some
 specially designated software packages--typically libraries--of the
 Free Software Foundation and other authors who decide to use it.  You
 can use it too, but we suggest you first think carefully about whether
 this license or the ordinary General Public License is the better
 strategy to use in any particular case, based on the explanations below.
  When we speak of free software, we are referring to freedom of use,
 not price.  Our General Public Licenses are designed to make sure that
 you have the freedom to distribute copies of free software (and charge
 for this service if you wish); that you receive source code or can get
 it if you want it; that you can change the software and use pieces of
 it in new free programs; and that you are informed that you can do
 these things.
  To protect your rights, we need to make restrictions that forbid
 distributors to deny you these rights or to ask you to surrender these
 rights.  These restrictions translate to certain responsibilities for
 you if you distribute copies of the library or if you modify it.
  For example, if you distribute copies of the library, whether gratis
 or for a fee, you must give the recipients all the rights that we gave
 you.  You must make sure that they, too, receive or can get the source
 code.  If you link other code with the library, you must provide
 complete object files to the recipients, so that they can relink them
 with the library after making changes to the library and recompiling
 it.  And you must show them these terms so they know their rights.
  We protect your rights with a two-step method: (1) we copyright the
 library, and (2) we offer you this license, which gives you legal
 permission to copy, distribute and/or modify the library.
  To protect each distributor, we want to make it very clear that
 there is no warranty for the free library.  Also, if the library is
 modified by someone else and passed on, the recipients should know
 that what they have is not the original version, so that the original
 author's reputation will not be affected by problems that might be
 introduced by others.
  Finally, software patents pose a constant threat to the existence of
 any free program.  We wish to make sure that a company cannot
 effectively restrict the users of a free program by obtaining a
 restrictive license from a patent holder.  Therefore, we insist that
 any patent license obtained for a version of the library must be
 consistent with the full freedom of use specified in this license.
  Most GNU software, including some libraries, is covered by the
 ordinary GNU General Public License.  This license, the GNU Lesser
 General Public License, applies to certain designated libraries, and
 is quite different from the ordinary General Public License.  We use
 this license for certain libraries in order to permit linking those
 libraries into non-free programs.
  When a program is linked with a library, whether statically or using
 a shared library, the combination of the two is legally speaking a
 combined work, a derivative of the original library.  The ordinary
 General Public License therefore permits such linking only if the
 entire combination fits its criteria of freedom.  The Lesser General
 Public License permits more lax criteria for linking other code with
 the library.
  We call this license the "Lesser" General Public License because it
 does Less to protect the user's freedom than the ordinary General
 Public License.  It also provides other free software developers Less
 of an advantage over competing non-free programs.  These disadvantages
 are the reason we use the ordinary General Public License for many
 libraries.  However, the Lesser license provides advantages in certain
 special circumstances.
  For example, on rare occasions, there may be a special need to
 encourage the widest possible use of a certain library, so that it becomes
 a de-facto standard.  To achieve this, non-free programs must be
 allowed to use the library.  A more frequent case is that a free
 library does the same job as widely used non-free libraries.  In this
 case, there is little to gain by limiting the free library to free
 software only, so we use the Lesser General Public License.
  In other cases, permission to use a particular library in non-free
 programs enables a greater number of people to use a large body of
 free software.  For example, permission to use the GNU C Library in
 non-free programs enables many more people to use the whole GNU
 operating system, as well as its variant, the GNU/Linux operating
 system.
  Although the Lesser General Public License is Less protective of the
 users' freedom, it does ensure that the user of a program that is
 linked with the Library has the freedom and the wherewithal to run
 that program using a modified version of the Library.
  The precise terms and conditions for copying, distribution and
 modification follow.  Pay close attention to the difference between a
 "work based on the library" and a "work that uses the library".  The
 former contains code derived from the library, whereas the latter must
 be combined with the library in order to run.
                  GNU LESSER GENERAL PUBLIC LICENSE
   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
  0. This License Agreement applies to any software library or other
 program which contains a notice placed by the copyright holder or
 other authorized party saying it may be distributed under the terms of
 this Lesser General Public License (also called "this License").
 Each licensee is addressed as "you".
  A "library" means a collection of software functions and/or data
 prepared so as to be conveniently linked with application programs
 (which use some of those functions and data) to form executables.
  The "Library", below, refers to any such software library or work
 which has been distributed under these terms.  A "work based on the
 Library" means either the Library or any derivative work under
 copyright law: that is to say, a work containing the Library or a
 portion of it, either verbatim or with modifications and/or translated
 straightforwardly into another language.  (Hereinafter, translation is
 included without limitation in the term "modification".)
  "Source code" for a work means the preferred form of the work for
 making modifications to it.  For a library, complete source code means
 all the source code for all modules it contains, plus any associated
 interface definition files, plus the scripts used to control compilation
 and installation of the library.
  Activities other than copying, distribution and modification are not
 covered by this License; they are outside its scope.  The act of
 running a program using the Library is not restricted, and output from
 such a program is covered only if its contents constitute a work based
 on the Library (independent of the use of the Library in a tool for
 writing it).  Whether that is true depends on what the Library does
 and what the program that uses the Library does.
  1. You may copy and distribute verbatim copies of the Library's
 complete source code as you receive it, in any medium, provided that
 you conspicuously and appropriately publish on each copy an
 appropriate copyright notice and disclaimer of warranty; keep intact
 all the notices that refer to this License and to the absence of any
 warranty; and distribute a copy of this License along with the
 Library.
  You may charge a fee for the physical act of transferring a copy,
 and you may at your option offer warranty protection in exchange for a
 fee.
  2. You may modify your copy or copies of the Library or any portion
 of it, thus forming a work based on the Library, and copy and
 distribute such modifications or work under the terms of Section 1
 above, provided that you also meet all of these conditions:
    a) The modified work must itself be a software library.
    b) You must cause the files modified to carry prominent notices
    stating that you changed the files and the date of any change.
    c) You must cause the whole of the work to be licensed at no
    charge to all third parties under the terms of this License.
    d) If a facility in the modified Library refers to a function or a
    table of data to be supplied by an application program that uses
    the facility, other than as an argument passed when the facility
    is invoked, then you must make a good faith effort to ensure that,
    in the event an application does not supply such function or
    table, the facility still operates, and performs whatever part of
    its purpose remains meaningful.
    (For example, a function in a library to compute square roots has
    a purpose that is entirely well-defined independent of the
    application.  Therefore, Subsection 2d requires that any
    application-supplied function or table used by this function must
    be optional: if the application does not supply it, the square
    root function must still compute square roots.)
 These requirements apply to the modified work as a whole.  If
 identifiable sections of that work are not derived from the Library,
 and can be reasonably considered independent and separate works in
 themselves, then this License, and its terms, do not apply to those
 sections when you distribute them as separate works.  But when you
 distribute the same sections as part of a whole which is a work based
 on the Library, the distribution of the whole must be on the terms of
 this License, whose permissions for other licensees extend to the
 entire whole, and thus to each and every part regardless of who wrote
 it.
 Thus, it is not the intent of this section to claim rights or contest
 your rights to work written entirely by you; rather, the intent is to
 exercise the right to control the distribution of derivative or
 collective works based on the Library.
 In addition, mere aggregation of another work not based on the Library
 with the Library (or with a work based on the Library) on a volume of
 a storage or distribution medium does not bring the other work under
 the scope of this License.
  3. You may opt to apply the terms of the ordinary GNU General Public
 License instead of this License to a given copy of the Library.  To do
 this, you must alter all the notices that refer to this License, so
 that they refer to the ordinary GNU General Public License, version 2,
 instead of to this License.  (If a newer version than version 2 of the
 ordinary GNU General Public License has appeared, then you can specify
 that version instead if you wish.)  Do not make any other change in
 these notices.
  Once this change is made in a given copy, it is irreversible for
 that copy, so the ordinary GNU General Public License applies to all
 subsequent copies and derivative works made from that copy.
  This option is useful when you wish to copy part of the code of
 the Library into a program that is not a library.
  4. You may copy and distribute the Library (or a portion or
 derivative of it, under Section 2) in object code or executable form
 under the terms of Sections 1 and 2 above provided that you accompany
 it with the complete corresponding machine-readable source code, which
 must be distributed under the terms of Sections 1 and 2 above on a
 medium customarily used for software interchange.
  If distribution of object code is made by offering access to copy
 from a designated place, then offering equivalent access to copy the
 source code from the same place satisfies the requirement to
 distribute the source code, even though third parties are not
 compelled to copy the source along with the object code.
  5. A program that contains no derivative of any portion of the
 Library, but is designed to work with the Library by being compiled or
 linked with it, is called a "work that uses the Library".  Such a
 work, in isolation, is not a derivative work of the Library, and
 therefore falls outside the scope of this License.
  However, linking a "work that uses the Library" with the Library
 creates an executable that is a derivative of the Library (because it
 contains portions of the Library), rather than a "work that uses the
 library".  The executable is therefore covered by this License.
 Section 6 states terms for distribution of such executables.
  When a "work that uses the Library" uses material from a header file
 that is part of the Library, the object code for the work may be a
 derivative work of the Library even though the source code is not.
 Whether this is true is especially significant if the work can be
 linked without the Library, or if the work is itself a library.  The
 threshold for this to be true is not precisely defined by law.
  If such an object file uses only numerical parameters, data
 structure layouts and accessors, and small macros and small inline
 functions (ten lines or less in length), then the use of the object
 file is unrestricted, regardless of whether it is legally a derivative
 work.  (Executables containing this object code plus portions of the
 Library will still fall under Section 6.)
  Otherwise, if the work is a derivative of the Library, you may
 distribute the object code for the work under the terms of Section 6.
 Any executables containing that work also fall under Section 6,
 whether or not they are linked directly with the Library itself.
  6. As an exception to the Sections above, you may also combine or
 link a "work that uses the Library" with the Library to produce a
 work containing portions of the Library, and distribute that work
 under terms of your choice, provided that the terms permit
 modification of the work for the customer's own use and reverse
 engineering for debugging such modifications.
  You must give prominent notice with each copy of the work that the
 Library is used in it and that the Library and its use are covered by
 this License.  You must supply a copy of this License.  If the work
 during execution displays copyright notices, you must include the
 copyright notice for the Library among them, as well as a reference
 directing the user to the copy of this License.  Also, you must do one
 of these things:
    a) Accompany the work with the complete corresponding
    machine-readable source code for the Library including whatever
    changes were used in the work (which must be distributed under
    Sections 1 and 2 above); and, if the work is an executable linked
    with the Library, with the complete machine-readable "work that
    uses the Library", as object code and/or source code, so that the
    user can modify the Library and then relink to produce a modified
    executable containing the modified Library.  (It is understood
    that the user who changes the contents of definitions files in the
    Library will not necessarily be able to recompile the application
    to use the modified definitions.)
    b) Use a suitable shared library mechanism for linking with the
    Library.  A suitable mechanism is one that (1) uses at run time a
    copy of the library already present on the user's computer system,
    rather than copying library functions into the executable, and (2)
    will operate properly with a modified version of the library, if
    the user installs one, as long as the modified version is
    interface-compatible with the version that the work was made with.
    c) Accompany the work with a written offer, valid for at
    least three years, to give the same user the materials
    specified in Subsection 6a, above, for a charge no more
    than the cost of performing this distribution.
    d) If distribution of the work is made by offering access to copy
    from a designated place, offer equivalent access to copy the above
    specified materials from the same place.
    e) Verify that the user has already received a copy of these
    materials or that you have already sent this user a copy.
  For an executable, the required form of the "work that uses the
 Library" must include any data and utility programs needed for
 reproducing the executable from it.  However, as a special exception,
 the materials to be distributed need not include anything that is
 normally distributed (in either source or binary form) with the major
 components (compiler, kernel, and so on) of the operating system on
 which the executable runs, unless that component itself accompanies
 the executable.
  It may happen that this requirement contradicts the license
 restrictions of other proprietary libraries that do not normally
 accompany the operating system.  Such a contradiction means you cannot
 use both them and the Library together in an executable that you
 distribute.
  7. You may place library facilities that are a work based on the
 Library side-by-side in a single library together with other library
 facilities not covered by this License, and distribute such a combined
 library, provided that the separate distribution of the work based on
 the Library and of the other library facilities is otherwise
 permitted, and provided that you do these two things:
    a) Accompany the combined library with a copy of the same work
    based on the Library, uncombined with any other library
    facilities.  This must be distributed under the terms of the
    Sections above.
    b) Give prominent notice with the combined library of the fact
    that part of it is a work based on the Library, and explaining
    where to find the accompanying uncombined form of the same work.
  8. You may not copy, modify, sublicense, link with, or distribute
 the Library except as expressly provided under this License.  Any
 attempt otherwise to copy, modify, sublicense, link with, or
 distribute the Library is void, and will automatically terminate your
 rights under this License.  However, parties who have received copies,
 or rights, from you under this License will not have their licenses
 terminated so long as such parties remain in full compliance.
  9. You are not required to accept this License, since you have not
 signed it.  However, nothing else grants you permission to modify or
 distribute the Library or its derivative works.  These actions are
 prohibited by law if you do not accept this License.  Therefore, by
 modifying or distributing the Library (or any work based on the
 Library), you indicate your acceptance of this License to do so, and
 all its terms and conditions for copying, distributing or modifying
 the Library or works based on it.
  10. Each time you redistribute the Library (or any work based on the
 Library), the recipient automatically receives a license from the
 original licensor to copy, distribute, link with or modify the Library
 subject to these terms and conditions.  You may not impose any further
 restrictions on the recipients' exercise of the rights granted herein.
 You are not responsible for enforcing compliance by third parties with
 this License.
  11. If, as a consequence of a court judgment or allegation of patent
 infringement or for any other reason (not limited to patent issues),
 conditions are imposed on you (whether by court order, agreement or
 otherwise) that contradict the conditions of this License, they do not
 excuse you from the conditions of this License.  If you cannot
 distribute so as to satisfy simultaneously your obligations under this
 License and any other pertinent obligations, then as a consequence you
 may not distribute the Library at all.  For example, if a patent
 license would not permit royalty-free redistribution of the Library by
 all those who receive copies directly or indirectly through you, then
 the only way you could satisfy both it and this License would be to
 refrain entirely from distribution of the Library.
 If any portion of this section is held invalid or unenforceable under any
 particular circumstance, the balance of the section is intended to apply,
 and the section as a whole is intended to apply in other circumstances.
 It is not the purpose of this section to induce you to infringe any
 patents or other property right claims or to contest validity of any
 such claims; this section has the sole purpose of protecting the
 integrity of the free software distribution system which is
 implemented by public license practices.  Many people have made
 generous contributions to the wide range of software distributed
 through that system in reliance on consistent application of that
 system; it is up to the author/donor to decide if he or she is willing
 to distribute software through any other system and a licensee cannot
 impose that choice.
 This section is intended to make thoroughly clear what is believed to
 be a consequence of the rest of this License.
  12. If the distribution and/or use of the Library is restricted in
 certain countries either by patents or by copyrighted interfaces, the
 original copyright holder who places the Library under this License may add
 an explicit geographical distribution limitation excluding those countries,
 so that distribution is permitted only in or among countries not thus
 excluded.  In such case, this License incorporates the limitation as if
 written in the body of this License.
  13. The Free Software Foundation may publish revised and/or new
 versions of the Lesser General Public License from time to time.
 Such new versions will be similar in spirit to the present version,
 but may differ in detail to address new problems or concerns.
 Each version is given a distinguishing version number.  If the Library
 specifies a version number of this License which applies to it and
 "any later version", you have the option of following the terms and
 conditions either of that version or of any later version published by
 the Free Software Foundation.  If the Library does not specify a
 license version number, you may choose any version ever published by
 the Free Software Foundation.
  14. If you wish to incorporate parts of the Library into other free
 programs whose distribution conditions are incompatible with these,
 write to the author to ask for permission.  For software which is
 copyrighted by the Free Software Foundation, write to the Free
 Software Foundation; we sometimes make exceptions for this.  Our
 decision will be guided by the two goals of preserving the free status
 of all derivatives of our free software and of promoting the sharing
 and reuse of software generally.
                            NO WARRANTY
  15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO
 WARRANTY FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW.
 EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR
 OTHER PARTIES PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY
 KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE
 IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE
 LIBRARY IS WITH YOU.  SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME
 THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
  16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN
 WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY
 AND/OR REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU
 FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR
 CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE
 LIBRARY (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING
 RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A
 FAILURE OF THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF
 SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH
 DAMAGES.
                     END OF TERMS AND CONDITIONS
@@ -0,0 +1,37 @@
 .PHONY: ci checkformat isort lint pylint test autoformat
 VENV=venv
 PYTHON=$(VENV)/bin/python3
 ci: isort checkformat lint pylint test
 $(VENV): $(VENV)/bin/activate
 $(VENV)/bin/activate: setup.py requirements-dev.txt Makefile
 ifeq (, $(shell which virtualenv))
 	$(error "`virtualenv` is not installed, consider running `pip3 install virtualenv`")
 endif
 	test -d $(VENV) || virtualenv -p python3 $(VENV)
 	$(PYTHON) -m pip install --upgrade pip
 	$(PYTHON) -m pip install -r requirements-dev.txt
 	$(PYTHON) -m pip install -e .
 	touch $(VENV)/bin/activate
 checkformat: $(VENV)
 	$(PYTHON) -m black . --check --diff --exclude $(VENV)
 lint: $(VENV)	
 	$(PYTHON) -m flake8 . --count --show-source --statistics --exclude $(VENV)
 pylint: $(VENV)
 	$(PYTHON) -m pylint --rcfile=setup.cfg opendrop
 isort: $(VENV)
 	$(PYTHON) -m isort -c opendrop/**.py
 test: $(VENV)
 	$(PYTHON) -m pytest
 autoformat: $(VENV)
 	$(PYTHON) -m isort opendrop/**.py
 	$(PYTHON) -m black . --exclude $(VENV)
@@ -1,12 +1,15 @@
 # OpenDrop: an Open Source AirDrop Implementation
-*OpenDrop* is a command-line tool that allows sharing files between devices directly over Wi-Fi. Its unique feature is that it is protocol-compatible with Apple AirDrop which allows to share files with Apple devices running iOS and macOS. 
+[![Release](https://img.shields.io/pypi/v/opendrop?color=%23EC6500&label=release)](https://pypi.org/project/opendrop/)
-Currently (and probably also for the foreseeable future), OpenDrop only supports sending to Apple devices that are discoverable by *everybody* as the default *contacts only* mode requires [Apple-signed certificates](https://www.apple.com/certificateauthority/pdf/Apple_AAI_CPS_v6.1.pdf).
+[![Language grade](https://img.shields.io/lgtm/grade/python/github/seemoo-lab/opendrop?label=code%20quality)](https://lgtm.com/projects/g/seemoo-lab/opendrop/context:python)
 *OpenDrop* is a command-line tool that allows sharing files between devices directly over Wi-Fi. Its unique feature is that it is protocol-compatible with Apple AirDrop which allows to share files with Apple devices running iOS and macOS. 
 ~~Currently (and probably also for the foreseeable future), OpenDrop only supports sending to Apple devices that are discoverable by *everybody* as the default *contacts only* mode requires [Apple-signed certificates](https://www.apple.com/certificateauthority/pdf/Apple_AAI_CPS_v6.1.pdf).~~
 We support contacts-only devices by using extracted AirDrop credentials (keys and certificates) from macOS via our [keychain extractor](https://github.com/seemoo-lab/airdrop-keychain-extractor).
 ## Disclaimer
-OpenDrop is experimental software and is the result of reverse engineering efforts by the [Open Wireless Link](https://owlink.org) project.
+OpenDrop is experimental software and is the result of reverse engineering efforts by the [Open Wireless Link](<<DISCLAIMER: The former owlink website is no longer associated with this project, please disregard it.>>) project.
 Therefore, it does not support all features of AirDrop or might be incompatible with future AirDrop versions.
 OpenDrop is not affiliated with or endorsed by Apple Inc. Use this code at your own risk.
@@ -20,19 +23,19 @@ In addition, it requires Python >=3.6 as well as several libraries.
 As AirDrop exclusively runs over Apple Wireless Direct Link (AWDL), OpenDrop is only supported on macOS or on Linux systems running an open re-implementation of AWDL such as [OWL](https://github.com/seemoo-lab/owl).
 **Libraries.**
-OpenDrop relies on current versions of [OpenSSL](https://www.openssl.org) and [libarchive](https://www.libarchive.org).
+OpenDrop relies on a current version of [libarchive](https://www.libarchive.org).
-macOS ships with rather old versions of the two, so you will need to install newer version, for example, via [Homebrew](https://brew.sh):
+macOS ships with a rather old version, so you will need to install a newer version, for example, via [Homebrew](https://brew.sh):
 ```bash
-brew install libarchive openssl
+brew install libarchive
 ```
-OpenDrop automatically sets `DYLD_LIBRARY_PATH` to look for the Homebrew versions. You may need to update the variable yourself if you install the libraries differently.
+OpenDrop automatically sets `DYLD_LIBRARY_PATH` to look for the Homebrew version. You may need to update the variable yourself if you install the libraries differently.
 Linux distributions should ship with more up-to-date versions, so this won't be necessary.
 ## Installation 
-Installation of the Python package [release](https://pypi.org/project/opendrop/) is straight forward using `pip3`:
+Installation of the Python package [release](https://pypi.org/project/opendrop/) is straightforward using `pip3`:
 ```
 pip3 install opendrop
 ```
@@ -49,17 +52,17 @@ pip3 install ./opendrop
 We briefly explain how to send and receive files using `opendrop`.
 To see all command line options, run `opendrop -h`.
-### Sending a File
+### Sending a File or a Link
 Sending a file is typically a two-step procedure. You first discover devices in proximity using the `find` command.
 Stop the process once you have found the receiver.
 ```
 $ opendrop find
-Looking for receivers. Press enter to stop ...
+Looking for receivers. Press Ctrl+C to stop ...
 Found  index 0  ID eccb2f2dcfe7  name John’s iPhone
 Found  index 1  ID e63138ac6ba8  name Jane’s MacBook Pro
 ```
-You can then `send` a file using 
+You can then `send` a file (or link, see below) using 
 ```
 $ opendrop send -r 0 -f /path/to/some/file
 Asking receiver to accept ...
@@ -70,6 +73,13 @@ Uploading has been successful
 Instead of the `index`, you can also use `ID` or `name`.
 OpenDrop will try to interpret the input in the order (1) `index`, (2) `ID`, and (3) `name` and fail if no match was found.
 **Sending a web link.** Since v0.13, OpenDrop supports sending web links, i.e., URLs, so that receiving Apple devices will immediately open their browser upon accepting. 
 (Note that OpenDrop _receivers_ still only support receiving regular files.)
 ```
 $ opendrop send -r 0 -f <<DISCLAIMER: The former owlink website is no longer associated with this project, please disregard it.>> --url
 ```
 ### Receiving Files
 Receiving is much easier. Simply use the `receive` command. OpenDrop will accept all incoming files automatically and put received files in the current directory.
@@ -89,9 +99,10 @@ OpenDrop is the result of a research project and, thus, has several limitations
 * *Sending multiple files.* Apple AirDrop supports sending multiple files at once, OpenDrop does not (would require adding more files to the archive, modify HTTP /Ask request, etc.).
-## Related Papers
+## Our Papers
-* Milan Stute, Sashank Narain, Alex Mariotto, Alexander Heinrich, David Kreitschmann, Guevara Noubir, and Matthias Hollick. **A Billion Open Interfaces for Eve and Mallory: MitM, DoS, and Tracking Attacks on iOS and macOS Through Apple Wireless Direct Link.** *28th USENIX Security Symposium (USENIX Security ’19)*, August 14–16, 2019, Santa Clara, CA, USA. [Link](https://www.usenix.org/conference/usenixsecurity19/presentation/stute)
+* Alexander Heinrich, Matthias Hollick, Thomas Schneider, Milan Stute, and Christian Weinert. **PrivateDrop: Practical Privacy-Preserving Authentication for Apple AirDrop.** *30th USENIX Security Symposium (USENIX Security ’21)*, August 14–16, 2019, virtual Event. [Paper](https://www.usenix.org/conference/usenixsecurity21/presentation/heinrich) [Website](https://privatedrop.github.io) [Code](https://github.com/seemoo-lab/privatedrop)
 * Milan Stute, Sashank Narain, Alex Mariotto, Alexander Heinrich, David Kreitschmann, Guevara Noubir, and Matthias Hollick. **A Billion Open Interfaces for Eve and Mallory: MitM, DoS, and Tracking Attacks on iOS and macOS Through Apple Wireless Direct Link.** *28th USENIX Security Symposium (USENIX Security ’19)*, August 14–16, 2019, Santa Clara, CA, USA. [Paper](https://www.usenix.org/conference/usenixsecurity19/presentation/stute)
 ## Authors
@@ -102,6 +113,4 @@ OpenDrop is the result of a research project and, thus, has several limitations
 ## License
-OpenDrop is licensed under the **GNU General Public License v3.0**.
+OpenDrop is licensed under the [**GNU General Public License v3.0**](LICENSE).
 We use a modified version of the [`python-zeroconf`](https://pypi.org/project/zeroconf/) package (essentially adding rudimentary IPv6 and AWDL support) which is licensed under the **GNU Lesser General Public License v2.1**.
 Both licenses are found in the `LICENSE` file.
@@ -18,15 +18,14 @@ along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
 import logging
 import platform
 import os
 import platform
-__version__ = '0.10.3'
+__version__ = "0.13.0"
-if platform.system() == 'Darwin':
+if platform.system() == "Darwin":
-	dyld_path = os.environ.get('DYLD_LIBRARY_PATH', '')  # save old path
+    dyld_path = os.environ.get("DYLD_LIBRARY_PATH", "")  # save old path
-	openssl_path = '/usr/local/opt/openssl/lib'
+    archive_path = "/usr/local/opt/libarchive/lib"
-	archive_path = '/usr/local/opt/libarchive/lib'
+    os.environ["DYLD_LIBRARY_PATH"] = f"{dyld_path}:{archive_path}"
 	os.environ['DYLD_LIBRARY_PATH'] = '{}:{}:{}'.format(dyld_path, openssl_path, archive_path)
 logger = logging.getLogger(__name__)
@@ -17,15 +17,13 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
 import time
 import ipaddress
 import logging
 import argparse
 import sys
 import json
 import logging
 import os
 import sys
 import threading
 import time
 from .client import AirDropBrowser, AirDropClient
 from .config import AirDropConfig, AirDropReceiverFlags
@@ -39,30 +37,56 @@ def main():
 class AirDropCli:
    def __init__(self, args):
        parser = argparse.ArgumentParser()
-        parser.add_argument('action', choices=['receive', 'find', 'send'])
+        parser.add_argument("action", choices=["receive", "find", "send"])
-        parser.add_argument('-f', '--file', help='File to be sent')
+        parser.add_argument("-f", "--file", help="File to be sent")
-        parser.add_argument('-r', '--receiver', help='Peer to send file to (can be index, ID, or hostname)')
+        parser.add_argument(
-        parser.add_argument('-e', '--email', nargs='*', help='User\'s email addresses (currently unused)')
+            "-u", "--url", help="'-f,--file is a URL", action="store_true"
-        parser.add_argument('-p', '--phone', nargs='*', help='User\'s phone numbers (currently unused)')
+        )
-        parser.add_argument('-n', '--name', help='Computer name (displayed in sharing pane)')
+        parser.add_argument(
-        parser.add_argument('-m', '--model', help='Computer model (displayed in sharing pane)')
+            "-r",
-        parser.add_argument('-d', '--debug', help='Enable debug mode', action='store_true')
+            "--receiver",
-        parser.add_argument('-i', '--interface', help='Which AWDL interface to use', default='awdl0')
+            help="Peer to send file to (can be index, ID, or hostname)",
        )
        parser.add_argument(
            "-e", "--email", nargs="*", help="User's email addresses (currently unused)"
        )
        parser.add_argument(
            "-p", "--phone", nargs="*", help="User's phone numbers (currently unused)"
        )
        parser.add_argument(
            "-n", "--name", help="Computer name (displayed in sharing pane)"
        )
        parser.add_argument(
            "-m", "--model", help="Computer model (displayed in sharing pane)"
        )
        parser.add_argument(
            "-d", "--debug", help="Enable debug mode", action="store_true"
        )
        parser.add_argument(
            "-i", "--interface", help="Which AWDL interface to use", default="awdl0"
        )
        args = parser.parse_args(args)
        if args.debug:
-            logging.basicConfig(level=logging.DEBUG, format='%(asctime)s %(levelname)-8s %(name)s: %(message)s')
+            logging.basicConfig(
                level=logging.DEBUG,
                format="%(asctime)s %(levelname)-8s %(name)s: %(message)s",
            )
        else:
-            logging.basicConfig(level=logging.INFO, format='%(message)s')
+            logging.basicConfig(level=logging.INFO, format="%(message)s")
        # TODO put emails and phone in canonical form (lower case, no '+' sign, etc.)
-        self.config = AirDropConfig(email=args.email, phone=args.phone,
+        self.config = AirDropConfig(
-                                    computer_name=args.name, computer_model=args.model,
+            email=args.email,
-                                    debug=args.debug, interface=args.interface)
+            phone=args.phone,
            computer_name=args.name,
            computer_model=args.model,
            debug=args.debug,
            interface=args.interface,
        )
        self.server = None
        self.client = None
        self.browser = None
@@ -71,18 +95,19 @@ class AirDropCli:
        self.lock = threading.Lock()
        try:
-            if args.action == 'receive':
+            if args.action == "receive":
                self.receive()
-            elif args.action == 'find':
+            elif args.action == "find":
                self.find()
            else:  # args.action == 'send'
                if args.file is None:
-                    parser.error('Need -f,--file when using send')
+                    parser.error("Need -f,--file when using send")
-                if not os.path.isfile(args.file):
+                if not os.path.isfile(args.file) and not args.url:
-                    parser.error('File in -f,--file not found')
+                    parser.error("File in -f,--file not found")
                self.file = args.file
                self.is_url = args.url
                if args.receiver is None:
-                    parser.error('Need -r,--receiver when using send')
+                    parser.error("Need -r,--receiver when using send")
                self.receiver = args.receiver
                self.send()
        except KeyboardInterrupt:
@@ -92,17 +117,17 @@ class AirDropCli:
                self.server.stop()
    def find(self):
-        logger.info('Looking for receivers. Press enter to stop ...')
+        logger.info("Looking for receivers. Press Ctrl+C to stop ...")
        self.browser = AirDropBrowser(self.config)
        self.browser.start(callback_add=self._found_receiver)
        try:
-            input()
+            threading.Event().wait()
        except KeyboardInterrupt:
            pass
        finally:
            self.browser.stop()
-            logger.debug('Save discovery results to {}'.format(self.config.discovery_report))
+            logger.debug(f"Save discovery results to {self.config.discovery_report}")
-            with open(self.config.discovery_report, 'w') as f:
+            with open(self.config.discovery_report, "w") as f:
                json.dump(self.discover, f)
    def _found_receiver(self, info):
@@ -111,39 +136,45 @@ class AirDropCli:
    def _send_discover(self, info):
        try:
-            address = ipaddress.ip_address(info.address).compressed
+            address = info.parsed_addresses()[0]  # there should only be one address
-        except ValueError:
+        except IndexError:
-            return  # not a valid address
+            logger.warning(f"Ignoring receiver with missing address {info}")
-        id = info.name.split('.')[0]
+            return
        identifier = info.name.split(".")[0]
        hostname = info.server
        port = int(info.port)
-        logger.debug('AirDrop service found: {}, {}:{}, ID {}'.format(hostname, address, port, id))
+        logger.debug(f"AirDrop service found: {hostname}, {address}:{port}, ID {id}")
        client = AirDropClient(self.config, (address, int(port)))
-        flags = int(info.properties[b'flags'])
+        try:
            flags = int(info.properties[b"flags"])
        except KeyError:
            # TODO in some cases, `flags` are not set in service info; for now we'll try anyway
            flags = AirDropReceiverFlags.SUPPORTS_DISCOVER_MAYBE
        if flags & AirDropReceiverFlags.SUPPORTS_DISCOVER_MAYBE:
            try:
                receiver_name = client.send_discover()
            except TimeoutError:
                receiver_name = None
                pass
        else:
            receiver_name = None
        discoverable = receiver_name is not None
        index = len(self.discover)
        node_info = {
-            'name': receiver_name,
+            "name": receiver_name,
-            'address': address,
+            "address": address,
-            'port': port,
+            "port": port,
-            'id': id,
+            "id": identifier,
-            'flags': flags,
+            "flags": flags,
-            'discoverable': discoverable,
+            "discoverable": discoverable,
        }
        self.lock.acquire()
        self.discover.append(node_info)
        if discoverable:
-            logger.info('Found  index {}  ID {}  name {}'.format(index, id, receiver_name))
+            logger.info(f"Found  index {index}  ID {identifier}  name {receiver_name}")
        else:
            logger.debug(f"Receiver ID {identifier} is not discoverable")
        self.lock.release()
    def receive(self):
@@ -155,26 +186,28 @@ class AirDropCli:
        info = self._get_receiver_info()
        if info is None:
            return
-        self.client = AirDropClient(self.config, (info['address'], info['port']))
+        self.client = AirDropClient(self.config, (info["address"], info["port"]))
-        logger.info('Asking receiver to accept ...')
+        logger.info("Asking receiver to accept ...")
-        if not self.client.send_ask(self.file):
+        if not self.client.send_ask(self.file, is_url=self.is_url):
-            logger.warning('Receiver declined')
+            logger.warning("Receiver declined")
            return
-        logger.info('Receiver accepted')
+        logger.info("Receiver accepted")
-        logger.info('Uploading file ...')
+        logger.info("Uploading file ...")
-        if not self.client.send_upload(self.file):
+        if not self.client.send_upload(self.file, is_url=self.is_url):
-            logger.warning('Uploading has failed')
+            logger.warning("Uploading has failed")
            return
-        logger.info('Uploading has been successful')
+        logger.info("Uploading has been successful")
    def _get_receiver_info(self):
        if not os.path.exists(self.config.discovery_report):
-            logger.error('No discovery report exists, please run \'opendrop find\' first')
+            logger.error("No discovery report exists, please run 'opendrop find' first")
            return None
        age = time.time() - os.path.getmtime(self.config.discovery_report)
        if age > 60:  # warn if report is older than a minute
-            logger.warning('Old discovery report (%.1f seconds), consider running \'opendrop find\' again', age)
+            logger.warning(
-        with open(self.config.discovery_report, 'r') as f:
+                f"Old discovery report ({age:.1f} seconds), consider running 'opendrop find' again"
            )
        with open(self.config.discovery_report, "r") as f:
            infos = json.load(f)
        # (1) try 'index'
@@ -186,14 +219,16 @@ class AirDropCli:
        except IndexError:
            pass
        # (2) try 'id'
-        if len(self.receiver) is 12:
+        if len(self.receiver) == 12:
            for info in infos:
-                if info['id'] == self.receiver:
+                if info["id"] == self.receiver:
                    return info
        # (3) try hostname
        for info in infos:
-            if info['name'] == self.receiver:
+            if info["name"] == self.receiver:
                return info
        # (fail)
-        logger.error('Receiver does not exist (check -r,--receiver format or try \'opendrop find\' again')
+        logger.error(
            "Receiver does not exist (check -r,--receiver format or try 'opendrop find' again"
        )
        return None
@@ -17,36 +17,42 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
-import fleep
+import io
 import http
 import ipaddress
 import logging
 import os
 import io
 import libarchive
 import platform
 import plistlib
 import socket
-from http import client
+from http.client import HTTPSConnection
-from .util import AirDropUtil, AbsArchiveWrite
+import fleep
-from .zeroconf import ServiceBrowser, Zeroconf
+import libarchive
 from zeroconf import IPVersion, ServiceBrowser, Zeroconf
 from .util import AbsArchiveWrite, AirDropUtil
 logger = logging.getLogger(__name__)
 class AirDropBrowser:
    def __init__(self, config):
        self.ip_addr = AirDropUtil.get_ip_for_interface(config.interface, ipv6=True)
        if self.ip_addr is None:
-            if config.interface is 'awdl0':
+            if config.interface == "awdl0":
-                raise RuntimeError('Interface {} does not have an IPv6 address. '
+                raise RuntimeError(
-                                   'Make sure that `owl` is running.'.format(config.interface))
+                    f"Interface {config.interface} does not have an IPv6 address. Make sure that `owl` is running."
                )
            else:
-                raise RuntimeError('Interface {} does not have an IPv6 address'.format(config.interface))
+                raise RuntimeError(
                    f"Interface {config.interface} does not have an IPv6 address"
                )
-        self.zeroconf = Zeroconf(interfaces=[self.ip_addr], ipv6_interface_name=config.interface)
+        self.zeroconf = Zeroconf(
            interfaces=[str(self.ip_addr)],
            ip_version=IPVersion.V6Only,
            apple_p2p=platform.system() == "Darwin",
        )
        self.callback_add = None
        self.callback_remove = None
@@ -60,28 +66,27 @@ class AirDropBrowser:
            return  # already started
        self.callback_add = callback_add
        self.callback_remove = callback_remove
-        self.browser = ServiceBrowser(self.zeroconf, '_airdrop._tcp.local.', self)
+        self.browser = ServiceBrowser(self.zeroconf, "_airdrop._tcp.local.", self)
    def stop(self):
        self.browser.cancel()
        self.browser = None
        self.zeroconf.close()
-    def add_service(self, zeroconf, type, name):
+    def add_service(self, zeroconf, service_type, name):
-        info = zeroconf.get_service_info(type, name)
+        info = zeroconf.get_service_info(service_type, name)
-        logger.debug('Add service {}'.format(name))
+        logger.debug(f"Add service {name}")
        if self.callback_add is not None:
            self.callback_add(info)
-    def remove_service(self, zeroconf, type, name):
+    def remove_service(self, zeroconf, service_type, name):
-        info = zeroconf.get_service_info(type, name)
+        info = zeroconf.get_service_info(service_type, name)
-        logger.debug('Remove service {}'.format(name))
+        logger.debug(f"Remove service {name}")
        if self.callback_remove is not None:
            self.callback_remove(info)
 class AirDropClient:
    def __init__(self, config, receiver):
        self.config = config
        self.receiver_host = receiver[0]
@@ -89,9 +94,11 @@ class AirDropClient:
        self.http_conn = None
    def send_POST(self, url, body, headers=None):
-        logger.debug('Send {} request'.format(url))
+        logger.debug(f"Send {url} request")
-        AirDropUtil.write_debug(self.config, body, 'send_{}_request.plist'.format(url.lower().strip('/')))
+        AirDropUtil.write_debug(
            self.config, body, f"send_{url.lower().strip('/')}_request.plist"
        )
        _headers = self._get_headers()
        if headers is not None:
@@ -99,96 +106,116 @@ class AirDropClient:
                _headers[key] = val
        if self.http_conn is None:
            # Use single connection
-            self.http_conn = HTTPSConnectionAWDL(self.receiver_host, self.receiver_port,
+            self.http_conn = HTTPSConnectionAWDL(
-                                                 interface_name=self.config.interface,
+                self.receiver_host,
-                                                 context=self.config.get_ssl_context())
+                self.receiver_port,
-        self.http_conn.request('POST', url, body=body, headers=_headers)
+                interface_name=self.config.interface,
                context=self.config.get_ssl_context(),
            )
        self.http_conn.request("POST", url, body=body, headers=_headers)
        http_resp = self.http_conn.getresponse()
        response_bytes = http_resp.read()
-        AirDropUtil.write_debug(self.config, response_bytes, 'send_{}_response.plist'.format(url.lower().strip('/')))
+        AirDropUtil.write_debug(
            self.config,
            response_bytes,
            f"send_{url.lower().strip('/')}_response.plist",
        )
        if http_resp.status != 200:
            status = False
-            logger.debug('{} request failed: {}'.format(url, http_resp.status))
+            logger.debug(f"{url} request failed: {http_resp.status}")
        else:
            status = True
-            logger.debug('{} request successful'.format(url))
+            logger.debug(f"{url} request successful")
        return status, response_bytes
    def send_discover(self):
        discover_body = {}
        if self.config.record_data:
-            discover_body['SenderRecordData'] = self.config.record_data
+            discover_body["SenderRecordData"] = self.config.record_data
-        discover_plist_binary = plistlib.dumps(discover_body, fmt=plistlib.FMT_BINARY)
+        discover_plist_binary = plistlib.dumps(
-        success, response_bytes = self.send_POST('/Discover', discover_plist_binary)
+            discover_body, fmt=plistlib.FMT_BINARY  # pylint: disable=no-member
        )
        _, response_bytes = self.send_POST("/Discover", discover_plist_binary)
        response = plistlib.loads(response_bytes)
        # if name is returned, then receiver is discoverable
-        return response.get('ReceiverComputerName')
+        return response.get("ReceiverComputerName")
-    def send_ask(self, file_path, icon=None):
+    def send_ask(self, file_path, is_url=False, icon=None):
        ask_body = {
-            'SenderComputerName': self.config.computer_name,
+            "SenderComputerName": self.config.computer_name,
-            'BundleID': 'com.apple.finder',
+            "BundleID": "com.apple.finder",
-            'SenderModelName': self.config.computer_model,
+            "SenderModelName": self.config.computer_model,
-            'SenderID': self.config.service_id,
+            "SenderID": self.config.service_id,
-            'ConvertMediaFormats': False,
+            "ConvertMediaFormats": False,
        }
        if self.config.record_data:
-            ask_body['SenderRecordData'] = self.config.record_data
+            ask_body["SenderRecordData"] = self.config.record_data
        if isinstance(file_path, str):
            file_path = [file_path]
        # generate icon for first file
        with open(file_path[0], 'rb') as f:
            file_header = f.read(128)
            flp = fleep.get(file_header)
            if not icon and len(flp.mime) > 0 and 'image' in flp.mime[0]:
                icon = AirDropUtil.generate_file_icon(f.name)
        if icon:
            ask_body['FileIcon'] = icon
        def file_entries(files):
            for file in files:
                file_name = os.path.basename(file)
                file_entry = {
-                    'FileName': file_name,
+                    "FileName": file_name,
-                    'FileType': AirDropUtil.get_uti_type(flp),
+                    "FileType": AirDropUtil.get_uti_type(flp),
-                    'FileBomPath': os.path.join('.', file_name),
+                    "FileBomPath": os.path.join(".", file_name),
-                    'FileIsDirectory': os.path.isdir(file_name),
+                    "FileIsDirectory": os.path.isdir(file_name),
-                    'ConvertMediaFormats': 0
+                    "ConvertMediaFormats": 0,
                }
                yield file_entry
        ask_body['Files'] = [e for e in file_entries(file_path)]
        ask_body['Items'] = []
-        ask_binary = plistlib.dumps(ask_body, fmt=plistlib.FMT_BINARY)
+        if isinstance(file_path, str):
-        success, _ = self.send_POST('/Ask', ask_binary)
+            file_path = [file_path]
        if is_url:
            ask_body["Items"] = file_path
        else:
            # generate icon for first file
            with open(file_path[0], "rb") as f:
                file_header = f.read(128)
                flp = fleep.get(file_header)
                if not icon and len(flp.mime) > 0 and "image" in flp.mime[0]:
                    icon = AirDropUtil.generate_file_icon(f.name)
            ask_body["Files"] = [e for e in file_entries(file_path)]
        if icon:
            ask_body["FileIcon"] = icon
        ask_binary = plistlib.dumps(
            ask_body, fmt=plistlib.FMT_BINARY  # pylint: disable=no-member
        )
        success, _ = self.send_POST("/Ask", ask_binary)
        return success
-    def send_upload(self, file_path):
+    def send_upload(self, file_path, is_url=False):
        """
        Send a file to a receiver.
        """
        # Don't send an upload request if we just sent a link
        if is_url:
            return
        headers = {
-            'Content-Type': 'application/x-cpio',
+            "Content-Type": "application/x-cpio",
        }
        # Create archive in memory ...
        stream = io.BytesIO()
-        with libarchive.custom_writer(stream.write, 'cpio', filter_name='gzip',
+        with libarchive.custom_writer(
-                                      archive_write_class=AbsArchiveWrite) as archive:
+            stream.write,
            "cpio",
            filter_name="gzip",
            archive_write_class=AbsArchiveWrite,
        ) as archive:
            for f in [file_path]:
                ff = os.path.basename(f)
-                archive.add_abs_file(f, os.path.join('.', ff))
+                archive.add_abs_file(f, os.path.join(".", ff))
        stream.seek(0)
        # ... then send in chunked mode
-        success, _ = self.send_POST('/Upload', stream, headers=headers)
+        success, _ = self.send_POST("/Upload", stream, headers=headers)
        # TODO better: write archive chunk whenever send_POST does a read to avoid having the whole archive in memory
@@ -196,43 +223,63 @@ class AirDropClient:
    def _get_headers(self):
        """
-        Get the headers for requests sent 
+        Get the headers for requests sent
        """
        headers = {
-            'Content-Type': 'application/octet-stream',
+            "Content-Type": "application/octet-stream",
-            'Connection': 'keep-alive',
+            "Connection": "keep-alive",
-            'Accept': '*/*',
+            "Accept": "*/*",
-            'User-Agent': 'AirDrop/1.0',
+            "User-Agent": "AirDrop/1.0",
-            'Accept-Language': 'en-us',
+            "Accept-Language": "en-us",
-            'Accept-Encoding': 'br, gzip, deflate'
+            "Accept-Encoding": "br, gzip, deflate",
        }
        return headers
-class HTTPSConnectionAWDL(http.client.HTTPSConnection):
+class HTTPSConnectionAWDL(HTTPSConnection):
    """
    This class allows to bind the HTTPConnection to a specific network interface
    """
-    def __init__(self, host, port=None, key_file=None, cert_file=None, timeout=None, source_address=None,
+    def __init__(
-                 *, context=None, check_hostname=None, interface_name=None):
+        self,
        host,
        port=None,
        key_file=None,
        cert_file=None,
        timeout=None,
        source_address=None,
        *,
        context=None,
        check_hostname=None,
        interface_name=None,
    ):
        if interface_name is not None:
-            if '%' not in host:
+            if "%" not in host:
                if isinstance(ipaddress.ip_address(host), ipaddress.IPv6Address):
-                    host = host + '%' + interface_name
+                    host = host + "%" + interface_name
        if timeout is None:
            timeout = socket.getdefaulttimeout()
-        super(HTTPSConnectionAWDL, self).__init__(host=host, port=port, key_file=key_file, cert_file=cert_file,
+        super(HTTPSConnectionAWDL, self).__init__(
-                                                  timeout=timeout, source_address=source_address, context=context,
+            host=host,
-                                                  check_hostname=check_hostname)
+            port=port,
            key_file=key_file,
            cert_file=cert_file,
            timeout=timeout,
            source_address=source_address,
            context=context,
            check_hostname=check_hostname,
        )
        self.interface_name = interface_name
        self._create_connection = self.create_connection_awdl
-    def create_connection_awdl(self, address, timeout=socket.getdefaulttimeout(), source_address=None):
+    def create_connection_awdl(
        self, address, timeout=socket.getdefaulttimeout(), source_address=None
    ):
        """Connect to *address* and return the socket object.
        Convenience function.  Connect to *address* (a 2-tuple ``(host,
@@ -248,19 +295,18 @@ class HTTPSConnectionAWDL(http.client.HTTPSConnection):
        host, port = address
        err = None
        for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM):
-            af, socktype, proto, canonname, sa = res
+            af, socktype, proto, _, sa = res
            sock = None
            try:
                sock = socket.socket(af, socktype, proto)
                if timeout is not socket.getdefaulttimeout():
                    sock.settimeout(timeout)
-                if self.interface_name == 'awdl0' and platform.system() == 'Darwin':
+                if self.interface_name == "awdl0" and platform.system() == "Darwin":
                    sock.setsockopt(socket.SOL_SOCKET, 0x1104, 1)
                if source_address:
                    sock.bind(source_address)
                sock.connect(sa)
                # Break explicitly a reference cycle
                err = None
                return sock
            except socket.error as _:
@@ -271,4 +317,4 @@ class HTTPSConnectionAWDL(http.client.HTTPSConnection):
        if err is not None:
            raise err
        else:
-            raise socket.error('getaddrinfo returns an empty list')
+            raise socket.error("getaddrinfo returns an empty list")
@@ -17,14 +17,15 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
 import os
 import logging
-from pkg_resources import resource_filename
+import os
 import random
 import socket
 import ssl
 import random
 import subprocess
 from pkg_resources import resource_filename
 logger = logging.getLogger(__name__)
@@ -33,7 +34,9 @@ class AirDropReceiverFlags:
    Recovered from sharingd`receiverSupportsX methods.
    A valid node needs to either have SUPPORTS_PIPELINING or SUPPORTS_MIXED_TYPES
    according to sharingd`[SDBonjourBrowser removeInvalidNodes:].
    Default flags on macOS: 0x3fb according to sharingd`[SDRapportBrowser defaultSFNodeFlags]
    """
    SUPPORTS_URL = 0x01
    SUPPORTS_DVZIP = 0x02
    SUPPORTS_PIPELINING = 0x04
@@ -41,17 +44,30 @@ class AirDropReceiverFlags:
    SUPPORTS_UNKNOWN1 = 0x10
    SUPPORTS_UNKNOWN2 = 0x20
    SUPPORTS_IRIS = 0x40
-    SUPPORTS_DISCOVER_MAYBE = 0x80  # Probably indicates that server supports /Discover URL
+    SUPPORTS_DISCOVER_MAYBE = (
        0x80  # Probably indicates that server supports /Discover URL
    )
    SUPPORTS_UNKNOWN3 = 0x100
    SUPPORTS_ASSET_BUNDLE = 0x200
 class AirDropConfig:
-
+    def __init__(
-    def __init__(self, host_name=None, computer_name=None, computer_model=None, server_port=8771,
+        self,
-                 airdrop_dir='~/.opendrop', service_id=None,
+        host_name=None,
-                 email=None, phone=None, debug=False, interface=None):
+        computer_name=None,
        computer_model=None,
        server_port=8771,
        airdrop_dir="~/.opendrop",
        service_id=None,
        email=None,
        phone=None,
        debug=False,
        interface=None,
    ):
        self.airdrop_dir = os.path.expanduser(airdrop_dir)
-        self.discovery_report = os.path.join(self.airdrop_dir, 'discover.last.json')
+        self.discovery_report = os.path.join(self.airdrop_dir, "discover.last.json")
        if host_name is None:
            host_name = socket.gethostname()
@@ -60,19 +76,19 @@ class AirDropConfig:
            computer_name = host_name
        self.computer_name = computer_name
        if computer_model is None:
-            computer_model = 'OpenDrop'
+            computer_model = "OpenDrop"
        self.computer_model = computer_model
        self.port = server_port
        if service_id is None:
-            service_id = '{0:0{1}x}'.format(random.randint(0, 0xffffffffffff), 12)  # random 6-byte string in base16
+            service_id = f"{random.randint(0, 0xFFFFFFFFFFFF):012x}"  # random 6-byte string in base16
        self.service_id = service_id
        self.debug = debug
-        self.debug_dir = os.path.join(self.airdrop_dir, 'debug')
+        self.debug_dir = os.path.join(self.airdrop_dir, "debug")
        if interface is None:
-            interface = 'awdl0'
+            interface = "awdl0"
        self.interface = interface
        if email is None:
@@ -83,35 +99,70 @@ class AirDropConfig:
        self.phone = phone
        # Bare minimum, we currently do not support anything else
-        self.flags = AirDropReceiverFlags.SUPPORTS_MIXED_TYPES | AirDropReceiverFlags.SUPPORTS_DISCOVER_MAYBE
+        self.flags = (
            AirDropReceiverFlags.SUPPORTS_MIXED_TYPES
            | AirDropReceiverFlags.SUPPORTS_DISCOVER_MAYBE
        )
-        self.root_ca_file = resource_filename('opendrop', 'certs/apple_root_ca.pem')
+        self.root_ca_file = resource_filename("opendrop", "certs/apple_root_ca.pem")
        if not os.path.exists(self.root_ca_file):
-            raise FileNotFoundError('Need Apple root CA certificate: {}'.format(self.root_ca_file))
+            raise FileNotFoundError(
                f"Need Apple root CA certificate: {self.root_ca_file}"
            )
-        self.key_dir = os.path.join(self.airdrop_dir, 'keys')
+        self.key_dir = os.path.join(self.airdrop_dir, "keys")
-        self.cert_file = os.path.join(self.key_dir, 'certificate.pem')
+        self.cert_file = os.path.join(self.key_dir, "certificate.pem")
-        self.key_file = os.path.join(self.key_dir, 'key.pem')
+        self.key_file = os.path.join(self.key_dir, "key.pem")
        if not os.path.exists(self.cert_file) or not os.path.exists(self.key_file):
-            logger.info('Key file or certificate does not exist')
+            logger.info("Key file or certificate does not exist")
            self.create_default_key()
-        # TODO extract record data from a sample exchange
+        self.record_file = os.path.join(self.key_dir, "validation_record.cms")
        self.record_data = None
        if os.path.exists(self.record_file):
            logger.debug("Using provided Apple ID Validation Record")
            with open(self.record_file, "rb") as f:
                self.record_data = f.read()
        else:
            logger.debug("No Apple ID Validation Record found")
    def create_default_key(self):
-        logger.info('Create new self-signed certificate in {}'.format(self.key_dir))
+        logger.info(f"Create new self-signed certificate in {self.key_dir}")
        if not os.path.exists(self.key_dir):
            os.makedirs(self.key_dir)
-        subprocess.run(['openssl', 'req', '-newkey', 'rsa:2048', '-nodes', '-keyout', 'key.pem',
+        subprocess.run(
-                        '-x509', '-days', '365', '-out', 'certificate.pem',
+            [
-                        '-subj', '/CN={}'.format(self.computer_name)], cwd=self.key_dir,
+                "openssl",
-                       stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+                "req",
                "-newkey",
                "rsa:2048",
                "-nodes",
                "-keyout",
                "key.pem",
                "-x509",
                "-days",
                "365",
                "-out",
                "certificate.pem",
                "-subj",
                f"/CN={self.computer_name}",
            ],
            cwd=self.key_dir,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            check=True,
        )
    def get_ssl_context(self):
-        sslctxt = ssl.SSLContext()
+
-        sslctxt.load_cert_chain(self.cert_file, keyfile=self.key_file)
+        ctx = ssl.SSLContext(  # lgtm[py/insecure-protocol], TODO see https://github.com/Semmle/ql/issues/2554
-        sslctxt.load_verify_locations(cafile=self.root_ca_file)
+            ssl.PROTOCOL_TLS
-        sslctxt.verify_mode = ssl.CERT_NONE  # we accept self-signed certificates as does Apple
+        )
-        return sslctxt
+        ctx.options |= ssl.OP_NO_TLSv1  # TLSv1.0 is insecure
        ctx.load_cert_chain(self.cert_file, keyfile=self.key_file)
        ctx.load_verify_locations(cafile=self.root_ca_file)
        ctx.verify_mode = (
            ssl.CERT_NONE
        )  # we accept self-signed certificates as does Apple
        return ctx
@@ -17,18 +17,18 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
 import io
-
+import json
 import logging
 import platform
 import plistlib
 import socket
-from http.server import HTTPServer, BaseHTTPRequestHandler
+import time
-import json
+from http.server import BaseHTTPRequestHandler, HTTPServer
 import libarchive
 import libarchive.extract
 import libarchive.read
-from .zeroconf import Zeroconf, ServiceInfo
+from zeroconf import IPVersion, ServiceInfo, Zeroconf
 import time
 from .util import AirDropUtil
@@ -44,39 +44,53 @@ class AirDropServer:
        self.config = config
        # Use IPv6
-        self.serveraddress = ('::', self.config.port)
+        self.serveraddress = ("::", self.config.port)
        self.ServerClass = HTTPServerV6
        self.ServerClass.allow_reuse_address = False
-        self.ip_addr = AirDropUtil.get_ip_for_interface(self.config.interface, ipv6=True)
+        self.ip_addr = AirDropUtil.get_ip_for_interface(
            self.config.interface, ipv6=True
        )
        if self.ip_addr is None:
-            if self.config.interface is 'awdl0':
+            if self.config.interface == "awdl0":
-                raise RuntimeError('Interface {} does not have an IPv6 address. '
+                raise RuntimeError(
-                                   'Make sure that `owl` is running.'.format(self.config.interface))
+                    f"Interface {self.config.interface} does not have an IPv6 address. Make sure that `owl` is running."
                )
            else:
-                raise RuntimeError('Interface {} does not have an IPv6 address'.format(self.config.interface))
+                raise RuntimeError(
                    f"Interface {self.config.interface} does not have an IPv6 address"
                )
        self.Handler = AirDropServerHandler
        self.Handler.config = self.config
-        self.zeroconf = Zeroconf(interfaces=[self.ip_addr], ipv6_interface_name=self.config.interface,
+        self.zeroconf = Zeroconf(
-                                 apple_mdns=True)
+            interfaces=[str(self.ip_addr)],
            ip_version=IPVersion.V6Only,
            apple_p2p=platform.system() == "Darwin",
        )
        self.http_server = self._init_server()
        self.service_info = self._init_service()
    def _init_service(self):
        properties = self.get_properties()
-        server = self.config.host_name + '.local.'
+        server = self.config.host_name + ".local."
-        service_name = self.config.service_id + '._airdrop._tcp.local.'
+        service_name = self.config.service_id + "._airdrop._tcp.local."
        info = ServiceInfo(
-            '_airdrop._tcp.local.', service_name,
+            "_airdrop._tcp.local.",
-            self.ip_addr.packed, self.config.port, 0, 0, properties, server)
+            service_name,
            port=self.config.port,
            properties=properties,
            server=server,
            addresses=[self.ip_addr.packed],
        )
        return info
    def start_service(self):
-        logger.info('Announcing service: host {}, address {}, port {}'.format(self.config.host_name,
+        logger.info(
-                                                                              self.ip_addr, self.config.port))
+            f"Announcing service: host {self.config.host_name}, address {self.ip_addr}, port {self.config.port}"
        )
        self.zeroconf.register_service(self.service_info)
    def _init_server(self):
@@ -89,15 +103,17 @@ class AirDropServer:
            httpd = self.ServerClass(self.serveraddress, self.Handler)
        # Adapt socket for awdl0
-        if self.config.interface == 'awdl0' and platform.system() == 'Darwin':
+        if self.config.interface == "awdl0" and platform.system() == "Darwin":
            httpd.socket.setsockopt(socket.SOL_SOCKET, 0x1104, 1)
-        httpd.socket = self.config.get_ssl_context().wrap_socket(sock=httpd.socket, server_side=True)
+        httpd.socket = self.config.get_ssl_context().wrap_socket(
            sock=httpd.socket, server_side=True
        )
        return httpd
    def start_server(self):
-        logger.info('Starting HTTPS server')
+        logger.info("Starting HTTPS server")
        self.http_server.serve_forever()
    def stop(self):
@@ -105,7 +121,7 @@ class AirDropServer:
        self.http_server.shutdown()
    def get_properties(self):
-        properties = {b'flags': str(self.config.flags).encode('utf-8')}
+        properties = {b"flags": str(self.config.flags).encode("utf-8")}
        return properties
@@ -117,7 +133,8 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
    """
    Server which responds to AirDrop HTTP POST requests
    """
-    protocol_version = 'HTTP/1.1'
+
    protocol_version = "HTTP/1.1"
    config = None
    def _set_response(self, content_length):
@@ -125,7 +142,7 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
        Setting the default values for a successful response
        """
        self.send_response(200)
-        self.send_header('Content-Length', content_length)
+        self.send_header("Content-Length", content_length)
        self.end_headers()
    def do_HEAD(self):
@@ -133,27 +150,29 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
        Answer head requests
        """
        self.send_response(200)
-        self.send_header('Content-type', 'text/html')
+        self.send_header("Content-type", "text/html")
        self.end_headers()
    def do_GET(self):
        """
        Answer get requests
        """
-        logger.debug('GET request at {}'.format(self.path))
+        logger.debug(f"GET request at {self.path}")
-        body = '\n'.encode('utf-8')
+        body = "\n".encode("utf-8")
        self._set_response(len(body))
        self.wfile.write(body)
    def handle_discover(self):
-        content_length = int(self.headers['Content-Length'])
+        content_length = int(self.headers["Content-Length"])
        post_data = self.rfile.read(content_length)
-        AirDropUtil.write_debug(self.config, post_data, 'receive_discover_request.plist')
+        AirDropUtil.write_debug(
            self.config, post_data, "receive_discover_request.plist"
        )
        # sample media capabilities as recorded from macOS 10.13.3
        media_capabilities = {
-            'Version': 1,
+            "Version": 1,
            # don't advertise any codec/container support so we receive legacy file formats (JPEG instead of HEIF, etc.)
            # 'Codecs': {
            #     'hvc1': {
@@ -181,60 +200,72 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
            # }
        }
        media_capabilities_json = json.JSONEncoder().encode(media_capabilities)
-        media_capabilities_binary = media_capabilities_json.encode('utf-8')
+        media_capabilities_binary = media_capabilities_json.encode("utf-8")
        discover_answer = {
-            'ReceiverMediaCapabilities': media_capabilities_binary,
+            "ReceiverMediaCapabilities": media_capabilities_binary,
-            'ReceiverComputerName': self.config.computer_name,
+            "ReceiverComputerName": self.config.computer_name,
-            'ReceiverModelName': self.config.computer_model,
+            "ReceiverModelName": self.config.computer_model,
        }
        if self.config.record_data:
-            discover_answer['ReceiverRecordData'] = self.config.record_data
+            discover_answer["ReceiverRecordData"] = self.config.record_data
-        discover_answer_binary = plistlib.dumps(discover_answer, fmt=plistlib.FMT_BINARY)
+        discover_answer_binary = plistlib.dumps(
            discover_answer, fmt=plistlib.FMT_BINARY  # pylint: disable=no-member
        )
-        AirDropUtil.write_debug(self.config, discover_answer_binary, 'receive_discover_response.plist')
+        AirDropUtil.write_debug(
            self.config, discover_answer_binary, "receive_discover_response.plist"
        )
        # Change to actual length
        self._set_response(len(discover_answer_binary))
        self.wfile.write(discover_answer_binary)
    def handle_ask(self):
-        content_length = int(self.headers['Content-Length'])
+        content_length = int(self.headers["Content-Length"])
        post_data = self.rfile.read(content_length)
-        AirDropUtil.write_debug(self.config, post_data, 'receive_ask_request.plist')
+        AirDropUtil.write_debug(self.config, post_data, "receive_ask_request.plist")
-        ask_response = {'ReceiverModelName': self.config.computer_model,
+        ask_response = {
-                        'ReceiverComputerName': self.config.computer_name}
+            "ReceiverModelName": self.config.computer_model,
-        ask_resp_binary = plistlib.dumps(ask_response, fmt=plistlib.FMT_BINARY)
+            "ReceiverComputerName": self.config.computer_name,
        }
        ask_resp_binary = plistlib.dumps(
            ask_response, fmt=plistlib.FMT_BINARY  # pylint: disable=no-member
        )
-        AirDropUtil.write_debug(self.config, ask_resp_binary, 'receive_ask_response.plist')
+        AirDropUtil.write_debug(
            self.config, ask_resp_binary, "receive_ask_response.plist"
        )
        self._set_response(len(ask_resp_binary))
        self.wfile.write(ask_resp_binary)
    def handle_upload(self):
-        if self.headers.get('content-type', '').lower() != 'application/x-cpio':
+        if self.headers.get("content-type", "").lower() != "application/x-cpio":
-            logger.warning('Unsupported content-type: {}'.format(self.headers.get('content-type')))
+            logger.warning(
                f"Unsupported content-type: {self.headers.get('content-type')}"
            )
            self.send_response(406)  # Unprocessable Entity
-            self.send_header('Content-Type', 'application/x-cpio')
+            self.send_header("Content-Type", "application/x-cpio")
-            self.send_header('Content-Length', 0)
+            self.send_header("Content-Length", 0)
-            self.send_header('Connection', 'close')
+            self.send_header("Connection", "close")
            self.end_headers()
            return
        # If pipelining is not support, 'Expect: 100-continue' is sent to which we need to respond
-        if self.headers.get('expect', '').lower() == '100-continue':
+        if self.headers.get("expect", "").lower() == "100-continue":
            self.send_response(100)
-            self.send_header('Content-Length', 0)
+            self.send_header("Content-Length", 0)
            self.end_headers()
-        if self.headers.get('transfer-encoding', '').lower() != 'chunked':
+        if self.headers.get("transfer-encoding", "").lower() != "chunked":
-            logger.warning('Expect chunked transfer encoding')
+            logger.warning("Expect chunked transfer encoding")
            self.send_response(400)  # Bad Request
-            self.send_header('Transfer-Encoding', 'Chunked')
+            self.send_header("Transfer-Encoding", "Chunked")
-            self.send_header('Content-Length', 0)
+            self.send_header("Content-Length", 0)
-            self.send_header('Connection', 'close')
+            self.send_header("Connection", "close")
            self.end_headers()
            return
@@ -246,18 +277,18 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
                self.total = 0
            def _next_chunk(self):
-                if self.chunk is None or len(self.chunk) is 0:
+                if self.chunk is None or len(self.chunk) == 0:
                    length = int(self.rfile.readline().rstrip(), 16)
                    self.chunk = self.rfile.read(length)
                    self.rfile.readline()  # strip trailing \n\r
            def readinto(self, buf):
                self._next_chunk()
-                l = min(len(self.chunk), len(buf))
+                length = min(len(self.chunk), len(buf))
-                buf[:l] = self.chunk[:l]
+                buf[:length] = self.chunk[:length]
-                self.chunk = self.chunk[l:]
+                self.chunk = self.chunk[length:]
-                self.total += l
+                self.total += length
-                return l
+                return length
        def extract_stream(stream, flags=0):
            """
@@ -267,18 +298,20 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
            with libarchive.read.stream_reader(stream) as archive:
                libarchive.extract.extract_entries(archive, flags)
-        logger.info('Receiving file(s) ...')
+        logger.info("Receiving file(s) ...")
        start = time.time()
        reader = HTTPChunkedReader(self.rfile)
        extract_stream(reader)
        transferred = reader.total / 1024.0 / 1024.0
        speed = transferred / (time.time() - start)
-        logger.info('File(s) received (size {:.02f} MB, speed {:.02f} MB/s)'.format(transferred, speed))
+        logger.info(
            f"File(s) received (size {transferred:.02f} MB, speed {speed:.02f} MB/s)"
        )
        self.send_response(200)
-        self.send_header('Content-Length', 0)
+        self.send_header("Content-Length", 0)
-        self.send_header('Connection', 'close')
+        self.send_header("Connection", "close")
        self.end_headers()
    def do_POST(self):
@@ -286,19 +319,23 @@ class AirDropServerHandler(BaseHTTPRequestHandler):
        Handle post requests
        """
-        logger.debug('POST request at {}'.format(self.path))
+        logger.debug(f"POST request at {self.path}")
-        logger.debug('Headers\n{}'.format(self.headers))
+        logger.debug(f"Headers\n{self.headers}")
-        if self.path == '/Discover':
+        if self.path == "/Discover":
            self.handle_discover()
-        elif self.path == '/Ask':
+        elif self.path == "/Ask":
            self.handle_ask()
-        elif self.path == '/Upload':
+        elif self.path == "/Upload":
            self.handle_upload()
        else:
-            answer = 'POST request for {}'.format(self.path).encode('utf-8')
+            logger.debug(f"POST request at {self.path}")
-            self._set_response(len(answer))
+            self.send_response(400)
-            self.wfile.write(answer)
+            self.send_header("Content-Length", 0)
            self.end_headers()
    def log_message(self, format, *args):
-        logger.debug('{} - - [{}] {}'.format(self.client_address[0], self.log_date_time_string(), format % args))
+        # pylint: disable=redefined-builtin
        logger.debug(
            f"{self.client_address[0]} - - [{self.log_date_time_string()}] {format % args}"
        )
@@ -17,29 +17,25 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
 import base64
 import datetime
 import io
 import ipaddress
 import os
-import plistlib
+
 import hashlib
 import ifaddr
-from PIL import Image, ExifTags
+from libarchive.entry import ArchiveEntry, new_archive_entry
-from libarchive import ffi
+from libarchive.ffi import (  # pylint: disable=no-name-in-module
 from libarchive.entry import new_archive_entry, ArchiveEntry
 from libarchive.ffi import (
    ARCHIVE_EOF,
    entry_sourcepath,
    entry_clear,
-    read_next_header2,
+    entry_sourcepath,
    read_disk_descend,
-    write_header,
+    read_next_header2,
    write_data,
    write_finish_entry,
    write_get_bytes_per_block,
    write_header,
 )
 from libarchive.write import ArchiveWrite, new_archive_read_disk
-from ctypescrypto import cms, x509, pkey, oid
+from PIL import ExifTags, Image
 class AirDropUtil:
@@ -51,120 +47,64 @@ class AirDropUtil:
    @staticmethod
    def get_uti_type(flp) -> str:
        """
-        Get the Apple conform UTI Type from a flp instance which has been used on the data which should be sent 
+        Get the Apple conform UTI Type from a flp instance which has been used on the data which should be sent
-        :param flp: fleep object 
+        :param flp: fleep object
        """
        # Default UTI Type
-        uti_type = 'public.content'
+        uti_type = "public.content"
        if len(flp.mime) == 0 or len(flp.type) == 0:
            return uti_type
        mime = flp.mime[0]
        f_type = flp.type[0]
-        if 'image' in mime:
+        if "image" in mime:
-            uti_type = 'public.image'
+            uti_type = "public.image"
-            if 'jpg' in mime:
+            if "jpg" in mime:
-                uti_type = 'public.jpeg'
+                uti_type = "public.jpeg"
-            elif 'jp2' in mime:
+            elif "jp2" in mime:
-                uti_type = 'public.jpeg-2000'
+                uti_type = "public.jpeg-2000"
-            elif 'gif' in mime:
+            elif "gif" in mime:
-                uti_type = 'com.compuserve.gif'
+                uti_type = "com.compuserve.gif"
-            elif 'png' in mime:
+            elif "png" in mime:
-                uti_type = 'public.png'
+                uti_type = "public.png"
-            elif 'raw' in mime or 'raw' in f_type:
+            elif "raw" in mime or "raw" in f_type:
-                uti_type = 'public.camera-raw-image'
+                uti_type = "public.camera-raw-image"
-        elif 'audio' in f_type:
+        elif "audio" in f_type:
-            uti_type = 'public.audio'
+            uti_type = "public.audio"
-        elif 'video' in f_type:
+        elif "video" in f_type:
-            uti_type = 'public.video'
+            uti_type = "public.video"
-        elif 'archive' in f_type:
+        elif "archive" in f_type:
-            uti_type = 'public.data'
+            uti_type = "public.data"
-            if 'gzip' in mime:
+            if "gzip" in mime:
-                uti_type = 'org.gnu.gnu-zip-archive'
+                uti_type = "org.gnu.gnu-zip-archive"
-            if 'zip' in mime:
+            if "zip" in mime:
-                uti_type = 'public.zip-archive'
+                uti_type = "public.zip-archive"
        return uti_type
    @staticmethod
    def record_data(config, tls_cert, sign_cert, key):
        """
        This method generates the sender record data and will sign it using the CMS format.
        This code serves documentation purposes only and is UNTESTED. To be accepted by Apple clients, we would need the
        Apple-owned private key of the signing certificate.
        :param tls_cert: path to certificate used for AirDrop TLS connections
        :param sign_cert: path to signing certificate
        :param key: path to private key to the signing certificate
        """
        valid_date = datetime.datetime.now() - datetime.timedelta(days=3)
        valid_date_string = valid_date.strftime('%Y-%m-%dT%H:%M:%SZ')
        emails_hashed = [hashlib.sha256(email.encode('utf-8')).hexdigest() for email in config.email]
        phone_numbers_hashed = [hashlib.sha256(phone_number.encode('utf-8')).hexdigest() for phone_number in config.phone]
        # Get the common name of the TLS certificate
        with open(tls_cert, 'rb') as cert_file:
            cert = x509.X509(cert_file.read())
            cn = cert.subject[oid.Oid('2.5.4.3')]
            encDsID = cn.replace('com.apple.idms.appleid.prd.', '')
        # Construct record data
        record_data = {
            'Version': 2,
            'encDsID': encDsID,  # Common name suffix of the certificate
            'altDsID': encDsID,  # Same as encDsID
            'SuggestValidDuration': 30 * 24 * 60 * 60,  # in seconds
            'ValidAsOf': valid_date_string,  # 3 days before now
            'ValidatedEmailHashes': emails_hashed,
            'ValidatedPhoneHashes': phone_numbers_hashed,
        }
        record_data_plist = plistlib.dumps(record_data, fmt=plistlib.FMT_XML)
        with open(sign_cert, 'rb') as sign_cert_file:
            with open(key, 'rb') as key_file:
                cert = x509.X509(sign_cert_file.read())
                key = pkey.PKey(privkey=key_file.read())
                # possibly need to add intermediate certs
                cms_signed = cms.SignedData.create(record_data_plist, cert=cert, pkey=key, certs=None,
                                                   flags=cms.Flags.PARTIAL)
                signed_data = AirDropUtil.pem2der(cms_signed.pem())
        return signed_data
    @staticmethod
    def pem2der(s):
        """
        Create DER Formatted bytes from a PEM Base64 String 
        :param s: PEM formatted string
        """
        start = s.find('-----\n')
        finish = s.rfind('\n-----END')
        data = s[start + 6:finish]
        return base64.b64decode(data)
    @staticmethod
    def generate_file_icon(file_path):
        """
-        Generates a small and a big thumbnail of an image 
+        Generates a small and a big thumbnail of an image
        This will make it possible to preview the sent file
-        :param file_path: The path to the image 
+        :param file_path: The path to the image
        """
        im = Image.open(file_path)
        # rotate according to EXIF tags
        try:
-            exif = dict((ExifTags.TAGS[k], v) for k, v in im._getexif().items() if k in ExifTags.TAGS)
+            exif = dict(
                (ExifTags.TAGS[k], v)
                for k, v in im._getexif().items()  # pylint: disable=protected-access
                if k in ExifTags.TAGS
            )
            angles = {3: 180, 6: 270, 8: 90}
-            orientation = exif['Orientation']
+            orientation = exif["Orientation"]
            if orientation in angles.keys():
                im = im.rotate(angles[orientation], expand=True)
        except (AttributeError, KeyError):
@@ -172,15 +112,15 @@ class AirDropUtil:
        # Big image
        im.thumbnail((540, 540), Image.ANTIALIAS)
-        imgByteArr = io.BytesIO()
+        img_bytes = io.BytesIO()
-        im.save(imgByteArr, format='JPEG2000')
+        im.save(img_bytes, format="JPEG2000")
-        file_icon = imgByteArr.getvalue()
+        file_icon = img_bytes.getvalue()
        # Small image
-        #im.thumbnail((64, 64), Image.ANTIALIAS)
+        # im.thumbnail((64, 64), Image.ANTIALIAS)
-        #imgByteArr = io.BytesIO()
+        # img_bytes = io.BytesIO()
-        #im.save(imgByteArr, format='JPEG2000')
+        # im.save(img_bytes, format='JPEG2000')
-        #small_file_icon = imgByteArr.getvalue()
+        # small_file_icon = img_bytes.getvalue()
        return file_icon
@@ -206,7 +146,9 @@ class AirDropUtil:
        for ip in interface.ips:
            if ip.is_IPv6 and ipv6:
-                return ipaddress.IPv6Address(ip.ip[0])  # first of (ip, flowinfo, scope_id) tuple
+                return ipaddress.IPv6Address(
                    ip.ip[0]
                )  # first of (ip, flowinfo, scope_id) tuple
            if ip.is_IPv4 and not ipv6:
                return ipaddress.IPv4Address(ip.ip)
@@ -219,8 +161,8 @@ class AirDropUtil:
        if not os.path.exists(config.debug_dir):
            os.makedirs(config.debug_dir)
        debug_file_path = os.path.join(config.debug_dir, file_name)
-        with open(debug_file_path, 'wb') as file:
+        with open(debug_file_path, "wb") as file:
-            if hasattr(data, 'read'):
+            if hasattr(data, "read"):
                file.write(data.read())
                data.seek(0)  # reset cursor position
            else:  # assume bytes-like
@@ -234,14 +176,14 @@ class AbsArchiveWrite(ArchiveWrite):
        """
        write_p = self._pointer
-        block_size = ffi.write_get_bytes_per_block(write_p)
+        block_size = write_get_bytes_per_block(write_p)
        if block_size <= 0:
            block_size = 10240  # pragma: no cover
        with new_archive_entry() as entry_p:
            entry = ArchiveEntry(None, entry_p)
            with new_archive_read_disk(path) as read_p:
-                while 1:
+                while True:
                    r = read_next_header2(read_p, entry_p)
                    if r == ARCHIVE_EOF:
                        break
@@ -249,8 +191,8 @@ class AbsArchiveWrite(ArchiveWrite):
                    read_disk_descend(read_p)
                    write_header(write_p, entry_p)
                    try:
-                        with open(entry_sourcepath(entry_p), 'rb') as f:
+                        with open(entry_sourcepath(entry_p), "rb") as f:
-                            while 1:
+                            while True:
                                data = f.read(block_size)
                                if not data:
                                    break
@@ -0,0 +1,6 @@
 black
 flake8
 flake8-bugbear
 isort
 pylint
 pytest
@@ -0,0 +1,17 @@
 [flake8]
 extend-ignore = E203, E501
 max-line-length = 80
 max-complexity = 18
 select = B9
 [isort]
 multi_line_output = 3
 include_trailing_comma = True
 force_grid_wrap = 0
 use_parentheses = True
 ensure_newline_before_comments = True
 line_length = 88
 [pylint]
 disable = C, R, W0511, W1203
 max-line-length = 88
@@ -4,42 +4,49 @@ from os.path import abspath, dirname, join
 from setuptools import find_packages, setup
 this_dir = abspath(dirname(__file__))
-with open(join(this_dir, 'README.md'), encoding='utf-8') as file:
+with open(join(this_dir, "README.md"), encoding="utf-8") as file:
    long_description = file.read()
 setup(
-    name='opendrop',
+    name="opendrop",
    version=__version__,
-    python_requires='>=3.6',
+    python_requires=">=3.6",
-    description='An open Apple AirDrop implementation',
+    description="An open Apple AirDrop implementation",
    long_description=long_description,
-    long_description_content_type='text/markdown',
+    long_description_content_type="text/markdown",
-    url='https://owlink.org',
+    url="<<DISCLAIMER: The former owlink website is no longer associated with this project, please disregard it.>>",
    project_urls={
-        'Source': 'https://github.com/seemoo-lab/opendrop',
+        "Source": "https://github.com/seemoo-lab/opendrop",
-        'Research Paper': 'https://usenix.org/conference/usenixsecurity19/presentation/stute',
+        "Research Paper": "https://usenix.org/conference/usenixsecurity19/presentation/stute",
    },
-    author='The Open Wireless Link Project',
+    author="The Open Wireless Link Project",
-    author_email='mstute@seemoo.tu-darmstadt.de',
+    author_email="mstute@seemoo.tu-darmstadt.de",
    classifiers=[
-        'License :: OSI Approved :: GNU General Public License v3 (GPLv3)',
+        "License :: OSI Approved :: GNU General Public License v3 (GPLv3)",
-        'Operating System :: MacOS',
+        "Operating System :: MacOS",
-        'Operating System :: POSIX :: Linux',
+        "Operating System :: POSIX :: Linux",
-        'Natural Language :: English',
+        "Natural Language :: English",
-        'Programming Language :: Python :: 3',
+        "Programming Language :: Python :: 3",
-        'Programming Language :: Python :: 3.6',
+        "Programming Language :: Python :: 3.6",
-        'Programming Language :: Python :: 3.7',
+        "Programming Language :: Python :: 3.7",
        "Programming Language :: Python :: 3.8",
        "Programming Language :: Python :: 3.9",
    ],
    keywords="cli",
    packages=find_packages(exclude=["docs"]),
    package_data={"opendrop": ["certs/*.pem"]},
    install_requires=[
        "Pillow",
        "fleep",
        "ifaddr",
        "libarchive-c",
        "requests",
        "requests_toolbelt",
        "zeroconf>=0.24.2",
    ],
    keywords='cli',
    packages=find_packages(exclude=['docs']),
    package_data={
        'opendrop': ['certs/*.pem']
    },
    install_requires=['requests', 'fleep', 'ifaddr', 'netifaces', 'Pillow',
                      'requests_toolbelt', 'ctypescrypto', 'libarchive-c'],
    entry_points={
-        'console_scripts': [
+        "console_scripts": [
-            'opendrop=opendrop.cli:main',
+            "opendrop=opendrop.cli:main",
        ],
    },
 )
@@ -0,0 +1,20 @@
 from opendrop.client import AirDropBrowser
 from opendrop.config import AirDropConfig
 def get_loopback():
    import ifaddr
    for adapter in ifaddr.get_adapters():
        if adapter.name.startswith("lo"):
            return adapter.name
    return None
 def test_browser_setup():
    loopback = get_loopback()
    assert loopback is not None, "Could not find loopback interface"
    config = AirDropConfig(interface=loopback)
    browser = AirDropBrowser(config)
    browser.start()
    browser.stop()
@@ -0,0 +1,21 @@
 from opendrop.server import AirDropServer
 from opendrop.config import AirDropConfig
 def get_loopback():
    import ifaddr
    for adapter in ifaddr.get_adapters():
        if adapter.name.startswith("lo"):
            return adapter.name
    return None
 def test_server_setup():
    loopback = get_loopback()
    assert loopback is not None, "Could not find loopback interface"
    config = AirDropConfig(interface=loopback)
    server = AirDropServer(config)
    server.start_service()
    # TODO currently no good way of stopping the server
    # server.start_server()
Author	SHA1	Message	Date
eickeh	11fe7ba786	Update README.md Removed link to the deprecated owlink website as it's no longer associated with this project.	2026-08-17 14:18:16 +02:00
eickeh	9075732230	Update setup.py Removed link to the deprecated owlink website as it's no longer associated with this project.	2026-08-17 14:16:23 +02:00
Alexander Heinrich	ae5ac821fb	Adding CITATION.cff file	2024-06-11 12:41:13 +02:00
Milan Stute	cbc7ca46a7	Bump version	2021-04-29 14:59:52 +02:00
Milan Stute	df221b0e2b	Fixup: autoformat	2021-04-29 14:55:39 +02:00
Milan Stute	4f1849cea2	Add sending support for URLs (fixes #67 )	2021-04-29 14:55:04 +02:00
Milan Stute	8bacbe97b0	Add PrivateDrop reference	2021-04-29 12:47:38 +02:00
Milan Stute	bc7813bf91	Bump version	2020-12-03 16:01:18 +01:00
Milan Stute	8a9bd1f4d5	Ignore LGTM false positive (again)	2020-12-02 16:33:51 +01:00
Milan Stute	ba550bb468	Don't busy wait	2020-12-02 16:33:51 +01:00
Milan Stute	17db506f04	Check output of openssl	2020-12-02 16:18:57 +01:00
Milan Stute	6960a97ab8	Don't redefine built-in types	2020-12-02 16:18:57 +01:00
Milan Stute	fe99dab664	Unused variables	2020-12-02 16:18:57 +01:00
Milan Stute	d4f3df70e7	Don't use logger.warn	2020-12-02 16:18:57 +01:00
Milan Stute	d96fa1d7ef	Use f-strings everywhere else	2020-12-02 16:18:57 +01:00
Milan Stute	bf7cea785c	Use f-strings in logging statements	2020-12-02 16:18:57 +01:00
Milan Stute	7db266f089	Rename variable	2020-12-02 16:18:57 +01:00
Milan Stute	db34b3e349	Silence pylint false positives	2020-12-02 16:18:57 +01:00
Milan Stute	368a8afc8c	Remove unused imports	2020-12-02 16:18:57 +01:00
Milan Stute	adb658d04d	Add pylint to CI pipeline	2020-12-02 16:18:57 +01:00
Milan Stute	91e204f8a2	Add isort to CI pipeline	2020-12-02 16:18:57 +01:00
Milan Stute	2f0cbe1a8f	Bump to v0.12.2	2020-12-02 12:08:25 +01:00
Milan Stute	e82ef8ac4a	Require KeyboardInterrupt to stop discovery Otherwise discovery would stop after entering key passphrase	2020-12-02 11:58:24 +01:00
Milan Stute	2f9cdc97d1	Bump version number	2020-12-02 10:39:43 +01:00
Milan Stute	b2b892ea60	Indicate Python 3.8 and 3.9 support	2020-12-02 10:25:57 +01:00
Milan Stute	439cfe1108	Remove unused OpenSSL/ctypescrypto dependency	2020-12-02 10:25:57 +01:00
Milan Stute	51246b89dd	Support AirDrop authentication by using extracted secrets (fixes #53 )	2020-12-02 10:16:28 +01:00
Milan Stute	c926eaf710	Replace yapf with black as formatter	2020-11-30 19:52:15 +01:00
Milan Stute	5e2ff4210f	Test Python 3.9	2020-11-30 19:51:09 +01:00
Milan Stute	a309c1946e	add more receiver flags	2020-06-09 21:03:47 +02:00
Milan Stute	f2c2eb3266	400 response for invalid POST URL	2020-05-28 15:00:12 +02:00
Milan Stute	bfe297e756	Suppress LGTM false positive	2020-01-09 10:13:58 +01:00
Milan Stute	44c3aa5197	Add shields to README	2019-12-19 11:40:29 +01:00
Milan Stute	f4f47c43ac	Bump to v0.11.0	2019-12-19 09:17:08 +01:00
Milan Stute	56e5a09db6	Check for virtualenv in Makefile	2019-12-19 09:06:26 +01:00
Milan Stute	369b5a8556	Clean up	2019-12-17 23:35:39 +01:00
Milan Stute	ce1ec0be2e	Rename GitHub workflows	2019-12-17 23:10:47 +01:00
Milan Stute	e251089d2c	Add test package action	2019-12-17 23:10:47 +01:00
Milan Stute	a714545fb2	Add rudimentary pytests	2019-12-17 23:10:47 +01:00
Milan Stute	3edb379a6a	Only set apple_p2p on Darwin	2019-12-17 22:59:49 +01:00
Milan Stute	fba43f561e	Fix zeroconf warning	2019-12-17 22:45:41 +01:00
Milan Stute	66b6195bff	Fix two LGTM issues	2019-12-17 20:24:53 +01:00
Milan Stute	bc724b30d5	Drop custom zeroconf package (fixes #14 )	2019-12-17 20:16:15 +01:00
Milan Stute	55feaed931	Add Makefile for development	2019-12-17 19:55:58 +01:00
Milan Stute	304c4211ad	Clean up code	2019-12-17 19:55:58 +01:00
Milan Stute	802d0d57a7	Remove netifaces dependency	2019-12-17 12:55:18 +01:00
Milan Stute	9b7fe93c30	Adopt new zeroconf API	2019-12-17 12:55:18 +01:00
Milan Stute	b2293bf309	Update zeroconf to 0.24.1 with proper AWDL support	2019-12-17 12:41:08 +01:00