refactor: Remove General Settings Debug menu and dead supporting code

app/src/test/java/eu/darken/capod/common/debug/BugsTest.kt

@@ -14,9 +14,23 @@ class BugsTest : BaseTest() {
     @AfterEach
     fun cleanup() {
         Bugs.reporter = null
+        Bugs.isDebug.value = false
         Logging.clearAll()
     }
 
+    @Test
+    fun `isDebug defaults to false`() {
+        Bugs.isDebug.value shouldBe false
+    }
+
+    @Test
+    fun `isDebug can be toggled`() {
+        Bugs.isDebug.value = true
+        Bugs.isDebug.value shouldBe true
+        Bugs.isDebug.value = false
+        Bugs.isDebug.value shouldBe false
+    }
+
     @Test
     fun `report does not throw if logging fails`() {
         Logging.clearAll()

app/src/test/java/eu/darken/capod/main/ui/overview/OverviewViewModelTest.kt

@@ -3,7 +3,7 @@ package eu.darken.capod.main.ui.overview
 import eu.darken.capod.common.TimeSource
 import eu.darken.capod.common.bluetooth.BluetoothDevice2
 import eu.darken.capod.common.bluetooth.BluetoothManager2
-import eu.darken.capod.common.debug.DebugSettings
+import eu.darken.capod.common.debug.Bugs
 import eu.darken.capod.common.permissions.Permission
 import eu.darken.capod.common.upgrade.UpgradeRepo
 import eu.darken.capod.main.core.GeneralSettings
@@ -49,7 +49,6 @@ class OverviewViewModelTest : BaseTest() {
     private lateinit var deviceMonitor: DeviceMonitor
     private lateinit var permissionTool: PermissionTool
     private lateinit var generalSettings: GeneralSettings
-    private lateinit var debugSettings: DebugSettings
     private lateinit var upgradeRepo: UpgradeRepo
     private lateinit var bluetoothManager: BluetoothManager2
     private lateinit var profilesRepo: DeviceProfilesRepo
@@ -64,7 +63,6 @@ class OverviewViewModelTest : BaseTest() {
     private lateinit var hadLegacyReactionDataFlow: MutableStateFlow<Boolean>
     private lateinit var upgradeInfoFlow: MutableStateFlow<UpgradeRepo.Info>
     private lateinit var effectiveModeFlow: MutableStateFlow<MonitorMode>
-    private lateinit var fakeDebugMode: FakeDataStoreValue<Boolean>
     private lateinit var fakeReactionsHintDismissed: FakeDataStoreValue<Boolean>
 
     @BeforeEach
@@ -79,8 +77,8 @@ class OverviewViewModelTest : BaseTest() {
         hadLegacyReactionDataFlow = MutableStateFlow(false)
         upgradeInfoFlow = MutableStateFlow(mockk<UpgradeRepo.Info>(relaxed = true))
         effectiveModeFlow = MutableStateFlow(MonitorMode.AUTOMATIC)
-        fakeDebugMode = FakeDataStoreValue(false)
         fakeReactionsHintDismissed = FakeDataStoreValue(false)
+        Bugs.isDebug.value = false
 
         monitorControl = mockk(relaxed = true)
 
@@ -103,10 +101,6 @@ class OverviewViewModelTest : BaseTest() {
             every { it.effectiveMode } returns effectiveModeFlow
         }
 
-        debugSettings = mockk<DebugSettings>().also {
-            every { it.isDebugModeEnabled } returns fakeDebugMode.mock
-        }
-
         upgradeRepo = mockk<UpgradeRepo>().also {
             every { it.upgradeInfo } returns upgradeInfoFlow
         }
@@ -125,6 +119,7 @@ class OverviewViewModelTest : BaseTest() {
     @AfterEach
     fun teardown() {
         Dispatchers.resetMain()
+        Bugs.isDebug.value = false
     }
 
     private fun createViewModel() = OverviewViewModel(
@@ -133,7 +128,6 @@ class OverviewViewModelTest : BaseTest() {
         deviceMonitor = deviceMonitor,
         permissionTool = permissionTool,
         generalSettings = generalSettings,
-        debugSettings = debugSettings,
         upgradeRepo = upgradeRepo,
         bluetoothManager = bluetoothManager,
         profilesRepo = profilesRepo,
@@ -152,7 +146,7 @@ class OverviewViewModelTest : BaseTest() {
 
             state.permissions shouldBe emptySet()
             state.devices shouldBe emptyList()
-            state.isDebugMode shouldBe false
+            state.isDebug shouldBe false
             state.isBluetoothEnabled shouldBe true
             state.showUnmatchedDevices shouldBe false
         }
@@ -195,7 +189,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = listOf(profiled, unmatched),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = mockk(relaxed = true),
@@ -222,7 +216,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = listOf(profiled, unmatched),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = mockk(relaxed = true),
@@ -242,7 +236,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = emptyList(),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = upgradeInfo,
@@ -264,7 +258,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = listOf(profiled),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = upgradeInfo,
@@ -288,7 +282,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = listOf(device1, device2, device3),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = upgradeInfo,
@@ -312,7 +306,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = listOf(device1, device2, device3),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = upgradeInfo,
@@ -336,7 +330,7 @@ class OverviewViewModelTest : BaseTest() {
                 now = java.time.Instant.now(),
                 permissions = emptySet(),
                 devices = listOf(profiled1, profiled2, unmatched),
-                isDebugMode = false,
+                isDebug = false,
                 isBluetoothEnabled = true,
                 profiles = emptyList(),
                 upgradeInfo = upgradeInfo,

app/src/test/java/eu/darken/capod/monitor/core/ble/BlePodMonitorTest.kt

@@ -5,7 +5,6 @@ import eu.darken.capod.common.bluetooth.BleScanResult
 import eu.darken.capod.common.bluetooth.BleScanner
 import eu.darken.capod.common.bluetooth.BluetoothManager2
 import eu.darken.capod.common.bluetooth.ScannerMode
-import eu.darken.capod.common.debug.DebugSettings
 import eu.darken.capod.common.permissions.Permission
 import eu.darken.capod.main.core.GeneralSettings
 import eu.darken.capod.main.core.PermissionTool
@@ -107,9 +106,6 @@ class BlePodMonitorTest : BaseTest() {
             every { isOffloadedFilteringDisabled } returns FakeDataStoreValue(false).mock
             every { useIndirectScanResultCallback } returns FakeDataStoreValue(false).mock
         }
-        val debugSettings = mockk<DebugSettings>().apply {
-            every { showUnfiltered } returns FakeDataStoreValue(false).mock
-        }
         val permissionTool = mockk<PermissionTool>().apply {
             every { missingScanPermissions } returns MutableStateFlow<Set<Permission>>(emptySet())
             every { recheck() } just Runs
@@ -131,7 +127,6 @@ class BlePodMonitorTest : BaseTest() {
                 timeSource = timeSource,
                 generalSettings = generalSettings,
                 bluetoothManager = bluetoothManager,
-                debugSettings = debugSettings,
                 permissionTool = permissionTool,
                 profilesRepo = profilesRepo,
             ),