TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 22:56:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace dynamic_cast with down_cast

Browse Source 
PiperOrigin-RevId: 654066599
This commit is contained in:
hai007
2024-07-19 11:17:05 -07:00
committed by Copybara-Service
parent d576caa4f3
commit 09094110c8
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
connections/implementation/mediums/bluetooth_classic.cc
+5 -4
View File
@@ -29,6 +29,7 @@
#include "internal/platform/logging.h"
#include "internal/platform/mutex_lock.h"
#include "internal/platform/socket.h"
#include "internal/platform/types.h"
#include "internal/platform/uuid.h"
namespace nearby {
@@ -378,7 +379,7 @@ bool BluetoothClassic::StartAcceptingConnections(
MediumSocket* virtual_socket) mutable {
if (callback) {
callback(listening_service_id,
*(dynamic_cast<BluetoothSocket*>(virtual_socket)));
*(down_cast<BluetoothSocket*>(virtual_socket)));
}
});
}
@@ -417,7 +418,7 @@ bool BluetoothClassic::StartAcceptingConnections(
if (callback) {
callback(
service_id,
*(dynamic_cast<BluetoothSocket*>(
*(down_cast<BluetoothSocket*>(
multiplex_socket->GetVirtualSocket(service_id))));
callback_called = true;
}
@@ -505,7 +506,7 @@ BluetoothSocket BluetoothClassic::Connect(BluetoothDevice& bluetooth_device,
multiplex_socket->EstablishVirtualSocket(service_id);
// Should not happen.
auto* bluetooth_socket =
dynamic_cast<BluetoothSocket*>(virtual_socket);
down_cast<BluetoothSocket*>(virtual_socket);
if (bluetooth_socket == nullptr) {
NEARBY_LOGS(INFO)
<< "Failed to cast to BluetoothSocket for " << service_id
@@ -591,7 +592,7 @@ BluetoothSocket BluetoothClassic::AttemptToConnect(
MultiplexSocket::CreateOutgoingSocket(&socket, service_id);
auto* virtual_socket = multiplex_socket->GetVirtualSocket(service_id);
// Should not happen.
auto* bluetooth_socket = dynamic_cast<BluetoothSocket*>(virtual_socket);
auto* bluetooth_socket = down_cast<BluetoothSocket*>(virtual_socket);
if (bluetooth_socket == nullptr) {
NEARBY_LOGS(INFO) << "Failed to cast to BluetoothSocket for "
<< service_id << " with " << bluetooth_device.GetName();
connections/implementation/mediums/multiplex/multiplex_socket.cc
+2 -1
View File
@@ -38,6 +38,7 @@
#include "internal/platform/mutex.h"
#include "internal/platform/mutex_lock.h"
#include "internal/platform/socket.h"
#include "internal/platform/types.h"
#include "proto/connections_enums.pb.h"
namespace nearby {
@@ -692,7 +693,7 @@ MediumSocket* MultiplexSocket::ReMapAndGetVirtualSocket(
MutexLock lock(&virtual_socket_mutex_);
for (auto& [hash_key, virtual_socket] : virtual_sockets_) {
auto output_stream =
dynamic_cast<MultiplexOutputStream::VirtualOutputStream*>(
down_cast<MultiplexOutputStream::VirtualOutputStream*>(
&(virtual_socket->GetOutputStream()));
if (output_stream == nullptr) {
continue;