TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-16 15:36:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Clean up fetcher test

Browse Source 
PiperOrigin-RevId: 526757011
This commit is contained in:
Janusz Sobczak
2023-04-24 14:35:11 -07:00
committed by Copybara-Service
parent 70bcabb161
commit 0e9d578e42
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fastpair/repository/fast_pair_metadata_fetcher_impl_test.cc
+4 -14
View File
@@ -26,7 +26,6 @@
#include "absl/status/statusor.h"
#include "absl/strings/string_view.h"
#include "fastpair/internal/test/fast_pair_fake_http_client.h"
#include "internal/network/http_client.h"
namespace nearby {
namespace fastpair {
@@ -41,11 +40,6 @@ constexpr char kRequestUrl[] = "https://googleapis.com/nearbysharing/test";
constexpr char kQueryParameterAlternateOutputKey[] = "alt";
constexpr char kQueryParameterAlternateOutputProto[] = "proto";
class MockHttpClient : public network::HttpClient {
public:
~MockHttpClient() override = default;
};
const FastPairMetadataFetcher::QueryParameters&
GetTestRequestProtoAsQueryParameters() {
static const FastPairMetadataFetcher::QueryParameters*
@@ -130,11 +124,9 @@ class FastPairMetadataFetcherImplTest : public ::testing::Test {
void CheckFastPairRepositoryGetUnauthRequest(
const FastPairMetadataFetcher::QueryParameters&
request_as_query_parameters) {
FastPairFakeHttpClient* fake_http_client =
reinterpret_cast<FastPairFakeHttpClient*>(http_client_.get());
EXPECT_EQ(fake_http_client->GetPendingRequest().size(), 1);
EXPECT_EQ(http_client_->GetPendingRequest().size(), 1);
const network::HttpRequest& request =
fake_http_client->GetPendingRequest()[0].request;
http_client_->GetPendingRequest()[0].request;
CheckPlatformTypeHeader(request.GetAllHeaders());
@@ -154,16 +146,14 @@ class FastPairMetadataFetcherImplTest : public ::testing::Test {
int error,
std::optional<network::HttpStatusCode> response_code = std::nullopt,
const std::optional<std::string>& response_string = std::nullopt) {
FastPairFakeHttpClient* client =
reinterpret_cast<FastPairFakeHttpClient*>(http_client_.get());
client->CompleteRequest(error, response_code, response_string);
http_client_->CompleteRequest(error, response_code, response_string);
EXPECT_TRUE(result_ || network_error_);
}
std::unique_ptr<std::string> result_;
std::unique_ptr<FastPairHttpError> network_error_;
private:
std::unique_ptr<network::HttpClient> http_client_;
std::unique_ptr<FastPairFakeHttpClient> http_client_;
FastPairMetadataFetcherImpl flow_{api::DeviceInfo::OsType::kChromeOs};
};