TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 22:56:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixes memory leak in AnalyticsRecorder.

Browse Source 
PiperOrigin-RevId: 393905139
This commit is contained in:
edwinwu
2021-08-30 19:42:32 -07:00
committed by Copybara-Service
parent f37dfd2e8a
commit 15a81bb0bf
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpp/analytics/analytics_recorder.cc
+3 -5
View File
@@ -284,7 +284,7 @@ void AnalyticsRecorder::OnOutgoingConnectionAttempt(
std::unique_ptr<ConnectionRequest> &connection_request = pair.mapped();
connection_request->set_local_response(NOT_SENT);
connection_request->set_remote_response(NOT_SENT);
UpdateDiscovererConnectionRequestLocked(connection_request.release());
UpdateDiscovererConnectionRequestLocked(connection_request.get());
}
}
}
@@ -453,8 +453,7 @@ bool AnalyticsRecorder::UpdateAdvertiserConnectionRequestLocked(
request->set_duration_millis(
absl::ToUnixMillis(SystemClock::ElapsedRealtime()) -
request->duration_millis());
*current_advertising_phase_->add_received_connection_request() =
*std::move(request);
*current_advertising_phase_->add_received_connection_request() = *request;
return true;
}
return false;
@@ -472,8 +471,7 @@ bool AnalyticsRecorder::UpdateDiscovererConnectionRequestLocked(
request->set_duration_millis(
absl::ToUnixMillis(SystemClock::ElapsedRealtime()) -
request->duration_millis());
*current_discovery_phase_->add_sent_connection_request() =
*std::move(request);
*current_discovery_phase_->add_sent_connection_request() = *request;
return true;
}
return false;