TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 14:46:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix threading issues in GNCTimerTest.

Browse Source 
PiperOrigin-RevId: 810693891
This commit is contained in:
Edwin Wu
2025-09-23 20:57:23 -07:00
committed by Copybara-Service
parent 56148e3b86
commit 19dc77a78f
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/platform/implementation/apple/Tests/GNCTimerTest.mm
+18 -10
View File
@@ -16,6 +16,7 @@
#import <XCTest/XCTest.h>
#include <atomic>
#include <memory>
@interface GNCTimerTest : XCTestCase
@@ -34,8 +35,12 @@
bool fired = false;
XCTAssertTrue(timer->Create(10, 0, [&]() {
fired = true;
[expectation fulfill];
dispatch_async(dispatch_get_main_queue(), ^{
if (!fired) {
fired = true;
[expectation fulfill];
}
});
}));
[self waitForExpectationsWithTimeout:1.0 handler:nil];
@@ -59,17 +64,18 @@
XCTestExpectation* expectation = [self expectationWithDescription:@"Timer fired twice"];
auto timer = std::make_unique<nearby::apple::Timer>();
int fireCount = 0;
std::atomic<int> fireCount = 0;
XCTAssertTrue(timer->Create(10, 10, [&]() {
fireCount++;
if (fireCount == 2) {
[expectation fulfill];
if (fireCount.fetch_add(1) == 1) {
dispatch_async(dispatch_get_main_queue(), ^{
[expectation fulfill];
});
}
}));
[self waitForExpectationsWithTimeout:1.0 handler:nil];
XCTAssertEqual(fireCount, 2);
XCTAssertTrue(timer->Stop());
XCTAssertEqual(fireCount.load(), 2);
}
- (void)testRestart {
@@ -102,9 +108,11 @@
auto timer = std::make_unique<nearby::apple::Timer>();
bool fired = false;
XCTAssertTrue(timer->Create(1000, 0, [&]() {
fired = true;
[expectation fulfill];
XCTAssertTrue(timer->Create(1000, 0, [&]() {
dispatch_async(dispatch_get_main_queue(), ^{
fired = true;
[expectation fulfill];
});
}));
XCTAssertTrue(timer->FireNow());