Merge logging and types build targets

Both "types" and "logging" build targets included "logging.h"
Merging them together avoids circular dependencies.

PiperOrigin-RevId: 555262816
This commit is contained in:
Janusz Sobczak
2023-08-09 19:13:12 -07:00
committed by Copybara-Service
parent d19f21ed71
commit 5393daf9f1
30 changed files with 23 additions and 74 deletions
-2
View File
@@ -35,7 +35,6 @@ cc_library(
"//internal/analytics:event_logger",
"//internal/interop:device",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/time",
@@ -102,7 +101,6 @@ cc_test(
"//connections/implementation:internal_test",
"//connections/v3:v3_types",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
"@com_github_protobuf_matchers//protobuf-matchers",
+1 -1
View File
@@ -119,7 +119,7 @@ cc_test(
],
deps = [
"//connections:core",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation/windows",
"@com_github_protobuf_matchers//protobuf-matchers",
"@com_google_googletest//:gtest_main",
-2
View File
@@ -126,7 +126,6 @@ cc_library(
"//internal/platform:comm",
"//internal/platform:connection_info",
"//internal/platform:error_code_recorder",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:util",
"//internal/platform/implementation:comm",
@@ -236,7 +235,6 @@ cc_test(
"//internal/interop:device",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
@@ -31,7 +31,6 @@ cc_library(
"//connections:core_types",
"//internal/analytics:event_logger",
"//internal/platform:error_code_recorder",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation:types",
"//internal/proto/analytics:connections_log_cc_proto",
@@ -61,7 +60,6 @@ cc_test(
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:error_code_recorder",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
"//internal/proto/analytics:connections_log_cc_proto",
-1
View File
@@ -55,7 +55,6 @@ cc_library(
"//internal/platform:base",
"//internal/platform:cancellation_flag",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:uuid",
"//proto/mediums:web_rtc_signaling_frames_cc_proto",
@@ -45,7 +45,6 @@ cc_library(
"//internal/flags:nearby_flags",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:util",
"//internal/platform:uuid",
@@ -39,7 +39,6 @@ cc_library(
"//connections/implementation/mediums:utils",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//proto/mediums:web_rtc_signaling_frames_cc_proto",
# TODO: Support WebRTC
-1
View File
@@ -134,7 +134,6 @@ cc_test(
"//fastpair/plugins:fake_fast_pair_plugin",
"//internal/account:test_support",
"//internal/network:types",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
+1 -1
View File
@@ -33,7 +33,7 @@ cc_library(
deps = [
"//fastpair/proto:fastpair_cc_proto",
"//internal/crypto_cros",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/preferences",
"@com_google_absl//absl/base:core_headers",
"@com_google_absl//absl/container:flat_hash_map",
+1 -1
View File
@@ -21,7 +21,7 @@ cc_library(
"//fastpair/common",
"//internal/base:bluetooth_address",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:types",
"@boringssl//:crypto",
"@com_google_absl//absl/log:check",
],
+1 -1
View File
@@ -17,7 +17,7 @@ cc_library(
"//fastpair/crypto",
"//internal/base:bluetooth_address",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/functional:any_invocable",
"@com_google_absl//absl/strings",
],
-3
View File
@@ -43,7 +43,6 @@ cc_library(
"//fastpair/repository",
"//internal/base:bluetooth_address",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:uuid",
"@boringssl//:crypto",
@@ -89,7 +88,6 @@ cc_test(
"//fastpair/internal/mediums",
"//fastpair/repository:test_support",
"//fastpair/testing",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
"@com_github_protobuf_matchers//protobuf-matchers",
@@ -164,7 +162,6 @@ cc_test(
":handshake",
"//fastpair/common",
"//fastpair/internal/mediums",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
-1
View File
@@ -37,7 +37,6 @@ cc_library(
deps = [
"//fastpair/common",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation:comm",
"@com_google_absl//absl/base:core_headers",
-4
View File
@@ -60,7 +60,6 @@ cc_library(
"//fastpair/common",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform:uuid",
@@ -106,7 +105,6 @@ cc_library(
":message_stream",
"//fastpair/common",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"@com_google_absl//absl/status",
@@ -128,7 +126,6 @@ cc_test(
":message_stream",
"//fastpair/common",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
@@ -153,7 +150,6 @@ cc_test(
":message_stream",
"//fastpair/common",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform/implementation:types",
+2 -2
View File
@@ -37,7 +37,7 @@ cc_library(
deps = [
":fastpair_cc_proto",
"//fastpair/common",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/strings",
"@nlohmann_json//:json",
],
@@ -57,7 +57,7 @@ cc_library(
":fastpair_cc_proto",
"//fastpair/common",
"//fastpair/repository",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/time",
],
)
-2
View File
@@ -42,7 +42,6 @@ cc_library(
"//fastpair/proto:proto_builder",
"//fastpair/server_access",
"//internal/base",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/status",
"@com_google_absl//absl/strings",
@@ -62,7 +61,6 @@ cc_library(
deps = [
"//fastpair/common",
"//internal/base",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/functional:any_invocable",
],
+1 -1
View File
@@ -65,8 +65,8 @@ cc_test(
"//internal/base:bluetooth_address",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
"@com_github_protobuf_matchers//protobuf-matchers",
"@com_google_absl//absl/status",
-1
View File
@@ -33,7 +33,6 @@ cc_library(
"//fastpair/repository:device_repository",
"//fastpair/scanning/fastpair:scanning",
"//internal/base",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/functional:bind_front",
],
-1
View File
@@ -41,7 +41,6 @@ cc_library(
"//internal/base",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/functional:any_invocable",
"@com_google_absl//absl/functional:bind_front",
-1
View File
@@ -36,7 +36,6 @@ cc_library(
"//internal/auth:types",
"//internal/base",
"//internal/network:types",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
+1 -1
View File
@@ -37,7 +37,7 @@ cc_library(
"//fastpair/common",
"//fastpair/repository",
"//internal/base",
"//internal/platform:logging",
"//internal/platform:types",
"@com_google_absl//absl/functional:any_invocable",
"@com_google_absl//absl/strings",
],
+1 -1
View File
@@ -15,7 +15,7 @@ cc_library(
"memory_data_set.h",
],
deps = [
"//internal/platform:logging",
"//internal/platform:types",
"//third_party/leveldb:db",
"//third_party/leveldb:table",
"//third_party/leveldb:util",
-1
View File
@@ -55,7 +55,6 @@ cc_library(
],
deps = [
":types",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation:platform",
"@com_google_absl//absl/base:core_headers",
+8 -31
View File
@@ -94,31 +94,6 @@ cc_library(
],
)
cc_library(
name = "logging",
hdrs = [
"logging.h",
],
copts = ["-DCORE_ADAPTER_DLL"],
visibility = [
"//connections:__subpackages__",
"//fastpair:__subpackages__",
"//internal/auth:__subpackages__",
"//internal/auth/credential_store:__subpackages__",
"//internal/data:__subpackages__",
"//internal/network:__subpackages__",
"//internal/platform:__subpackages__",
"//internal/proto/analytics:__subpackages__",
"//location/nearby/analytics/cpp:__subpackages__",
"//presence:__subpackages__",
],
deps = [
"//internal/platform/implementation:platform",
"//internal/platform/implementation:types",
"@com_google_glog//:glog",
],
)
cc_library(
name = "cancellation_flag",
srcs = [
@@ -161,7 +136,7 @@ cc_library(
"//presence:__subpackages__",
],
deps = [
":logging",
":types",
"//proto:connections_enums_cc_proto",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
@@ -182,7 +157,7 @@ cc_library(
],
visibility = ["//connections/implementation:__subpackages__"],
deps = [
":logging",
":types",
"//proto:connections_enums_cc_proto",
"//proto/errorcode:error_code_enums_cc_proto",
"@com_google_absl//absl/functional:any_invocable",
@@ -227,7 +202,6 @@ cc_library(
],
deps = [
":base",
":logging",
":types",
":uuid",
"//internal/base",
@@ -355,15 +329,21 @@ cc_library(
"//connections:__subpackages__",
"//fastpair:__subpackages__",
"//internal/account:__subpackages__",
"//internal/auth:__subpackages__",
"//internal/auth/credential_store:__subpackages__",
"//internal/base:__subpackages__",
"//internal/data:__subpackages__",
"//internal/flags:__subpackages__",
"//internal/interop:__pkg__",
"//internal/network:__subpackages__",
"//internal/platform:__subpackages__",
"//internal/platform/implementation/g3:__pkg__",
"//internal/platform/implementation/windows:__subpackages__",
"//internal/preferences:__subpackages__",
"//internal/proto/analytics:__subpackages__",
"//internal/test:__subpackages__",
"//internal/weave:__subpackages__",
"//location/nearby/analytics/cpp:__subpackages__",
"//location/nearby/cpp:__subpackages__",
"//location/nearby/testing/nearby_native:__subpackages__",
"//presence:__subpackages__",
@@ -371,7 +351,6 @@ cc_library(
],
deps = [
":base",
":logging",
":util",
"//internal/crypto_cros",
"//internal/platform/implementation:platform",
@@ -427,7 +406,6 @@ cc_library(
deps = [
":base",
":cancellation_flag",
":logging",
":types",
":uuid",
"//internal/base",
@@ -488,7 +466,6 @@ cc_test(
":base",
":comm",
":connection_info",
":logging",
":test_util",
":types",
":uuid",
+1 -2
View File
@@ -44,8 +44,8 @@ cc_library(
deps = [
":preferences_repository",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform:util",
"//internal/platform/implementation:types",
"//internal/platform/implementation/shared:count_down_latch",
@@ -103,7 +103,6 @@ cc_library(
"@com_google_absl//absl/synchronization",
"//internal/platform:base",
"//internal/platform:cancellation_flag",
"//internal/platform:logging",
"//internal/platform:test_util",
"//internal/platform:types",
"//internal/platform:uuid",
@@ -50,7 +50,6 @@ cc_library(
"//base:stringprintf",
"//internal/base:bluetooth_address",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:uuid",
"//internal/platform/implementation:types",
@@ -205,7 +204,6 @@ cc_library(
"//internal/platform:base",
"//internal/platform:cancellation_flag",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:uuid",
"//internal/platform/flags:platform_flags",
@@ -286,7 +284,7 @@ cc_test(
":types",
":windows",
"//internal/platform:base",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation:comm",
"//internal/platform/implementation:platform",
"//internal/platform/implementation:types",
+1 -1
View File
@@ -64,7 +64,7 @@ cc_test(
shard_count = 16,
deps = [
":connections_log_cc_proto",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation/g3", # build_cleaner: keep
"//proto:connections_enums_cc_proto",
"@com_github_protobuf_matchers//protobuf-matchers",
+2 -2
View File
@@ -91,7 +91,7 @@ cc_library(
"//internal/interop:device",
"//internal/platform:base",
"//internal/platform:connection_info",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform/implementation:types",
"//internal/proto:credential_cc_proto",
"//internal/proto:metadata_cc_proto",
@@ -122,7 +122,7 @@ cc_test(
":types",
"//connections/implementation/proto:offline_wire_formats_cc_proto",
"//internal/platform:connection_info",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/proto:credential_cc_proto",
"//internal/proto:metadata_cc_proto",
"@com_github_protobuf_matchers//protobuf-matchers",
+1 -1
View File
@@ -24,7 +24,7 @@ cc_library(
"//presence:__subpackages__",
],
deps = [
"//internal/platform:logging",
"//internal/platform:types",
"//presence:types",
"//presence/fpp/fpp_c_ffi",
"//presence/implementation:sensor_fusion",
-1
View File
@@ -87,7 +87,6 @@ cc_library(
"//internal/crypto_cros",
"//internal/platform:base",
"//internal/platform:comm",
"//internal/platform:logging",
"//internal/platform:types",
"//internal/platform:uuid",
"//internal/platform/implementation:comm",