TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 14:46:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix dangling string_view UAF.

Browse Source 
PiperOrigin-RevId: 915643410
This commit is contained in:
Francis Tsui
2026-05-14 15:25:51 -07:00
committed by Copybara-Service
parent 7d84d08619
commit 6a70c3d49b
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sharing/nearby_sharing_service_impl.cc
+3 -4
View File
@@ -2258,16 +2258,15 @@ void NearbySharingServiceImpl::OnIncomingAdvertisementDecoded(
// data to lambda.
GetCertificateManager()->GetDecryptedPublicCertificate(
std::move(encrypted_metadata_key),
[this, endpoint_id, advertisement_copy = *advertisement,
placeholder_share_target_id](
[this, endpoint_id = std::string(endpoint_id),
advertisement_copy = *advertisement, placeholder_share_target_id](
std::optional<NearbyShareDecryptedPublicCertificate>
decrypted_public_certificate) {
RunOnNearbySharingServiceThread(
"incoming_decrypted_certificate",
// capture endpoint_id string_view as a std::string to ensure the
// data does not go out of scope.
[this, endpoint_id = std::string(endpoint_id), advertisement_copy,
placeholder_share_target_id,
[this, endpoint_id, advertisement_copy, placeholder_share_target_id,
decrypted_public_certificate =
std::move(decrypted_public_certificate)]() {
OnIncomingDecryptedCertificate(endpoint_id, advertisement_copy,