TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-16 15:36:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix send text

Browse Source 
PiperOrigin-RevId: 645516517
This commit is contained in:
Francis Tsui
2024-06-21 15:21:54 -07:00
committed by Copybara-Service
parent 29099eed43
commit 8ba443c7dc
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sharing/nearby_sharing_service_impl.cc
+1 -1
View File
@@ -746,7 +746,7 @@ void NearbySharingServiceImpl::SendAttachments(
}
for (const FileAttachment& attachment :
attachment_container->GetFileAttachments()) {
if (!attachment.file_path()) {
if (!attachment.file_path() || attachment.file_path()->empty()) {
NL_LOG(WARNING) << __func__ << ": Got file attachment without path";
std::move(status_codes_callback)(StatusCodes::kInvalidArgument);
return;
sharing/nearby_sharing_service_impl_test.cc
+12
View File
@@ -3621,6 +3621,18 @@ TEST_P(NearbySharingServiceImplSendFailureTest, SendTextRemoteFailure) {
UnregisterSendSurface(&transfer_callback);
}
TEST_F(NearbySharingServiceImplTest, SendFileWithEmptyPath) {
MockTransferUpdateCallback transfer_callback;
MockShareTargetDiscoveredCallback discovery_callback;
int64_t target_id =
DiscoverShareTarget(transfer_callback, discovery_callback);
EXPECT_EQ(SendAttachments(target_id, CreateFileAttachments({""})),
NearbySharingServiceImpl::StatusCodes::kInvalidArgument);
UnregisterSendSurface(&transfer_callback);
}
TEST_P(NearbySharingServiceImplSendFailureTest, SendFilesRemoteFailure) {
MockTransferUpdateCallback transfer_callback;
MockShareTargetDiscoveredCallback discovery_callback;