[fp-rs] Fixing Presubmit Lint warnings for windows/ C++ files.

This commit is contained in:
Lucas Silva Shepard
2023-08-15 15:24:33 -07:00
parent 41be4cca57
commit bdc109324b
7 changed files with 15 additions and 11 deletions
@@ -18,7 +18,7 @@
// clang-format off
#include "generated_plugin_registrant.h"
#include "./generated_plugin_registrant.h"
void RegisterPlugins(flutter::PluginRegistry* registry) {
@@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
#include "flutter_window.h"
#include "./flutter_window.h"
#include <optional>
@@ -20,7 +20,7 @@
#include <memory>
#include "win32_window.h"
#include "./win32_window.h"
// A window that does nothing but host a Flutter view.
class FlutterWindow : public Win32Window {
+2 -2
View File
@@ -16,8 +16,8 @@
#include <flutter/flutter_view_controller.h>
#include <windows.h>
#include "flutter_window.h"
#include "utils.h"
#include "./flutter_window.h"
#include "./utils.h"
int APIENTRY wWinMain(_In_ HINSTANCE instance, _In_opt_ HINSTANCE prev,
_In_ wchar_t *command_line, _In_ int show_command) {
+4 -1
View File
@@ -12,10 +12,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.
//{{NO_DEPENDENCIES}}
// {{NO_DEPENDENCIES}}
// Microsoft Visual C++ generated include file.
// Used by Runner.rc
//
#ifndef RUNNER_RESOURCE_H_
#define RUNNER_RESOURCE_H_
#define IDI_APP_ICON 101
// Next default values for new objects
@@ -28,3 +30,4 @@
#define _APS_NEXT_SYMED_VALUE 101
#endif
#endif
#endif // RUNNER_RESOURCE_H_
+2 -2
View File
@@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
#include "utils.h"
#include "./utils.h"
#include <flutter_windows.h>
#include <io.h>
@@ -62,7 +62,7 @@ std::string Utf8FromUtf16(const wchar_t* utf16_string) {
int target_length = ::WideCharToMultiByte(
CP_UTF8, WC_ERR_INVALID_CHARS, utf16_string,
-1, nullptr, 0, nullptr, nullptr)
-1; // remove the trailing null character
-1; // remove the trailing null character
int input_length = (int)wcslen(utf16_string);
std::string utf8_string;
if (target_length <= 0 || target_length > utf8_string.max_size()) {
@@ -12,12 +12,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.
#include "win32_window.h"
#include "./win32_window.h"
#include <dwmapi.h>
#include <flutter_windows.h>
#include "resource.h"
#include "./resource.h"
namespace {
@@ -38,7 +38,8 @@ constexpr const wchar_t kWindowClassName[] = L"FLUTTER_RUNNER_WIN32_WINDOW";
/// value indicates apps should use light mode.
constexpr const wchar_t kGetPreferredBrightnessRegKey[] =
L"Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize";
constexpr const wchar_t kGetPreferredBrightnessRegValue[] = L"AppsUseLightTheme";
constexpr const wchar_t kGetPreferredBrightnessRegValue[] =
L"AppsUseLightTheme";
// The number of Win32Window objects that currently exist.
static int g_active_window_count = 0;