TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 22:56:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix unsigned underflow OOB read on empty cert_id.

Browse Source 
PiperOrigin-RevId: 914584854
This commit is contained in:
Francis Tsui
2026-05-12 18:42:16 -07:00
committed by Copybara-Service
parent 3dae0f119e
commit c4e4b04527
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sharing/certificates/nearby_share_certificate_manager_impl.cc
+3 -7
View File
@@ -186,11 +186,7 @@ void DumpCertificateId(std::stringstream& sstream, absl::string_view cert_id,
} else {
sstream << " Private certificates:[";
}
for (int i = 0; i < cert_id.size() - 1; ++i) {
sstream << static_cast<int>(static_cast<int8_t>(cert_id[i])) << ", ";
}
sstream << static_cast<int>(static_cast<int8_t>(cert_id[cert_id.size() - 1]))
<< "]" << std::endl;
sstream << absl::BytesToHexString(cert_id) << "]" << std::endl;
}
} // namespace
@@ -755,7 +751,7 @@ std::string NearbyShareCertificateManagerImpl::Dump() const {
certificate_storage_->GetPublicCertificateIds();
sstream << " Total count:" << ids.size() << std::endl;
for (const auto& id : ids) {
DumpCertificateId(sstream, id, true);
DumpCertificateId(sstream, id, /*is_public_cert=*/true);
}
sstream << std::endl;
@@ -768,7 +764,7 @@ std::string NearbyShareCertificateManagerImpl::Dump() const {
sstream << " Total count:" << private_certs.size() << std::endl;
for (const auto& cert : private_certs) {
std::string id(cert.id().begin(), cert.id().end());
DumpCertificateId(sstream, id, false);
DumpCertificateId(sstream, id, /*is_public_cert=*/false);
}
}