Internal change

PiperOrigin-RevId: 359161492

cpp/core/internal/base_pcp_handler_test.cc

@@ -658,7 +658,6 @@ TEST_P(BasePcpHandlerTest, DestructorIsCalledOnProtocolEndpoint) {
     channel_b->Close();
     bwu.Shutdown();
     pcp_handler.DisconnectFromEndpointManager();
-    bwu.Shutdown();
   }
   EXPECT_EQ(destroyed_flag.load(), mediums_count);
   env_.Stop();

cpp/core/internal/mediums/BUILD

@@ -68,7 +68,6 @@ cc_library(
     visibility = [
         "//core/internal:__pkg__",
         "//core/internal/mediums:__pkg__",
-        "//core/internal/mediums/ble_v2:__pkg__",
         "//core/internal/mediums/webrtc:__pkg__",
     ],
     deps = [

cpp/core/internal/mediums/webrtc.cc

@@ -458,6 +458,13 @@ void WebRtc::SendOffer(const std::string& service_id,
   }
 
   SessionDescriptionWrapper offer = connection_flow->CreateOffer();
+  if (!offer.IsValid()) {
+    NEARBY_LOG(INFO,
+               "Unable to send offer. Failed to create our offer locally.");
+    RemoveConnectionFlow(remote_peer_id);
+    return;
+  }
+
   const webrtc::SessionDescriptionInterface& sdp = offer.GetSdp();
   if (!connection_flow->SetLocalSessionDescription(std::move(offer))) {
     NEARBY_LOG(INFO,
@@ -510,6 +517,13 @@ void WebRtc::SendAnswer(const PeerId& remote_peer_id) {
   }
 
   SessionDescriptionWrapper answer = entry->second->CreateAnswer();
+  if (!answer.IsValid()) {
+    NEARBY_LOG(INFO,
+               "Unable to send answer. Failed to create our answer locally.");
+    RemoveConnectionFlow(remote_peer_id);
+    return;
+  }
+
   const webrtc::SessionDescriptionInterface& sdp = answer.GetSdp();
   if (!entry->second->SetLocalSessionDescription(std::move(answer))) {
     NEARBY_LOG(INFO,

cpp/platform/base/BUILD

@@ -68,7 +68,6 @@ cc_library(
         "byte_utils.h",
     ],
     visibility = [
-        "//googlemac/iPhone/Shared/Nearby/Connections:__subpackages__",
         "//core:__subpackages__",
         "//platform/impl:__subpackages__",
         "//platform/public:__pkg__",

cpp/platform/impl/ios/BUILD

@@ -51,11 +51,7 @@ objc_library(
     srcs = [
         "platform.mm",
     ],
-    visibility = [
-        "//googlemac/iPhone/Shared/Nearby/Connections:__subpackages__",
-        "//core:__subpackages__",
-        "//platform:__subpackages__",
-    ],
+    visibility = ["//platform:__subpackages__"],
     deps = [
         ":types",
         "//platform/api:comm",

cpp/platform/public/BUILD

@@ -96,7 +96,6 @@ cc_library(
         "logging.h",
     ],
     visibility = [
-        "//googlemac/iPhone/Shared/Nearby/Connections:__subpackages__",
         "//core:__subpackages__",
         "//platform:__subpackages__",
     ],

proto/bootstrap_enums.proto

@@ -16,6 +16,8 @@ syntax = "proto2";
 
 package location.nearby.proto;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
 option (logs_proto.file_not_used_for_logging_except_enums) = true;
 option java_api_version = 2;

proto/connections_enums.proto

@@ -16,7 +16,11 @@ syntax = "proto2";
 
 package location.nearby.proto.connections;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
+option (logs_proto.file_not_used_for_logging_except_enums) = true;
+option java_api_version = 2;
 option java_package = "com.google.location.nearby.proto";
 option java_outer_classname = "ConnectionsEnums";
 option objc_class_prefix = "GNCP";

proto/discovery_enums.proto

@@ -16,7 +16,12 @@ syntax = "proto2";
 
 package location.nearby.proto;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
+option jspb_use_correct_proto2_semantics = false;  // go/jspb-correct-proto2
+option (logs_proto.file_not_used_for_logging_except_enums) = true;
+option java_api_version = 2;
 option java_package = "com.google.location.nearby.proto";
 option java_outer_classname = "DiscoveryEnums";
 

proto/magic_pair_enums.proto

@@ -16,6 +16,8 @@ syntax = "proto2";
 
 package location.nearby.proto;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
 option (logs_proto.file_not_used_for_logging_except_enums) = true;
 option java_api_version = 2;

proto/nearby_client_enums.proto

@@ -16,6 +16,8 @@ syntax = "proto2";
 
 package location.nearby.proto;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
 option (logs_proto.file_not_used_for_logging_except_enums) = true;
 option java_api_version = 2;
@@ -27,6 +29,10 @@ option objc_class_prefix = "GNCP";
 enum UserType {
   UNKNOWN_USER_TYPE = 0;
   PRODUCTION = 1;
+  MODULEFOOD = 2;
+  TEST = 3;
+  PRESTO_DOGFOOD = 4;
+  AUTO_TEST = 5;
 }
 
 // The client that is logging.

proto/nearby_event_codes.proto

@@ -16,7 +16,11 @@ syntax = "proto2";
 
 package location.nearby.proto;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
+option (logs_proto.file_not_used_for_logging_except_enums) = true;
+option java_api_version = 2;
 option java_package = "com.google.location.nearby.proto";
 option java_outer_classname = "NearbyEventCodes";
 

proto/setup_enums.proto

@@ -16,7 +16,11 @@ syntax = "proto2";
 
 package location.nearby.proto.setup;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
+option (logs_proto.file_not_used_for_logging_except_enums) = true;
+option java_api_version = 2;
 option java_package = "com.google.location.nearby.proto";
 option java_outer_classname = "SetupEnums";
 option objc_class_prefix = "GNSP";

proto/sharing_enums.proto

@@ -16,7 +16,11 @@ syntax = "proto2";
 
 package location.nearby.proto.sharing;
 
+import "logs/proto/logs_annotations/logs_annotations.proto";
+
 option optimize_for = LITE_RUNTIME;
+option (logs_proto.file_not_used_for_logging_except_enums) = true;
+option java_api_version = 2;
 option java_package = "com.google.location.nearby.proto";
 option java_outer_classname = "SharingEnums";
 option objc_class_prefix = "GNSHP";