TySS-Dev/nearby
1
0
Fork 0
mirror of https://github.com/kidfromjupiter/nearby.git synced 2026-09-14 14:46:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't unregister an observer while inside an observer callback.

Browse Source 
PiperOrigin-RevId: 521860015
This commit is contained in:
hai007
2023-04-04 14:05:32 -07:00
committed by Copybara-Service
parent 13f7fb7966
commit f8f9c4fd4e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
connections/implementation/mediums/webrtc/webrtc_socket_impl.cc
+1 -1
View File
@@ -67,6 +67,7 @@ WebRtcSocket::WebRtcSocket(
WebRtcSocket::~WebRtcSocket() {
NEARBY_LOGS(INFO) << "WebRtcSocket::~WebRtcSocket(" << name_
<< ") this: " << this;
data_channel_->UnregisterObserver();
Close();
NEARBY_LOGS(INFO) << "WebRtcSocket::~WebRtcSocket(" << name_
<< ") this: " << this << " done";
@@ -108,7 +109,6 @@ void WebRtcSocket::OnStateChange() {
NEARBY_LOG(
ERROR,
"WebRtcSocket::OnStateChange() unregistering data channel observer.");
data_channel_->UnregisterObserver();
// This will trigger a destruction of the owning connection flow
// We implicitly depend on the |socket_listener_| to offload from
// the signaling thread so it does not get blocked.